refactor(rules): extract crawl logic into standalone functions

[gvozdvmozgu]

No description provided.

[github-actions]

Benchmark for 3ef0dcb

Click to view benchmark

Test	Base	PR	%
DepthMap::from_parent	39.8±0.43µs	40.3±0.33µs	+1.26%
fix_complex_query	9.3±0.06ms	9.6±0.49ms	+3.23%
fix_superlong	97.8±5.72ms	106.8±11.29ms	+9.20%
parse_complex_query	2.8±0.03µs	2.9±0.04µs	+3.57%
parse_expression_recursion	5.0±0.05µs	5.2±0.03µs	+4.00%
parse_simple_query	787.8±10.58ns	834.5±5.43ns	+5.93%

[benfdking]

Do you have any view as to why everything got slower?

[gvozdvmozgu]

Since merge #1554, performance has significantly decreased (Execution took: 332.133794ms on that PR).

[benfdking]

Yep I had to do that painful fix to get the python stuff working.

[gvozdvmozgu]

I don't have these issues locally, so it's possible that GitHub Actions is just under heavy load?

[gvozdvmozgu]

It seems that #1561 fixes the problem, and the numbers are more convincing again.

[gvozdvmozgu]

No, they’re still too noisy. Maybe we should run it at the very end—after everything else—and report the average over N runs.

[github-actions]

Benchmark for c717b8a

Click to view benchmark

Test	Base	PR	%
DepthMap::from_parent	41.7±0.19µs	40.1±0.27µs	-3.84%
fix_complex_query	9.3±0.04ms	9.3±0.58ms	0.00%
fix_superlong	91.8±5.80ms	99.4±14.68ms	+8.28%
parse_complex_query	2.9±0.04µs	2.8±0.02µs	-3.45%
parse_expression_recursion	5.1±0.05µs	5.0±0.06µs	-1.96%
parse_simple_query	806.1±7.88ns	793.8±10.32ns	-1.53%