refactor: unify LintingResult and Formatter APIs #1568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark for 35acae2Click to view benchmark
|
Benchmark for f9cb68eClick to view benchmark
|
gvozdvmozgu
force-pushed
the
linting-result-formatter-api
branch
from
601bd51 to
28022fd
Compare
Benchmark for 4655a09Click to view benchmark
|
gvozdvmozgu
force-pushed
the
linting-result-formatter-api
branch
from
28022fd to
aed4fd3
Compare
Benchmark for de62ed4Click to view benchmark
|
gvozdvmozgu
force-pushed
the
linting-result-formatter-api
branch
3 times, most recently
from
4025609 to
aa887f2
Compare
Benchmark for 50edd6aClick to view benchmark
|
Benchmark for cfcf121Click to view benchmark
|
gvozdvmozgu
force-pushed
the
linting-result-formatter-api
branch
from
e8414d6 to
aa887f2
Compare
gvozdvmozgu
force-pushed
the
linting-result-formatter-api
branch
from
aa887f2 to
80a07e7
Compare
Benchmark for bea2fd3Click to view benchmark
|
Benchmark for 73afa82Click to view benchmark
|
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the APIs for handling linting results and formatter outputs. It unifies the interfaces by replacing uses of get_violations with violations or into_violations, updates method signatures (e.g. dispatch_file_violations and completion_message), and adjusts tests and callers accordingly.
- Updated API usage for linting results and violation collection
- Refactored formatter interfaces and test assertions
- Unified methods across linter, CLI, and WASM integrations
Reviewed Changes
Copilot reviewed 12 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/lsp/src/lib.rs | Updated violation extraction by using into_violations() |
| crates/lib/tests/rules.rs | Renamed variables and updated assertions to call violations() |
| crates/lib/src/core/rules/noqa.rs | Replaced get_violations calls with violations() |
| crates/lib/src/core/linter/linting_result.rs | Refactored to use a new() constructor and added an IntoIterator implementation |
| crates/lib/src/core/linter/linted_file.rs | Updated violation API; added accessor methods and sorting in new() |
| crates/lib/src/core/linter/core.rs | Refactored instantiation of LintedFile and updated violation dispatch |
| crates/lib/src/cli/json.rs | Updated to use violations() and the accessor for path |
| crates/lib/src/cli/github_annotation_native_formatter.rs | Updated violation dispatch using violation.rule_code() and the new API |
| crates/lib/src/cli/formatters.rs | Adjusted formatter interface methods and test expectations |
| crates/lib-wasm/src/lib.rs | Refactored diagnostic construction to use immutable violation references |
| crates/cli-lib/src/commands_lint.rs | Updated invocation of completion_message with file count parameter |
| crates/cli-lib/src/commands_fix.rs | Streamlined fix logic by using new violation handling API |
Files not reviewed (2)
- crates/cli-python/tests/json/test_fail_whitespace_before_comma.stdout: Language not supported
- crates/cli/tests/json/test_fail_whitespace_before_comma.stdout: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.