-
Notifications
You must be signed in to change notification settings - Fork 36
refactor: remove base module and flatten module hierarchy #1583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the project by removing the legacy “base” modules and flattening the module hierarchy, simplifying import paths throughout the codebase.
- Updated import paths across multiple files by replacing references to "segments::base::ErasedSegment" with "segments::ErasedSegment".
- Removed the legacy "base" modules (in both parser/grammar and dialects), consolidating their functionality into the updated module structure.
Reviewed Changes
Copilot reviewed 153 out of 153 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
crates/lib-core/src/parser/node_matcher.rs | Updated import path for ErasedSegment to reflect the new module structure. |
crates/lib-core/src/parser/matchable.rs | Updated import paths for grammar and segments. |
crates/lib-core/src/dialects/base.rs | Removed file as part of the module flattening refactor. |
crates/lib-core/src/dialects.rs | Adjusted module contents to consolidate dialect functionality. |
(Other parser and grammar files) | Similar updates to remove references to the "base" submodule. |
Comments suppressed due to low confidence (2)
crates/lib-core/src/dialects/base.rs:1
- The removal of this deprecated base module appears intentional. Please confirm that no remaining components rely on this file and that all dependencies have been updated to reflect the new module structure.
Entire file removed
crates/lib-core/src/parser/node_matcher.rs:7
- The updated import path from 'segments::base::ErasedSegment' to 'segments::ErasedSegment' is consistent with the new module hierarchy. Please verify that all references throughout the codebase now correctly use the flattened structure.
+use crate::parser::segments::ErasedSegment;
6bf2a25
to
8f1a080
Compare
Benchmark for 7466a1aClick to view benchmark
|
Benchmark for b0e17c0Click to view benchmark
|
8f1a080
to
7846400
Compare
Benchmark for 965ba91Click to view benchmark
|
Benchmark for b0fcc8cClick to view benchmark
|
6a3559c
to
facac49
Compare
Benchmark for 906e1d6Click to view benchmark
|
facac49
to
d87f60e
Compare
I'll look into getting this in tonight |
Benchmark for 2059decClick to view benchmark
|
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [quarylabs/sqruff](https://github.com/quarylabs/sqruff) | minor | `v0.26.8` -> `v0.27.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>quarylabs/sqruff (quarylabs/sqruff)</summary> ### [`v0.27.0`](https://github.com/quarylabs/sqruff/releases/tag/v0.27.0) [Compare Source](quarylabs/sqruff@v0.26.8...v0.27.0) #### What's Changed - refactor: remove base module and flatten module hierarchy by [@​gvozdvmozgu](https://github.com/gvozdvmozgu) in quarylabs/sqruff#1583 - chore: update installation instructions by [@​benfdking](https://github.com/benfdking) in quarylabs/sqruff#1670 - chore: bump prettier from 3.5.3 to 3.6.0 by [@​dependabot](https://github.com/dependabot) in quarylabs/sqruff#1684 - chore: bump docker/setup-buildx-action from 3.10.0 to 3.11.1 by [@​dependabot](https://github.com/dependabot) in quarylabs/sqruff#1679 - chore: bump [@​vscode/test-web](https://github.com/vscode/test-web) from 0.0.69 to 0.0.70 by [@​dependabot](https://github.com/dependabot) in quarylabs/sqruff#1680 - chore: bump phf from 0.11.3 to 0.12.1 by [@​dependabot](https://github.com/dependabot) in quarylabs/sqruff#1678 - build(cargo): prune unused features `serde_with` by [@​gvozdvmozgu](https://github.com/gvozdvmozgu) in quarylabs/sqruff#1687 - chore: bump PyO3/maturin-action from 1.49.1 to 1.49.2 by [@​dependabot](https://github.com/dependabot) in quarylabs/sqruff#1682 - feat: Add T-SQL dialect support by [@​Fank](https://github.com/Fank) in quarylabs/sqruff#1664 - refactor: remove PHF dependency by [@​gvozdvmozgu](https://github.com/gvozdvmozgu) in quarylabs/sqruff#1686 - ci: add --no-fail-fast to cargo test commands by [@​Fank](https://github.com/Fank) in quarylabs/sqruff#1688 - fix: fix docker build by [@​benfdking](https://github.com/benfdking) in quarylabs/sqruff#1689 - fix: update Dockerfile to fix Python 3.11 build issue ([#​1676](quarylabs/sqruff#1676)) by [@​Fank](https://github.com/Fank) in quarylabs/sqruff#1677 - refactor(cli-lib): replace interactive fix prompt with --check flag by [@​gvozdvmozgu](https://github.com/gvozdvmozgu) in quarylabs/sqruff#1674 - chore: bump version by [@​benfdking](https://github.com/benfdking) in quarylabs/sqruff#1690 #### New Contributors - [@​Fank](https://github.com/Fank) made their first contribution in quarylabs/sqruff#1664 **Full Changelog**: quarylabs/sqruff@v0.26.8...v0.27.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC42Mi4xIiwidXBkYXRlZEluVmVyIjoiNDAuNjIuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
No description provided.