Skip to content

Conversation

@benfdking
Copy link
Collaborator

No description provided.

@benfdking benfdking linked an issue May 7, 2025 that may be closed by this pull request
1 task
@benfdking benfdking changed the title fix: leading comma panic fix: lt08 leading comma panic May 7, 2025
@github-actions
Copy link

github-actions bot commented May 7, 2025

Benchmark for f84346b

Click to view benchmark
Test Base PR %
DepthMap::from_parent 39.9±0.20µs 39.6±0.29µs -0.75%
fix_complex_query 9.3±0.34ms 9.8±0.61ms +5.38%
fix_superlong 97.2±3.61ms 102.7±6.41ms +5.66%
parse_complex_query 2.8±0.03µs 2.9±0.03µs +3.57%
parse_expression_recursion 5.0±0.04µs 5.1±0.05µs +2.00%
parse_simple_query 787.6±9.18ns 808.3±6.38ns +2.63%

@benfdking benfdking force-pushed the 1584-bug-lt08-panics branch from 5861d29 to e14b13d Compare May 18, 2025 10:50
@github-actions
Copy link

Benchmark for 72b92cb

Click to view benchmark
Test Base PR %
DepthMap::from_parent 41.6±0.28µs 40.2±0.30µs -3.37%
fix_complex_query 9.1±0.06ms 9.3±0.36ms +2.20%
fix_superlong 92.0±6.43ms 92.4±6.80ms +0.43%
parse_complex_query 2.9±0.02µs 2.9±0.03µs 0.00%
parse_expression_recursion 5.2±0.07µs 5.1±0.03µs -1.92%
parse_simple_query 825.5±16.83ns 810.9±11.57ns -1.77%

@benfdking benfdking force-pushed the 1584-bug-lt08-panics branch from e14b13d to f6f0801 Compare June 12, 2025 09:07
@benfdking benfdking force-pushed the 1584-bug-lt08-panics branch from f6f0801 to 7552084 Compare June 12, 2025 09:07
@github-actions
Copy link

Benchmark for 4c83459

Click to view benchmark
Test Base PR %
DepthMap::from_parent 39.4±0.38µs 40.5±0.32µs +2.79%
fix_complex_query 9.2±0.10ms 9.3±0.24ms +1.09%
fix_superlong 95.6±5.26ms 101.9±6.83ms +6.59%
parse_complex_query 3.0±0.04µs 2.9±0.03µs -3.33%
parse_expression_recursion 5.2±0.06µs 5.2±0.06µs 0.00%
parse_simple_query 869.0±11.06ns 795.5±10.04ns -8.46%

@github-actions
Copy link

Benchmark for 26fe5fd

Click to view benchmark
Test Base PR %
DepthMap::from_parent 39.5±0.31µs 40.5±0.30µs +2.53%
fix_complex_query 9.1±0.05ms 9.2±0.05ms +1.10%
fix_superlong 90.2±5.17ms 97.3±6.00ms +7.87%
parse_complex_query 2.9±0.03µs 2.9±0.03µs 0.00%
parse_expression_recursion 5.2±0.06µs 5.1±0.07µs -1.92%
parse_simple_query 803.4±11.37ns 807.6±11.74ns +0.52%

@benfdking benfdking merged commit 15d866d into main Jun 12, 2025
41 checks passed
@benfdking benfdking deleted the 1584-bug-lt08-panics branch June 12, 2025 10:56
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Jun 23, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [quarylabs/sqruff](https://github.com/quarylabs/sqruff) | patch | `v0.26.6` -> `v0.26.8` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>quarylabs/sqruff (quarylabs/sqruff)</summary>

### [`v0.26.8`](https://github.com/quarylabs/sqruff/releases/tag/v0.26.8)

[Compare Source](quarylabs/sqruff@v0.26.7...v0.26.8)

#### What's Changed

- ci: improve ci cancellation by [@&#8203;benfdking](https://github.com/benfdking) in quarylabs/sqruff#1666
- fix: fix open vsx release by [@&#8203;benfdking](https://github.com/benfdking) in quarylabs/sqruff#1667
- chore: bump version by [@&#8203;benfdking](https://github.com/benfdking) in quarylabs/sqruff#1668

**Full Changelog**: quarylabs/sqruff@v0.26.7...v0.26.8

### [`v0.26.7`](https://github.com/quarylabs/sqruff/releases/tag/v0.26.7)

[Compare Source](quarylabs/sqruff@v0.26.6...v0.26.7)

#### What's Changed

- fix: lt08 leading comma panic by [@&#8203;benfdking](https://github.com/benfdking) in quarylabs/sqruff#1585
- chore: bump typescript-eslint from 8.33.1 to 8.34.0 by [@&#8203;dependabot](https://github.com/dependabot) in quarylabs/sqruff#1649
- chore: bump [@&#8203;types/react](https://github.com/types/react) from 19.1.6 to 19.1.8 by [@&#8203;dependabot](https://github.com/dependabot) in quarylabs/sqruff#1651
- chore: bump clap from 4.5.39 to 4.5.40 by [@&#8203;dependabot](https://github.com/dependabot) in quarylabs/sqruff#1656
- chore: bump pyo3 from 0.25.0 to 0.25.1 by [@&#8203;dependabot](https://github.com/dependabot) in quarylabs/sqruff#1654
- chore: bump react-resizable-panels from 3.0.2 to 3.0.3 by [@&#8203;dependabot](https://github.com/dependabot) in quarylabs/sqruff#1653
- chore: bump [@&#8203;playwright/test](https://github.com/playwright/test) from 1.52.0 to 1.53.0 by [@&#8203;dependabot](https://github.com/dependabot) in quarylabs/sqruff#1650
- chore: bump serde\_with from 3.12.0 to 3.13.0 by [@&#8203;dependabot](https://github.com/dependabot) in quarylabs/sqruff#1655
- chore: bump actions/attest-build-provenance from 2.3.0 to 2.4.0 by [@&#8203;dependabot](https://github.com/dependabot) in quarylabs/sqruff#1647
- chore: bump stefanzweifel/git-auto-commit-action from 5.2.0 to 6.0.1 by [@&#8203;dependabot](https://github.com/dependabot) in quarylabs/sqruff#1648
- chore: tailwind update by [@&#8203;benfdking](https://github.com/benfdking) in quarylabs/sqruff#1641
- chore: remove jemalloc by [@&#8203;benfdking](https://github.com/benfdking) in quarylabs/sqruff#1659
- feat(clickhouse): add distinct on functionality by [@&#8203;benfdking](https://github.com/benfdking) in quarylabs/sqruff#1660
- chore: bump tailwindcss from 3.4.17 to 4.1.10 by [@&#8203;dependabot](https://github.com/dependabot) in quarylabs/sqruff#1652
- refactor(rules): extract crawl logic into standalone functions by [@&#8203;gvozdvmozgu](https://github.com/gvozdvmozgu) in quarylabs/sqruff#1559
- chore: update cargo deps by [@&#8203;benfdking](https://github.com/benfdking) in quarylabs/sqruff#1662
- chore: update node dependencies by [@&#8203;benfdking](https://github.com/benfdking) in quarylabs/sqruff#1663
- ci: deploy extension to vsx by [@&#8203;benfdking](https://github.com/benfdking) in quarylabs/sqruff#1661
- chore: bump package version by [@&#8203;benfdking](https://github.com/benfdking) in quarylabs/sqruff#1665

**Full Changelog**: quarylabs/sqruff@v0.26.6...v0.26.7

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC42Mi4xIiwidXBkYXRlZEluVmVyIjoiNDAuNjIuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: lt08 panics

2 participants