Add ASOF JOIN parsing for Snowflake #1611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

benfdking wants to merge 1 commit into main from codex/fix-rf01-linting-violation-for-asof-join

Collaborator

benfdking commented May 21, 2025

Summary

support ASOF JOIN syntax in Snowflake by adding keywords and grammar
add MatchConditionClause segment
update Snowflake keyword lists
add regression test for RF01 with ASOF JOIN
include new dialect fixture for ASOF JOIN

Testing

UPDATE_EXPECT=1 cargo test --test dialects --manifest-path crates/lib-dialects/Cargo.toml
cargo test --all --all-features --exclude sqruff (fails: libpython missing)


          Add ASOF join support for Snowflake

db7823a

benfdking added the codex label

— with

ChatGPT Connector

github-actions bot commented May 21, 2025

Benchmark for `40786c6`

Click to view benchmark

Test	Base	PR	%
DepthMap::from_parent	39.9±0.42µs	40.1±0.49µs	+0.50%
fix_complex_query	9.7±0.10ms	9.7±0.22ms	0.00%
fix_superlong	101.4±8.21ms	103.8±7.64ms	+2.37%
parse_complex_query	2.9±0.03µs	2.9±0.02µs	0.00%
parse_expression_recursion	5.2±0.05µs	5.1±0.06µs	-1.92%
parse_simple_query	807.8±14.67ns	806.1±15.68ns	-0.21%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels