-
Notifications
You must be signed in to change notification settings - Fork 68
Add support for Playwright Component and E2E Testing #396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know the PR is not ready for review, but wanted to leave an early review
/* Port to use for Playwright component endpoint. */ | ||
ctPort: 3100, | ||
|
||
ctViteConfig: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say we should try passing the whole config with the @quasar/app-vite/lib/testing.js
, or a slimmed-down version of it, instead of just the vue
and quasar
plugins. This is especially important for allowing the use of aliases, e.g. import x from 'src/foo'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean @quasar/app-vite/lib/config-tools.js
? Could you please check if you provided the wrong path? I checked and did not find the testing.js
in that path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's imported as @quasar/app-vite/lib/testing.js
, but live inside app-vite/exports/testing/testing.js
https://github.com/quasarframework/quasar/blob/259a400d258c26fc5b7fd068e9247e189f574af4/app-vite/package.json#L49-L51
https://github.com/quasarframework/quasar/blob/dev/app-vite/exports/testing/testing.js
@yusufkandemir, could you also review #390 again? A lot of people are waiting on it so Vitest 3 could finally be supported. |
@n05la3 please rebase this PR on dev branch and address the issues Yusuf mentioned |
- Let's prefer the built in route test
…sions - This bug was caused wrong export definition in package.json which prevented the prompt from being imported correctly
- Unbuild offers a better way to generate a build that works well with commonjs and module. It can correcly name all module files as .mjs and common as .cjs, this makes it easy for consumers to import
3c69387
to
05283ca
Compare
05283ca
to
3900150
Compare
What kind of change does this PR introduce? (check at least one)
If you are adding a new test runner, have you...? (check all)
/packages/base/runners.json
?/README.md
?baseline.spec.vue
?Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
dev
branch and not themaster
branchfix: #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: