Skip to content

Conversation

n05la3
Copy link
Contributor

@n05la3 n05la3 commented Apr 3, 2025

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • New test runner
  • Documentation
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

If you are adding a new test runner, have you...? (check all)

  • Created an issue first?
  • Registered it in /packages/base/runners.json?
  • Added it to /README.md?
  • Included one test that runs baseline.spec.vue?
  • Added and updated documentation?
  • Included a recipe folder with properly building quasar project?

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on Windows
  • It's been tested on Linux
  • It's been tested on MacOS
  • Any necessary documentation has been added or updated in the docs (for faster update click on "Suggest an edit on GitHub" at bottom of page) or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Copy link
Member

@yusufkandemir yusufkandemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know the PR is not ready for review, but wanted to leave an early review

/* Port to use for Playwright component endpoint. */
ctPort: 3100,

ctViteConfig: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say we should try passing the whole config with the @quasar/app-vite/lib/testing.js, or a slimmed-down version of it, instead of just the vue and quasar plugins. This is especially important for allowing the use of aliases, e.g. import x from 'src/foo'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean @quasar/app-vite/lib/config-tools.js? Could you please check if you provided the wrong path? I checked and did not find the testing.js in that path.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mtdvlpr
Copy link

mtdvlpr commented Apr 22, 2025

@yusufkandemir, could you also review #390 again? A lot of people are waiting on it so Vitest 3 could finally be supported.

@yusufkandemir
Copy link
Member

@mtdvlpr that's ready to be merged, internally known. But I don't manage the releases, so there's nothing more I can do.
/cc @IlCallo

@IlCallo
Copy link
Member

IlCallo commented May 2, 2025

@n05la3 please rebase this PR on dev branch and address the issues Yusuf mentioned

n05la3 added 26 commits May 13, 2025 16:53
- Let's prefer the built in route test
@n05la3 n05la3 force-pushed the feature/add-playwright-ae branch 2 times, most recently from 3c69387 to 05283ca Compare May 14, 2025 08:15
@n05la3 n05la3 force-pushed the feature/add-playwright-ae branch from 05283ca to 3900150 Compare May 22, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants