Add support for Playwright Component and E2E Testing by n05la3 · Pull Request #396 · quasarframework/quasar-testing

n05la3 · 2025-04-03T07:23:30Z

What kind of change does this PR introduce? (check at least one)

If you are adding a new test runner, have you...? (check all)

Created an issue first?
Registered it in /packages/base/runners.json?
Added it to /README.md?
Included one test that runs baseline.spec.vue?
Added and updated documentation?
Included a recipe folder with properly building quasar project?

Does this PR introduce a breaking change? (check one)

Yes
No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

It's submitted to the dev branch and not the master branch
When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
It's been tested on Windows
It's been tested on Linux
It's been tested on MacOS
Any necessary documentation has been added or updated in the docs (for faster update click on "Suggest an edit on GitHub" at bottom of page) or explained in the PR's description.

If adding a new feature, the PR's description includes:

A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

yusufkandemir

I know the PR is not ready for review, but wanted to leave an early review

packages/e2e-playwright/package.json

packages/e2e-playwright/src/prompts.js

yusufkandemir · 2025-04-16T20:12:46Z

packages/e2e-playwright/src/templates/javascript/playwright-ct.config.js

+    /* Port to use for Playwright component endpoint. */
+    ctPort: 3100,
+
+    ctViteConfig: {


I would say we should try passing the whole config with the @quasar/app-vite/lib/testing.js, or a slimmed-down version of it, instead of just the vue and quasar plugins. This is especially important for allowing the use of aliases, e.g. import x from 'src/foo'

Did you mean @quasar/app-vite/lib/config-tools.js? Could you please check if you provided the wrong path? I checked and did not find the testing.js in that path.

It's imported as @quasar/app-vite/lib/testing.js, but live inside app-vite/exports/testing/testing.js
https://github.com/quasarframework/quasar/blob/259a400d258c26fc5b7fd068e9247e189f574af4/app-vite/package.json#L49-L51
https://github.com/quasarframework/quasar/blob/dev/app-vite/exports/testing/testing.js

packages/e2e-playwright/src/templates/test-watcher.ts

packages/e2e-playwright/src/install.js

mtdvlpr · 2025-04-22T07:01:46Z

@yusufkandemir, could you also review #390 again? A lot of people are waiting on it so Vitest 3 could finally be supported.

yusufkandemir · 2025-04-22T07:41:02Z

@mtdvlpr that's ready to be merged, internally known. But I don't manage the releases, so there's nothing more I can do.
/cc @IlCallo

IlCallo · 2025-05-02T16:42:39Z

@n05la3 please rebase this PR on dev branch and address the issues Yusuf mentioned

…ight

- Let's prefer the built in route test

…sions - This bug was caused wrong export definition in package.json which prevented the prompt from being imported correctly

- Unbuild offers a better way to generate a build that works well with commonjs and module. It can correcly name all module files as .mjs and common as .cjs, this makes it easy for consumers to import

yusufkandemir requested changes Apr 16, 2025

View reviewed changes

n05la3 added 26 commits May 13, 2025 16:53

feat(playwright): add prompts

830f129

feat(playwright): initial setup

2efd733

feat(playwright): setup esm and ejs build

782ee1d

chore(playwright): setup eslint and husky

31a22fb

feat(playwright): set compatible Quasar version and enforce server port

01a32e8

feat(playwright): add scripts to run in watch mode

1cea571

feat(playwright): implement AE installation

5e16504

feat(playwright): add files to .gitignore file during installation

266a270

feat(client): control the installation instead of depending on Playwr…

ac0d288

…ight

feat(playwright): add sample workflow file

aa24800

feat(playwright): add Playwright configs for component and e2e testing

f69d738

feat(playwright): add color utility

85516b3

feat(playwright): add portal utils

0b67bea

fix(playwright): add default port

5355a2c

feat(playwright): add color assertions utils

2cfc3f3

feat(playwright): add test route utils

a67b8da

feat(playwright): export utils for library use

6018c12

feat(playwright): add components for test

43b3c48

feat(playwright): add more component templates and config files

952f859

feat(playwright): add js and ts templates

77a7ac3

feat(playwright): setup app-vite playwright test app

ef1877a

feat(playwright): add component tests

299d2cb

fix(playwright): adjust how prompts are handled

ca30c61

feat(playwright): add support for component testing to component config

8eb5840

feat(playwright): add code coverage flag to e2e template

b85674a

refactor(playwright): remove test-route.ts utility function

2aa34bd

- Let's prefer the built in route test

n05la3 added 13 commits May 13, 2025 17:22

refactor(playwright): rename color assertions

ed4c011

feat(playwright): add component test fixture

895d934

refactor(playwright): move tests to base template

7d27cba

fix(playwright): fix bug preventing prompt in new stable app-vite ver…

848beca

…sions - This bug was caused wrong export definition in package.json which prevented the prompt from being imported correctly

feat(playwright): many random improvement for code coverage support

c1c72f8

feat(playwright): init empty project and setup playwright

ba2bc66

feat(playwright): sync project

f9bb68d

refactor(playwright): adjust the nyc config

2bb2629

fix(playwright): fix component fixture typing

e26711e

refactor(plawright): improve templates

8d43950

feat(playwright): add flag to control whether to enable coverage or not

22047eb

feat(playwright): prefer unbuild to tsc for building the extension

ba66b49

- Unbuild offers a better way to generate a build that works well with commonjs and module. It can correcly name all module files as .mjs and common as .cjs, this makes it easy for consumers to import

chore(playwright): sync test project

e07b8eb

n05la3 force-pushed the feature/add-playwright-ae branch 2 times, most recently from 3c69387 to 05283ca Compare May 14, 2025 08:15

n05la3 added 3 commits May 21, 2025 07:24

refactor(playwright): minor utility improvement

80f1ce7

feat(playwright): sync test apps

3290dc1

manor minor fixes, resync/update test apps

3900150

n05la3 force-pushed the feature/add-playwright-ae branch from 05283ca to 3900150 Compare May 22, 2025 11:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Playwright Component and E2E Testing#396

Add support for Playwright Component and E2E Testing#396
n05la3 wants to merge 42 commits intoquasarframework:devfrom
n05la3:feature/add-playwright-ae

n05la3 commented Apr 3, 2025

Uh oh!

yusufkandemir left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yusufkandemir Apr 16, 2025

Uh oh!

n05la3 May 8, 2025

Uh oh!

yusufkandemir May 8, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mtdvlpr commented Apr 22, 2025

Uh oh!

yusufkandemir commented Apr 22, 2025

Uh oh!

IlCallo commented May 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

n05la3 commented Apr 3, 2025

Uh oh!

yusufkandemir left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yusufkandemir Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

n05la3 May 8, 2025

Choose a reason for hiding this comment

Uh oh!

yusufkandemir May 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mtdvlpr commented Apr 22, 2025

Uh oh!

yusufkandemir commented Apr 22, 2025

Uh oh!

IlCallo commented May 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants