Skip to content

Conversation

@diadal
Copy link
Contributor

@diadal diadal commented Dec 1, 2024

What kind of change does this PR introduce?

  • Bugfix
  • [ *] Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • [ *] No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on an Electron app
  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to start a new feature discussion first and wait for approval before working on it)

Other information:

@github-actions
Copy link

github-actions bot commented Dec 1, 2024

Build Results

JSON API

📜 Changes detected:

diff --git a/./current-build/api/Dark.json b/./pr-build/api/Dark.json
index a91bc02..d1dbe20 100644
--- a/./current-build/api/Dark.json
+++ b/./pr-build/api/Dark.json
@@ -18,6 +18,11 @@
     ]
   },
   "props": {
+    "isEnabled": {
+      "type": "Boolean",
+      "desc": "Is Dark mode enabled?",
+      "reactive": true
+    },
     "isActive": {
       "type": "Boolean",
       "desc": "Is Dark mode active?",

Types

📜 Changes detected:

diff --git a/./current-build/types/index.d.ts b/./pr-build/types/index.d.ts
index 2fad780..c931a52 100644
--- a/./current-build/types/index.d.ts
+++ b/./pr-build/types/index.d.ts
@@ -213,6 +213,10 @@ export interface Cookies {
 }
 
 export interface Dark {
+  /**
+   * Is Dark mode enabled?
+   */
+  isEnabled: boolean;
   /**
    * Is Dark mode active?
    */

@rstoenescu
Copy link
Member

Hi,

This PR by its own adds a non-existent prop.

@rstoenescu rstoenescu closed this Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants