Skip to content

feat(ui): add indicator-shape prop to QTabs #17978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

stefanvanherwijnen
Copy link
Contributor

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on an Electron app
  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to start a new feature discussion first and wait for approval before working on it)

Other information:
Material Design 3 introduces a navigation rail, which is similar to (Q)Tabs but the active indicator is different (pill shape vs line). This PR adds a indicator-shape prop to QTabs which makes it possible to use the pill shape active indicator and use QTabs for a navigation rail.

gif

Copy link

Build Results

JSON API

📜 Changes detected:

diff --git a/./current-build/api/QTabs.json b/./pr-build/api/QTabs.json
index e4ca148..9f63c8b 100644
--- a/./current-build/api/QTabs.json
+++ b/./pr-build/api/QTabs.json
@@ -90,6 +90,17 @@
       ],
       "category": "style"
     },
+    "indicator-shape": {
+      "type": "String",
+      "desc": "The shape of the active indicator.",
+      "default": "'line'",
+      "examples": [
+        "'line'",
+        "'pill'"
+      ],
+      "category": "style",
+      "required": false
+    },
     "content-class": {
       "type": "String",
       "desc": "Class definitions to be attributed to the content wrapper",

Types

📜 Changes detected:

diff --git a/./current-build/types/index.d.ts b/./pr-build/types/index.d.ts
index 06232b6..29fffaf 100644
--- a/./current-build/types/index.d.ts
+++ b/./pr-build/types/index.d.ts
@@ -14679,6 +14679,11 @@ export interface QTabsProps {
    * The color to be attributed to the indicator (the underline) of the active tab
    */
   indicatorColor?: NamedColor | undefined;
+  /**
+   * The shape of the active indicator.
+   * Default value: 'line'
+   */
+  indicatorShape?: string | undefined;
   /**
    * Class definitions to be attributed to the content wrapper
    */

Copy link

UI Tests Results

    1 files     98 suites   38s ⏱️
1 031 tests 1 031 ✅ 0 💤 0 ❌
1 050 runs  1 050 ✅ 0 💤 0 ❌

Results for commit 1497936.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant