Skip to content

Conversation

@SamVanini
Copy link
Contributor

@SamVanini SamVanini commented May 4, 2025

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on an Electron app
  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to start a new feature discussion first and wait for approval before working on it)

Other information:
As stated in issue #17988, ariaLabel is not rendered as 'aria-label' in certain testing environments, so I replaced it.
Sorry for the inconvenience, when I first submitted the PR related to this attribute I didn't think about testing libraries emulating the DOM, my bad

@github-actions
Copy link

github-actions bot commented May 4, 2025

UI Tests Results

    1 files     98 suites   40s ⏱️
1 031 tests 1 031 ✅ 0 💤 0 ❌
1 050 runs  1 050 ✅ 0 💤 0 ❌

Results for commit 40fddfc.

@yusufkandemir
Copy link
Member

Thanks for contributing 👏👏

@yusufkandemir yusufkandemir merged commit 259a400 into quasarframework:dev May 7, 2025
3 checks passed
@segamiken
Copy link

Thank you!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants