fix(ui): add slot for dropdown button in split mode #16955#18061
Open
SamVanini wants to merge 2 commits intoquasarframework:devfrom
Open
fix(ui): add slot for dropdown button in split mode #16955#18061SamVanini wants to merge 2 commits intoquasarframework:devfrom
SamVanini wants to merge 2 commits intoquasarframework:devfrom
Conversation
Build ResultsJSON API📜 Changes detected: diff --git a/./current-build/api/QBtnDropdown.json b/./pr-build/api/QBtnDropdown.json
index 9637898..5637708 100644
--- a/./current-build/api/QBtnDropdown.json
+++ b/./pr-build/api/QBtnDropdown.json
@@ -478,6 +478,9 @@
"loading": {
"desc": "Override the default QSpinner when in 'loading' state",
"addedIn": "v2.8"
+ },
+ "arrow-container": {
+ "desc": "Customize arrow container button's content when using 'split' prop"
}
},
"events": {Types📜 Changes detected: diff --git a/./current-build/types/index.d.ts b/./pr-build/types/index.d.ts
index 97a97eb..e9b2aae 100644
--- a/./current-build/types/index.d.ts
+++ b/./pr-build/types/index.d.ts
@@ -4201,6 +4201,10 @@ export interface QBtnDropdownSlots {
* Override the default QSpinner when in 'loading' state
*/
loading: () => VNode[];
+ /**
+ * Customize arrow container button's content when using 'split' prop
+ */
+ "arrow-container": () => VNode[];
}
export interface QBtnDropdown |
UI Tests Results 1 files 98 suites 41s ⏱️ Results for commit 1a7eb88. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements:
devbranch (orv[X]branch)fix: #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
The following PR adds a slot to the dropdown button of QBtnDropdown component, when split prop is used. This change allows to customize even this button, enabling the user to add tooltips or other accessibility related attributes
To clarify and document this new slot I updated the docs section, providing a practical example using the one available for label slot usage as blueprint
Fix #16955