feat(QRange): new props -> min-range and max-range#18182
Open
thexeos wants to merge 1 commit intoquasarframework:devfrom
Open
feat(QRange): new props -> min-range and max-range#18182thexeos wants to merge 1 commit intoquasarframework:devfrom
thexeos wants to merge 1 commit intoquasarframework:devfrom
Conversation
42b214f to
6f301b2
Compare
Build ResultsJSON API📜 Changes detected: diff --git a/./current-build/api/QRange.json b/./pr-build/api/QRange.json
index 5067ca5..c221004 100644
--- a/./current-build/api/QRange.json
+++ b/./pr-build/api/QRange.json
@@ -414,6 +414,25 @@
"# v-model=\"positionModel\""
]
},
+ "min-range": {
+ "type": "Number",
+ "default": "0",
+ "desc": "Minimum allowed difference between the max and min values",
+ "category": "model",
+ "addedIn": "v2.18.7",
+ "required": false
+ },
+ "max-range": {
+ "type": [
+ "Number",
+ "null"
+ ],
+ "default": "null",
+ "desc": "Maximum allowed difference between the max and min values",
+ "category": "model",
+ "addedIn": "v2.18.7",
+ "required": false
+ },
"drag-range": {
"type": "Boolean",
"desc": "User can drag range instead of just the two thumbs",Types📜 Changes detected: diff --git a/./current-build/types/index.d.ts b/./pr-build/types/index.d.ts
index a72729b..c869407 100644
--- a/./current-build/types/index.d.ts
+++ b/./pr-build/types/index.d.ts
@@ -10072,6 +10072,16 @@ export interface QRangeProps {
}
| null
| undefined;
+ /**
+ * Minimum allowed difference between the max and min values
+ * Default value: 0
+ */
+ minRange?: number | undefined;
+ /**
+ * Maximum allowed difference between the max and min values
+ * Default value: null
+ */
+ maxRange?: number | null | undefined;
/**
* User can drag range instead of just the two thumbs
*/ |
UI Tests Results 1 files 98 suites 41s ⏱️ Results for commit 6f301b2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements:
devbranch (orv[X]branch)If adding a new feature, the PR's description includes:
Sometimes it is necessary to cap the range input model not to maximum/minimum value within the range (
innerMin/innerMax) but to a minimum or maximum range width. Example would include things like entering event duration, where minimum duration is 15 minutes, but it can be placed anywhere within the hour block.The feature replicates the behavior of
innerMin/innerMax, where external changes tomodelValuethat would fall outside the range ofinnerMin/innerMaxare "ignored" and insteadinnerMin/innerMaxvalue is used.