Skip to content

Conversation

@HannesOberreiter
Copy link
Contributor

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on an Electron app
  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to start a new feature discussion first and wait for approval before working on it)

Other information:

There is no menu-fit attribute on QBtnDropdown. I don't know if the text should also contain that menu-anchor will be used for selfOrigin, if cover is set to true. See code.

// https://github.com/quasarframework/quasar/blob/dev/ui/src/components/menu/QMenu.js#L135
    const anchorOrigin = computed(() =>
      parsePosition(
        props.anchor || (
          props.cover === true ? 'center middle' : 'bottom start'
        ),
        $q.lang.rtl
      )
    )

    const selfOrigin = computed(() => (
      props.cover === true
        ? anchorOrigin.value
        : parsePosition(props.self || 'top start', $q.lang.rtl)
    ))

@github-actions
Copy link

Build Results

JSON API

📜 Changes detected:

diff --git a/./current-build/api/QBtnDropdown.json b/./pr-build/api/QBtnDropdown.json
index 9637898..e4e9b1c 100644
--- a/./current-build/api/QBtnDropdown.json
+++ b/./pr-build/api/QBtnDropdown.json
@@ -365,7 +365,7 @@
     },
     "cover": {
       "type": "Boolean",
-      "desc": "Allows the menu to cover the button. When used, the 'menu-self' and 'menu-fit' props are no longer effective",
+      "desc": "Allows the menu to cover the button. When used, the 'menu-self' prop is no longer effective",
       "category": "position"
     },
     "persistent": {

Types

📜 Changes detected:

diff --git a/./current-build/types/index.d.ts b/./pr-build/types/index.d.ts
index a72729b..92cb7c7 100644
--- a/./current-build/types/index.d.ts
+++ b/./pr-build/types/index.d.ts
@@ -4079,7 +4079,7 @@ export interface QBtnDropdownProps {
    */
   contentClass?: VueClassProp | undefined;
   /**
-   * Allows the menu to cover the button. When used, the 'menu-self' and 'menu-fit' props are no longer effective
+   * Allows the menu to cover the button. When used, the 'menu-self' prop is no longer effective
    */
   cover?: boolean | undefined;
   /**

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant