Skip to content

fix(app-vite): audit PWA mode guidance#18363

Open
hawkeye64 wants to merge 3 commits into
quasarframework:devfrom
hawkeye64:docs/audit-pwa
Open

fix(app-vite): audit PWA mode guidance#18363
hawkeye64 wants to merge 3 commits into
quasarframework:devfrom
hawkeye64:docs/audit-pwa

Conversation

@hawkeye64

Copy link
Copy Markdown
Member

Summary

  • invoke function-valued injectPWAMetaTags callbacks instead of treating them as the boolean default
  • correct the PWA favicon path and stale Workbox configuration name
  • clarify secure-context behavior for localhost, LAN addresses, custom hostnames, and HTTPS tunnels
  • remove unrelated Cordova/mobile wording and update TypeScript terminology

Root cause

updateHeadTags() checked whether injectPWAMetaTags was truthy before checking whether it was a function. Since functions are truthy, callback values always entered the default-tag branch and the callback was never invoked. The function check now runs first; boolean true retains the existing default tags and false still disables them.

Verification

  • directly exercised manifest injection and confirmed custom callback output replaces the default tags
  • pnpm exec oxfmt --check app-vite/lib/modes/pwa/pwa-utils.js docs/src/pages/quasar-cli-vite/developing-pwa/*.md
  • pnpm exec oxlint --deny-warnings app-vite/lib/modes/pwa/pwa-utils.js
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant