fix(app-vite): audit PWA mode guidance#18363
Open
hawkeye64 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
injectPWAMetaTagscallbacks instead of treating them as the boolean defaultRoot cause
updateHeadTags()checked whetherinjectPWAMetaTagswas truthy before checking whether it was a function. Since functions are truthy, callback values always entered the default-tag branch and the callback was never invoked. The function check now runs first; booleantrueretains the existing default tags andfalsestill disables them.Verification
pnpm exec oxfmt --check app-vite/lib/modes/pwa/pwa-utils.js docs/src/pages/quasar-cli-vite/developing-pwa/*.mdpnpm exec oxlint --deny-warnings app-vite/lib/modes/pwa/pwa-utils.jsgit diff --check