fix(app-vite): audit BEX mode and guide#18365
Open
hawkeye64 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bex.minifyoption and modernize BEX setup, debugging, and TypeScript guidanceManifest JSON examples
The inline
// Popup Page,// Options Page, and// Dev Toolslabels were removed from the manifest examples because browser-extension manifests must be valid JSON, and JSON does not support comments. The property names already identify each entry, while removing the comments keeps the examples directly copyable intomanifest.json.Root causes and impact
The development watchers copied changed files but did not remove stale generated assets. The Firefox public-file watcher also copied changes beside
manifest.jsonrather than into the generatedwwwdirectory. This could leave the loaded development extension out of sync with its source. Several guide examples still used the former positional bridge API and listener response shape, causing copied examples to fail against the current implementation.Validation
git diff --check