ncm-altlogrotate: global logrotate config fails to be modified in some cases #1813
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpoely86
previously approved these changes
Feb 27, 2025
|
This fixes #1657 |
ned21
requested changes
Mar 2, 2025
There was a problem hiding this comment.
Sorry if this sounds a bit paranoid but a commit message which only references a ticket in the bug tracking system could lead to problems in the future since there's no guarantee we'll be able to migrate the bug data along with git repository to pastures new. Could you please provide a full explanation of the change being made in the commit log so it documents the change alongside the code?
…when reaching the if of line 138, and if we don't check the value of $overallglobal (that is switched to 1 in case of an entry named 'global'), then the block of code modifying the global configuration file will be skipped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #1657 for more details