-
Notifications
You must be signed in to change notification settings - Fork 12
el8/9: Make architecture independent #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
43cd2da to
7ce8068
Compare
7ce8068 to
df7a2e2
Compare
jouvin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! In particular all the linting cleanup!
|
@jrha I let you merge it, in case you still want to add something... |
5126b89 to
df7a2e2
Compare
|
Thanks @jouvin, I've added two symlinks to preserve backwards compatibility for now. |
These only work when the library is being used correctly as a namespace.
6f086c7 to
1d3bd13
Compare
|
I'm happy for this to be merged now if you still are. |
|
@jrha I have mixed feelings about the symlink addition. OOH it makes the changes backward-compatible which is always good. OTOH, it maintains something that is not so difficult to update and is just adding "complexity" (everything relative!). An alternative would be, IMO, not to add the symlinks but add to the release notes and README that this backward-incompatible rename was made to simplify the template library and that to use it a site has the choice to update the OS version used removing the architecture or to define the symlink. But may be it makes the life more difficult in Aquilon where the library is imported as is if I'm right... I let you decide! Feel free to merge it after taking your decision! |
jouvin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment about added symlinks for backward compatibility
|
Definitely pros and cons either way, I think I'd like to provide the symlinks for at least one release as it definitely makes switching over in aquilon much smoother. |
Resolves #110.