Skip to content

Conversation

@jrha
Copy link
Member

@jrha jrha commented Sep 19, 2025

Resolves #110.

@jrha jrha added this to the 25.next milestone Sep 19, 2025
@jrha jrha force-pushed the architecture_independence branch from 43cd2da to 7ce8068 Compare September 19, 2025 14:27
@jrha jrha changed the title Architecture independence el8/9: Make architecture independent Sep 19, 2025
@jrha jrha force-pushed the architecture_independence branch from 7ce8068 to df7a2e2 Compare October 14, 2025 14:00
@jrha jrha marked this pull request as ready for review October 14, 2025 15:13
@jouvin jouvin self-requested a review October 16, 2025 07:25
jouvin
jouvin previously approved these changes Oct 16, 2025
Copy link
Contributor

@jouvin jouvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! In particular all the linting cleanup!

@jouvin
Copy link
Contributor

jouvin commented Oct 16, 2025

@jrha I let you merge it, in case you still want to add something...

@jrha
Copy link
Member Author

jrha commented Oct 21, 2025

Thanks @jouvin, I've added two symlinks to preserve backwards compatibility for now.

These only work when the library is being used correctly as a namespace.
@jrha jrha force-pushed the architecture_independence branch from 6f086c7 to 1d3bd13 Compare October 21, 2025 10:51
@jrha
Copy link
Member Author

jrha commented Oct 21, 2025

I'm happy for this to be merged now if you still are.

@jouvin
Copy link
Contributor

jouvin commented Oct 23, 2025

@jrha I have mixed feelings about the symlink addition. OOH it makes the changes backward-compatible which is always good. OTOH, it maintains something that is not so difficult to update and is just adding "complexity" (everything relative!). An alternative would be, IMO, not to add the symlinks but add to the release notes and README that this backward-incompatible rename was made to simplify the template library and that to use it a site has the choice to update the OS version used removing the architecture or to define the symlink. But may be it makes the life more difficult in Aquilon where the library is imported as is if I'm right...

I let you decide! Feel free to merge it after taking your decision!

jouvin

This comment was marked as duplicate.

Copy link
Contributor

@jouvin jouvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment about added symlinks for backward compatibility

@jrha
Copy link
Member Author

jrha commented Oct 29, 2025

Definitely pros and cons either way, I think I'd like to provide the symlinks for at least one release as it definitely makes switching over in aquilon much smoother.

@jrha jrha merged commit ff6307c into quattor:main Oct 29, 2025
3 checks passed
@jrha jrha deleted the architecture_independence branch October 29, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

OS templates should be independent of processor architecture

2 participants