General housekeep, Pure Go pcsc client and support for NitroKey 3

.github/workflows/codeql.yaml

@@ -0,0 +1,49 @@
+name: CodeQL
+
+on:
+  push:
+    branches: [ "main" ]
+  pull_request:
+  workflow_dispatch:
+  schedule:
+    - cron: '00 1 * * 1'
+
+permissions: {}
+
+jobs:
+  analyze:
+    name: Analyze
+    runs-on: ubuntu-latest
+    permissions:
+      actions: read
+      contents: read
+      security-events: write
+
+    strategy:
+      fail-fast: false
+      matrix:
+        language: [ 'go', 'actions' ]
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+
+      - name: Install libpcsc
+        run: sudo apt-get install -y libpcsclite-dev pcscd pcsc-tools
+
+      # Initializes the CodeQL tools for scanning.
+      - name: Initialize CodeQL
+        uses: github/codeql-action/init@1b549b9259bda1cb5ddde3b41741a82a2d15a841 # v3.28.13
+        with:
+          languages: ${{ matrix.language }}
+          # xref: https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-code-scanning#using-queries-in-ql-packs
+          # xref: https://codeql.github.com/codeql-query-help/go/
+          queries: security-and-quality
+
+      - name: Manual Build
+        run: go build ./...
+
+      - name: Perform CodeQL Analysis
+        uses: github/codeql-action/analyze@1b549b9259bda1cb5ddde3b41741a82a2d15a841 # v3.28.13
+        with:
+          category: "/language:${{matrix.language}}"

.github/workflows/scorecard.yaml

@@ -0,0 +1,62 @@
+name: Scorecard supply-chain security
+on:
+  # For Branch-Protection check. Only the default branch is supported. See
+  # https://github.com/ossf/scorecard/blob/main/docs/checks.md#branch-protection
+  branch_protection_rule:
+  # To guarantee Maintained check is occasionally updated. See
+  # https://github.com/ossf/scorecard/blob/main/docs/checks.md#maintained
+  schedule:
+    - cron: '0 6 * * 0'
+  push:
+    branches: [ "main" ]
+
+# Declare default permissions as read only.
+permissions: read-all
+
+jobs:
+  analysis:
+    name: Scorecard analysis
+    runs-on: ubuntu-latest
+    permissions:
+      # Needed to upload the results to code-scanning dashboard.
+      security-events: write
+      # Needed to publish results and get a badge (see publish_results below).
+      id-token: write
+
+    steps:
+      - name: "Checkout code"
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+        with:
+          persist-credentials: false
+
+      - name: "Run analysis"
+        uses: ossf/scorecard-action@f49aabe0b5af0936a0987cfb85d86b75731b0186 # v2.4.1
+        with:
+          results_file: results.sarif
+          results_format: sarif
+          # (Optional) "write" PAT token. Uncomment the `repo_token` line below if:
+          # - you want to enable the Branch-Protection check on a *public* repository
+          # To create the PAT, follow the steps in https://github.com/ossf/scorecard-action?tab=readme-ov-file#authentication-with-fine-grained-pat-optional.
+          # repo_token: ${{ secrets.SCORECARD_TOKEN }}
+
+          # Public repositories:
+          #   - Publish results to OpenSSF REST API for easy access by consumers
+          #   - Allows the repository to include the Scorecard badge.
+          #   - See https://github.com/ossf/scorecard-action#publishing-results.
+          publish_results: true
+
+      # Upload the results as artifacts (optional). Commenting out will disable uploads of run results in SARIF
+      # format to the repository Actions tab.
+      - name: "Upload artifact"
+        uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
+        with:
+          name: SARIF file
+          path: results.sarif
+          retention-days: 5
+
+      # Upload the results to GitHub's code scanning dashboard (optional).
+      # Commenting out will disable upload of results to your repo's Code Scanning dashboard
+      - name: "Upload to code-scanning"
+        uses: github/codeql-action/upload-sarif@1b549b9259bda1cb5ddde3b41741a82a2d15a841 # v3.28.13
+        with:
+          sarif_file: results.sarif

.github/workflows/test.yaml

@@ -1,48 +1,40 @@
-name: test
+name: tests
 on: 
   push:
-    branches:
-      - master
-      - v2
-  pull_request:
-    branches:
-      - master
-      - v2
+
+permissions: {}
 
 jobs:
   build:
-    strategy:
-      matrix:
-        go-version: [1.22.x, 1.23.x]
     name: Linux
     runs-on: ubuntu-latest
+    permissions:
+      contents: read
     steps:
+    - name: Checkout
+      uses: actions/checkout@85e6279cec87321a52edac9c87bce653a07cf6c2 # v4.2.2
     - name: Set up Go
-      uses: actions/setup-go@v2
+      uses: actions/setup-go@0aaccfd150d50ccaeb58ebd88d36e91967a5f35b # v5.4.0
       with:
-        go-version: ${{ matrix.go-version }}
-      id: go
-    - name: Check out code into the Go module directory
-      uses: actions/checkout@v2
+        go-version: stable
     - name: Install libpcsc
       run: sudo apt-get install -y libpcsclite-dev pcscd pcsc-tools
     - name: Test
-      run: "go test -C v2 ./..."
+      run: make test
+
   build-windows:
-    strategy:
-      matrix:
-        go-version: [1.21.x, 1.22.x]
     name: Windows
     runs-on: windows-latest
+    permissions:
+      contents: read
     steps:
+    - name: Checkout
+      uses: actions/checkout@85e6279cec87321a52edac9c87bce653a07cf6c2 # v4.2.2
     - name: Set up Go
-      uses: actions/setup-go@v2
+      uses: actions/setup-go@0aaccfd150d50ccaeb58ebd88d36e91967a5f35b # v5.4.0
       with:
-        go-version: ${{ matrix.go-version }}
-      id: go
-    - name: Check out code into the Go module directory
-      uses: actions/checkout@v2
+        go-version: stable
     - name: Test
-      run: "go build -C v2 ./..."
+      run: make test
       env:
         CGO_ENABLED: 0

Makefile

@@ -0,0 +1,2 @@
+test:
+	go build ./...

README.md

@@ -1,15 +1,15 @@
-This is not an officially supported Google product
-
 # A Go YubiKey PIV implementation
 
-[![Go Reference](https://pkg.go.dev/badge/github.com/go-piv/piv-go/v2/piv.svg)](https://pkg.go.dev/github.com/go-piv/piv-go/v2/piv)
+[![Go Reference](https://pkg.go.dev/badge/github.com/qubesome/piv-go/piv.svg)](https://pkg.go.dev/github.com/qubesome/piv-go/piv)
+[![OpenSSF Scorecard](https://api.scorecard.dev/projects/github.com/qubesome/piv-go/badge)](https://scorecard.dev/viewer/?uri=github.com/qubesome/piv-go)
 
 YubiKeys implement the PIV specification for managing smart card certificates.
 This applet is a simpler alternative to GPG for managing asymmetric keys on a
 YubiKey.
 
-This package is an alternative to Paul Tagliamonte's [go-ykpiv](https://github.com/paultag/go-ykpiv),
-a wrapper for YubiKey's ykpiv.h C library. This package aims to provide:
+This package is a hard fork from [go-piv/piv-go], which was originally an
+alternative to Paul Tagliamonte's [go-ykpiv], a wrapper for YubiKey's ykpiv.h
+C library. This package aims to provide:
 
 * Better error messages
 * Idiomatic Go APIs
@@ -19,7 +19,7 @@ V2 of this package was released in 2024 to support newer kinds of management
 keys, and is now the default branch for new features. The import path is:
 
 ```
-import "github.com/go-piv/piv-go/v2/piv"
+import "github.com/qubesome/piv-go/piv"
 ```
 
 ## Examples
@@ -317,3 +317,4 @@ directly use browser U2F challenges for smart cards.
 
 [go-ykpiv]: https://github.com/paultag/go-ykpiv
 [openssh-u2f]: https://marc.info/?l=openssh-unix-dev&m=157259802529972&w=2
+[go-piv/piv-go]: https://github.com/go-piv/piv-go

go.mod

@@ -0,0 +1,3 @@
+module github.com/qubesome/piv-go
+
+go 1.24