Skip to content

Type hint for php 8.4 #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/AmqpConsumer.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ interface AmqpConsumer extends Consumer
const FLAG_EXCLUSIVE = 4;
const FLAG_NOWAIT = 8;

public function setConsumerTag(string $consumerTag = null): void;
public function setConsumerTag(?string $consumerTag = null): void;

public function getConsumerTag(): ?string;

Expand Down
14 changes: 7 additions & 7 deletions src/AmqpMessage.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,27 +14,27 @@ interface AmqpMessage extends Message
const FLAG_MANDATORY = 1;
const FLAG_IMMEDIATE = 2;

public function setContentType(string $type = null): void;
public function setContentType(?string $type = null): void;

public function getContentType(): ?string;

public function setContentEncoding(string $encoding = null): void;
public function setContentEncoding(?string $encoding = null): void;

public function getContentEncoding(): ?string;

public function setDeliveryMode(int $deliveryMode = null): void;

public function getDeliveryMode(): ?int;

public function setPriority(int $priority = null): void;
public function setPriority(?int $priority = null): void;

public function getPriority(): ?int;

public function setExpiration(int $expiration = null): void;
public function setExpiration(?int $expiration = null): void;

public function getExpiration(): ?int;

public function setDeliveryTag(int $deliveryTag = null): void;
public function setDeliveryTag(?int $deliveryTag = null): void;

/**
* https://www.rabbitmq.com/amqp-0-9-1-reference.html#domain.delivery-tag
Expand All @@ -43,7 +43,7 @@ public function getDeliveryTag(): ?int;

public function getConsumerTag(): ?string;

public function setConsumerTag(string $consumerTag = null): void;
public function setConsumerTag(?string $consumerTag = null): void;

public function clearFlags(): void;

Expand All @@ -55,5 +55,5 @@ public function setFlags(int $flags): void;

public function getRoutingKey(): ?string ;

public function setRoutingKey(string $routingKey = null): void;
public function setRoutingKey(?string $routingKey = null): void;
}
2 changes: 1 addition & 1 deletion src/AmqpQueue.php
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,5 @@ public function getArgument(string $key);

public function getConsumerTag(): ?string;

public function setConsumerTag(string $consumerTag = null): void;
public function setConsumerTag(?string $consumerTag = null): void;
}
24 changes: 12 additions & 12 deletions src/Impl/AmqpMessage.php
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ public function isRedelivered(): bool
return $this->redelivered;
}

public function setCorrelationId(string $correlationId = null): void
public function setCorrelationId(?string $correlationId = null): void
{
$this->setHeader('correlation_id', $correlationId);
}
Expand All @@ -135,7 +135,7 @@ public function getCorrelationId(): ?string
return $this->getHeader('correlation_id');
}

public function setMessageId(string $messageId = null): void
public function setMessageId(?string $messageId = null): void
{
$this->setHeader('message_id', $messageId);
}
Expand All @@ -152,12 +152,12 @@ public function getTimestamp(): ?int
return $value === null ? null : (int) $value;
}

public function setTimestamp(int $timestamp = null): void
public function setTimestamp(?int $timestamp = null): void
{
$this->setHeader('timestamp', $timestamp);
}

public function setReplyTo(string $replyTo = null): void
public function setReplyTo(?string $replyTo = null): void
{
$this->setHeader('reply_to', $replyTo);
}
Expand All @@ -167,7 +167,7 @@ public function getReplyTo(): ?string
return $this->getHeader('reply_to');
}

public function setContentType(string $type = null): void
public function setContentType(?string $type = null): void
{
$this->setHeader('content_type', $type);
}
Expand All @@ -177,7 +177,7 @@ public function getContentType(): ?string
return $this->getHeader('content_type');
}

public function setContentEncoding(string $encoding = null): void
public function setContentEncoding(?string $encoding = null): void
{
$this->setHeader('content_encoding', $encoding);
}
Expand All @@ -192,12 +192,12 @@ public function getPriority(): ?int
return $this->getHeader('priority');
}

public function setPriority(int $priority = null): void
public function setPriority(?int $priority = null): void
{
$this->setHeader('priority', $priority);
}

public function setDeliveryMode(int $deliveryMode = null): void
public function setDeliveryMode(?int $deliveryMode = null): void
{
$this->setHeader('delivery_mode', $deliveryMode);
}
Expand All @@ -207,7 +207,7 @@ public function getDeliveryMode(): ?int
return $this->getHeader('delivery_mode');
}

public function setExpiration(int $expiration = null): void
public function setExpiration(?int $expiration = null): void
{
// expiration is a string
// https://www.rabbitmq.com/amqp-0-9-1-reference.html#domain.shortstr
Expand All @@ -227,7 +227,7 @@ public function getDeliveryTag(): ?int
return $this->deliveryTag;
}

public function setDeliveryTag(int $deliveryTag = null): void
public function setDeliveryTag(?int $deliveryTag = null): void
{
$this->deliveryTag = $deliveryTag;
}
Expand All @@ -237,7 +237,7 @@ public function getConsumerTag(): ?string
return $this->consumerTag;
}

public function setConsumerTag(string $consumerTag = null): void
public function setConsumerTag(?string $consumerTag = null): void
{
$this->consumerTag = $consumerTag;
}
Expand Down Expand Up @@ -267,7 +267,7 @@ public function getRoutingKey(): ?string
return $this->routingKey;
}

public function setRoutingKey(string $routingKey = null): void
public function setRoutingKey(?string $routingKey = null): void
{
$this->routingKey = $routingKey;
}
Expand Down
4 changes: 2 additions & 2 deletions src/Impl/AmqpQueue.php
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public function getConsumerTag(): ?string
return $this->consumerTag;
}

public function setConsumerTag(string $consumerTag = null): void
public function setConsumerTag(?string $consumerTag = null): void
{
$this->consumerTag = $consumerTag;
}
Expand Down Expand Up @@ -85,7 +85,7 @@ public function setArgument(string $key, $value): void
$this->arguments[$key] = $value;
}

public function getArgument(string $key, $default = null)
public function getArgument(?string $key, $default = null)
{
return array_key_exists($key, $this->arguments) ? $this->arguments[$key] : $default;
}
Expand Down
Loading