update quic-go to v0.59.0#116
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #116 +/- ##
=======================================
Coverage 72.90% 72.90%
=======================================
Files 4 4
Lines 406 406
=======================================
Hits 296 296
Misses 70 70
Partials 40 40 ☔ View full report in Codecov by Sentry. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the quic-go dependency from v0.57.1 to v0.59.0, adapting to an API change where ConnectionState().SupportsDatagrams changed from a boolean to a struct with separate fields for local and remote datagram support.
Changes:
- Updated quic-go dependency from v0.57.1 to v0.59.0
- Adapted test code to use
.Remotefield for datagram support checks - Removed transitive dependency golang.org/x/time from go.sum (no longer required)
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go.mod | Updated quic-go version from v0.57.1 to v0.59.0 |
| go.sum | Updated checksums for quic-go v0.59.0 and removed unused golang.org/x/time dependency |
| test_helper_test.go | Updated datagram support checks to use new .Remote field API |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update dependency
github.com/quic-go/quic-goto v0.59.0 and adjust test helper assertions intest_helper_test.goto useSupportsDatagrams.RemoteBumps
github.com/quic-go/quic-goto v0.59.0 in go.mod with corresponding checksum updates in go.sum, and changesnewConnPairassertions in test_helper_test.go to checkSupportsDatagrams.Remotefor both client and server.📍Where to Start
Start with the
newConnPairtest helper in test_helper_test.go to review the assertion changes, then verify the dependency bump in go.mod.Macroscope summarized 94d8816.