Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5586 +/- ##
==========================================
+ Coverage 84.10% 84.17% +0.07%
==========================================
Files 161 161
Lines 16363 16363
==========================================
+ Hits 13762 13773 +11
+ Misses 1967 1959 -8
+ Partials 634 631 -3 ☔ View full report in Codecov by Sentry. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Go lint workflow to improve CI signal by adding vulnerability scanning and standardizing step naming within the existing check job.
Changes:
- Renamed the gcassert step to use consistent capitalization (“Run gcassert”).
- Added a new CI step to run
govulncheckagainst./....
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Run gcassert | ||
| if: success() || failure() # run this step even if the previous one failed | ||
| run: go tool gcassert ./... | ||
| - name: Run govulncheck |
| if: success() || failure() # run this step even if the previous one failed | ||
| run: go tool gcassert ./... | ||
| - name: Run govulncheck | ||
| run: go run golang.org/x/vuln/cmd/govulncheck@latest ./... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
govulncheckstep to the lint CI workflowAdds a new step to the
checkjob in lint.yml that runsgolang.org/x/vuln/cmd/govulncheckagainst all packages. Also capitalizes the existinggcassertstep label for consistency.Macroscope summarized 6dae64e.