feat(Llama GQA): optional shared-KV matmul rewrite for attention. WIP: (env-gated)#905
Draft
feat(Llama GQA): optional shared-KV matmul rewrite for attention. WIP: (env-gated)#905
Conversation
Signed-off-by: vbaddi <vbaddi@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an optional Llama GQA attention rewrite that avoids explicit KV expansion in the normal eager attention path. The optimization is gated by an environment variable and is OFF by default, so baseline behavior is unchanged unless enabled.
How to enable for testing
export QEFF_LLAMA_GQA_SHARED_KV=1