QFJ-1283 Deduplicate checksum calculation - #1309
Open
kangdaeun1022 wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1309 +/- ##
============================================
+ Coverage 70.38% 70.58% +0.20%
- Complexity 2247 2254 +7
============================================
Files 159 159
Lines 9065 9061 -4
Branches 1192 1189 -3
============================================
+ Hits 6380 6396 +16
+ Misses 2220 2197 -23
- Partials 465 468 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
kangdaeun1022
marked this pull request as ready for review
August 25, 2026 17:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MessageUtilsCharSequencepath fromMessage#setChecksumandFieldMap#calculateChecksumStringBuilderfast path, UTF-8 encoded bytes, and repeating-group checksum consistencyOptimization rationale
The shared helper accepts
CharSequence, soMessage#setChecksumoperates directly on its existingStringBuilderwithout creating aStringorbyte[]. String-equivalent charsets continue to use direct character traversal, while non-string-equivalent charsets continue to calculate the checksum from encoded bytes.Testing
./mvnw -pl quickfixj-base -Dtest=FieldMapTest,MessageUtilsTest test -Dmaven.javadoc.skip=true -PskipBundlePlugin(16 tests)./mvnw -pl quickfixj-base test -Dmaven.javadoc.skip=true -PskipBundlePlugin(170 tests)Fixes #1283