Add promise hooks #1033
Merged
Add promise hooks #1033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 21, 2025
|
In order to use this PR in the LLRT project, it needs to be merged into the mainline (and the COMMIT destination referenced in rquickjs needs to be updated). @bnoordhuis Would it be possible for you to merge this PR in its current state? |
|
I've got a better idea: DelSkayn/rquickjs#453 |
Lets embedders track promise chains. Closely modelled after the V8 API of the same name. Fixes: quickjs-ng#1030
Thanks to your excellent implementation, We was able to successfully access quickjs-ng's PromiseHook from LLRT. Please see the following (before and after) comments. There is still a lot of work to be done on the LLRT implementation and things that need to be confirmed, but there don't appear to be any problems with the engine implementation. |
|
@bnoordhuis Could you please merge it when you have time? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets embedders track promise chains. Closely modelled after the V8 API of the same name.
Fixes: #1030