Update 47 #1833
Update 47 #1833
Conversation
WalkthroughThis PR makes extensive updates throughout the repository. Most notably, it bumps the Go version (from 1.23.3 to 1.23.7), replaces Tendermint imports with CometBFT equivalents, and upgrades key dependencies. Numerous GitHub Actions files, Dockerfiles, and core application modules are modified to reflect these changes. In addition, many protocol buffer files are updated (with new go_package options, adjusted import paths, added message types, or deletions) and several third-party chain files for Osmosis and Celestia are refactored. Test modules and simulation helpers are similarly updated for consistency. Changes
Possibly related PRs
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (1.64.8)Error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
third-party-chains/osmosis-types/concentrated-liquidity/math/math.go
Dismissed
Show dismissed
Hide dismissed
third-party-chains/osmosis-types/concentrated-liquidity/math/math.go
Dismissed
Show dismissed
Hide dismissed
third-party-chains/osmosis-types/concentrated-liquidity/math/math.go
Dismissed
Show dismissed
Hide dismissed
third-party-chains/osmosis-types/concentrated-liquidity/math/tick.go
Dismissed
Show dismissed
Hide dismissed
third-party-chains/osmosis-types/concentrated-liquidity/types/constants.go
Dismissed
Show dismissed
Hide dismissed
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 9
🧹 Nitpick comments (21)
third-party-chains/osmosis-types/concentrated-liquidity/math/tick.go (2)
111-139: New helper function is well-structured; consider adding boundary tests.
TickToAdditiveGeometricIndicesnicely separates concerns. It handles tick boundaries and exponent calculations cleanly. It would be beneficial to ensure thorough unit tests, particularly around extreme values (e.g., neartypes.MinCurrentTickV2andtypes.MaxTick).Would you like help in drafting a unit test for these edge cases?
327-347: Address the TODO and confirm feasibility.
Line 340’s “TODO: Validate this case is impossible, and delete it” indicates potential dead code. Consider verifying whether this scenario can ever occur; if it cannot, removing the logic may simplify maintenance.Would you like me to open an issue or generate follow-up code to resolve this?
proto/proto-gen.sh (1)
6-6: Broadened Proto File Search ScopeThe
findcommand now starts at the current directory (./) inside theprotofolder rather than a narrower path. This broader search scope can be useful, but please ensure that it does not inadvertently pick up unwanted or extraneous.protofiles (for example, those in vendor or other non-target directories).third-party-chains/osmosis-types/concentrated-liquidity/math/precompute.go (1)
3-6: Revised Import Paths for Osmosis and Liquidity TypesThe import for
osmomathhas been updated to"github.com/osmosis-labs/osmosis/osmomath", and the concentrated liquidity types are now imported from
"github.com/quicksilver-zone/quicksilver/third-party-chains/osmosis-types/concentrated-liquidity/types"
(with the alias removed). Ensure that the package’s declared name matches the expected usage (i.e. that it is still referenced astypesin the code) and that all functions and constants (likeExponentAtPriceOne) resolve correctly under the new structure.Makefile (2)
126-129: Streamlined Docker Release TargetThe
build-docker-releasetarget was simplified to depend directly onbuild-docker, and it extracts the binary from the Docker image accordingly. Double-check that the binary extraction process works reliably and that the resulting binary (with version tagging) is as expected.
424-449: Updated Protobuf Tooling ConfigurationNew Makefile variables (
protoVer,protoImageName, andprotoImage) have been introduced to configure the Docker-based protobuf processing. The targets for code generation (proto-gen), linting (proto-lint), formatting (proto-format), and breaking checks (proto-breaking-check) now leverage these settings. Ensure that the selected proto builder version (0.15.0) is compatible with your proto files and that these changes integrate seamlessly into your CI/CD pipeline.proto/buf.gen.gogo.yaml (1)
1-8: Review: New buf.gen.gogo.yaml Configuration.
This new configuration file correctly specifies versionv1and defines thegocosmosandgrpc-gatewayplugins. Please add a newline at the end of the file to comply with YAML linting standards.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 8-8: no new line character at the end of file
(new-line-at-end-of-file)
icq-relayer/Dockerfile (1)
19-19: Review Alpine Runtime Version
The runtime stage still usesalpine:3.20. Verify whether this is intentional—using a newer Go image for building while retaining an older Alpine version at runtime may be acceptable for stability or size considerations, but consistency should be confirmed.Dockerfile (1)
18-18: Runtime Image Consistency Check
Although the builder uses the updated Alpine version, the runtime stage still usesalpine:3.20. Confirm if this is an intentional trade-off for stability or image size.test/simulation/sim_test.go (1)
50-52: Review Logger Function Naming
The call tolog.NewTMLoggernow originates from CometBFT's logging library. Consider verifying if a renaming (or aliasing) is needed to better reflect the underlying CometBFT dependency and avoid potential confusion.third-party-chains/osmosis-types/concentrated-liquidity/types/codec.go (1)
18-18: Consider addressing the commented-out code.There's a commented line for message service registration that's currently inactive. This could either be removed if not needed or uncommented if the functionality should be enabled.
- //msgservice.RegisterMsgServiceDesc(registry, &_Msg_serviceDesc) + // Register message service descriptor if needed + // msgservice.RegisterMsgServiceDesc(registry, &_Msg_serviceDesc)proto/buf.yaml (1)
8-9: Finalize IBC and ICS23 dependencies.
Pinning the IBC dependency to commit96808ebb72ec8db1edf71f4bff7e8ee68440237dand referencingbuf.build/cosmos/ics23should be confirmed for long-term stability.To avoid potential regressions, consider upgrading these dependencies to published versions as soon as stable tags become available.
app/upgrades/v1_8.go (1)
18-22: Add tests for theV010800UpgradeHandlersignature.
Defining a dedicated upgrade handler is a good practice, but ensure robust test coverage. For instance, verifying that each sub-step (like settingAllowedClients) behaves correctly under various scenarios will help catch regressions early.proto/osmosis/poolmanager/v1beta1/query.yml (1)
40-41: Consider removing "TEST" suffix in query function.The function name
k.EstimateSinglePoolSwapExactAmountOutTESTcould be a leftover placeholder or debug reference. Verify whether this is intentional or if it should be renamed for clarity.icq-relayer/pkg/types/client.go (1)
553-561: Consider using structured logging instead of print statements
Debug prints can clutter output or inadvertently leak info. Suggest using a logger with a debug level if persistent debugging is desired.app/app.go (1)
415-415: GetTxConfig always generating a new config.
Returning a fresh encoding config on every call might introduce a small overhead. Consider reusing an existing instance or caching the result.func (app *Quicksilver) GetTxConfig() client.TxConfig { - cfg := MakeEncodingConfig() - return cfg.TxConfig + // Potentially reuse a stored encoding config from the app + return appEncodingConfig.TxConfig }test/simulation/helpers.go (1)
74-75: Updated simulation proposal references.Replacing
simState.ContentswithLegacyProposalContentsandProposalMsgsclarifies the discrepancy between legacy and new proposals. Confirm that no calls tosimState.Contentsremain elsewhere.app/keepers/keys.go (1)
53-54: Store keys for new modules.Adding
consensustypes.StoreKeyandcrisistypes.StoreKeyensures these modules can persist state. Confirm that the modules are configured if they are indeed needed.cmd/quicksilverd/root.go (2)
238-249: Fallback chain ID logic.Reading the chain ID from
genesis_fileif no CLI override is provided is sound. Be aware of possible edge cases wheregenesis_filemight be missing or invalid, as this will panic.
292-292: Added chain ID flag.This flag helps consistent usage across CLI commands. Make sure it is properly documented for operators.
proto/osmosis/poolmanager/v1beta1/query.proto (1)
193-202: Deprecation Notice in Swap Request Message
InEstimateSwapExactAmountInRequest, the fieldssenderandpool_idare marked as deprecated. It would be useful to later remove these if all clients have transitioned to the new API.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (61)
go.sumis excluded by!**/*.sumgo.workis excluded by!**/*.workgo.work.sumis excluded by!**/*.sumicq-relayer/go.sumis excluded by!**/*.sumproto/buf.lockis excluded by!**/*.lockthird-party-chains/celestia-types/proto-types/proof.pb.gois excluded by!**/*.pb.gothird-party-chains/osmosis-types/concentrated-liquidity/client/queryproto/query.pb.gois excluded by!**/*.pb.gothird-party-chains/osmosis-types/concentrated-liquidity/client/queryproto/query.pb.gw.gois excluded by!**/*.pb.gw.gothird-party-chains/osmosis-types/concentrated-liquidity/model/pool.pb.gois excluded by!**/*.pb.gothird-party-chains/osmosis-types/concentrated-liquidity/model/position.pb.gois excluded by!**/*.pb.gothird-party-chains/osmosis-types/concentrated-liquidity/model/tick_info.pb.gois excluded by!**/*.pb.gothird-party-chains/osmosis-types/concentrated-liquidity/model/tx.pb.gois excluded by!**/*.pb.gothird-party-chains/osmosis-types/concentrated-liquidity/types/genesis/genesis.pb.gois excluded by!**/*.pb.gothird-party-chains/osmosis-types/concentrated-liquidity/types/incentive_record.pb.gois excluded by!**/*.pb.gothird-party-chains/osmosis-types/concentrated-liquidity/types/params.pb.gois excluded by!**/*.pb.gothird-party-chains/osmosis-types/concentrated-liquidity/types/tx.pb.gois excluded by!**/*.pb.gothird-party-chains/osmosis-types/gamm/pool-models/balancer/balancerPool.pb.gois excluded by!**/*.pb.gothird-party-chains/osmosis-types/gamm/pool-models/balancer/tx.pb.gois excluded by!**/*.pb.gothird-party-chains/osmosis-types/gamm/pool-models/stableswap/stableswap_pool.pb.gois excluded by!**/*.pb.gothird-party-chains/osmosis-types/gamm/pool-models/stableswap/tx.pb.gois excluded by!**/*.pb.gothird-party-chains/osmosis-types/gamm/types/genesis.pb.gois excluded by!**/*.pb.gothird-party-chains/osmosis-types/gamm/types/migration/shared.pb.gois excluded by!**/*.pb.gothird-party-chains/osmosis-types/gamm/types/params.pb.gois excluded by!**/*.pb.gothird-party-chains/osmosis-types/gamm/types/query.pb.gois excluded by!**/*.pb.gothird-party-chains/osmosis-types/gamm/types/query.pb.gw.gois excluded by!**/*.pb.gw.gothird-party-chains/osmosis-types/gamm/types/tx.pb.gois excluded by!**/*.pb.gothird-party-chains/osmosis-types/gamm/v2types/query.pb.gois excluded by!**/*.pb.gothird-party-chains/osmosis-types/gamm/v2types/query.pb.gw.gois excluded by!**/*.pb.gw.gothird-party-chains/osmosis-types/lockup/types/genesis.pb.gois excluded by!**/*.pb.gothird-party-chains/osmosis-types/lockup/types/lock.pb.gois excluded by!**/*.pb.gothird-party-chains/osmosis-types/lockup/types/params.pb.gois excluded by!**/*.pb.gothird-party-chains/osmosis-types/lockup/types/query.pb.gois excluded by!**/*.pb.gothird-party-chains/osmosis-types/lockup/types/query.pb.gw.gois excluded by!**/*.pb.gw.gothird-party-chains/osmosis-types/lockup/types/tx.pb.gois excluded by!**/*.pb.gothird-party-chains/osmosis-types/osmoutils/accum/accum.pb.gois excluded by!**/*.pb.gothird-party-chains/osmosis-types/osmoutils/sumtree/tree.pb.gois excluded by!**/*.pb.gothird-party-chains/osmosis-types/poolmanager/client/queryproto/query.pb.gois excluded by!**/*.pb.gothird-party-chains/osmosis-types/poolmanager/client/queryproto/query.pb.gw.gois excluded by!**/*.pb.gw.gothird-party-chains/osmosis-types/poolmanager/client/queryprotov2/query.pb.gois excluded by!**/*.pb.gothird-party-chains/osmosis-types/poolmanager/client/queryprotov2/query.pb.gw.gois excluded by!**/*.pb.gw.gothird-party-chains/osmosis-types/poolmanager/types/genesis.pb.gois excluded by!**/*.pb.gothird-party-chains/osmosis-types/poolmanager/types/module_route.pb.gois excluded by!**/*.pb.gothird-party-chains/osmosis-types/poolmanager/types/swap_route.pb.gois excluded by!**/*.pb.gothird-party-chains/osmosis-types/poolmanager/types/taker_fee_share.pb.gois excluded by!**/*.pb.gothird-party-chains/osmosis-types/poolmanager/types/tracked_volume.pb.gois excluded by!**/*.pb.gothird-party-chains/osmosis-types/poolmanager/types/tx.pb.gois excluded by!**/*.pb.goutils/proofs/proofs.pb.gois excluded by!**/*.pb.gox/claimsmanager/types/claimsmanager.pb.gois excluded by!**/*.pb.gox/claimsmanager/types/genesis.pb.gois excluded by!**/*.pb.gox/claimsmanager/types/messages.pb.gois excluded by!**/*.pb.gox/claimsmanager/types/query.pb.gois excluded by!**/*.pb.gox/claimsmanager/types/query.pb.gw.gois excluded by!**/*.pb.gw.gox/epochs/types/genesis.pb.gois excluded by!**/*.pb.gox/epochs/types/query.pb.gois excluded by!**/*.pb.gox/epochs/types/query.pb.gw.gois excluded by!**/*.pb.gw.gox/interchainquery/types/genesis.pb.gois excluded by!**/*.pb.gox/interchainquery/types/interchainquery.pb.gois excluded by!**/*.pb.gox/interchainquery/types/messages.pb.gois excluded by!**/*.pb.gox/interchainquery/types/messages.pb.gw.gois excluded by!**/*.pb.gw.gox/interchainquery/types/query.pb.gois excluded by!**/*.pb.gox/interchainquery/types/query.pb.gw.gois excluded by!**/*.pb.gw.go
📒 Files selected for processing (107)
.github/workflows/buildtest.yaml(3 hunks).github/workflows/codeql.yml(1 hunks).github/workflows/devskim.yml(3 hunks).github/workflows/docker.yaml(1 hunks).github/workflows/golangci.yml(1 hunks).github/workflows/icq-relayer-build-test.yml(2 hunks).github/workflows/simulation.yml(1 hunks).golangci.yml(1 hunks)CHANGELOG.md(1 hunks)Dockerfile(1 hunks)Makefile(4 hunks)ROADMAP.md(1 hunks)app/ante.go(1 hunks)app/app.go(13 hunks)app/app_test.go(3 hunks)app/config.go(4 hunks)app/export.go(3 hunks)app/keepers/keepers.go(22 hunks)app/keepers/keys.go(3 hunks)app/metrics.go(1 hunks)app/modules.go(9 hunks)app/test_helpers.go(6 hunks)app/tps_counter.go(1 hunks)app/tps_counter_test.go(1 hunks)app/upgrades.go(2 hunks)app/upgrades/types.go(1 hunks)app/upgrades/upgrades.go(1 hunks)app/upgrades/v1_6.go(0 hunks)app/upgrades/v1_8.go(1 hunks)app/upgrades_test.go(1 hunks)cmd/quicksilverd/forceprune.go(1 hunks)cmd/quicksilverd/root.go(9 hunks)docker-compose.yml(0 hunks)docs/swagger.yml(4 hunks)go.mod(16 hunks)icq-relayer/Dockerfile(1 hunks)icq-relayer/cmd/modules.go(2 hunks)icq-relayer/cmd/run.go(1 hunks)icq-relayer/go.mod(6 hunks)icq-relayer/pkg/runner/run.go(4 hunks)icq-relayer/pkg/types/client.go(3 hunks)icq-relayer/pkg/types/config.go(3 hunks)icq-relayer/pkg/types/rpc.go(2 hunks)proto/buf.gen.gogo.yaml(1 hunks)proto/buf.yaml(1 hunks)proto/cosmos/lsmstaking/v1beta1/query.proto(1 hunks)proto/cosmos/lsmstaking/v1beta1/tx.proto(1 hunks)proto/cosmos/lsmstaking/v1beta1/types.proto(1 hunks)proto/osmosis/concentratedliquidity/params.proto(2 hunks)proto/osmosis/concentratedliquidity/poolmodel/concentrated/v1beta1/tx.proto(2 hunks)proto/osmosis/concentratedliquidity/v1beta1/genesis.proto(1 hunks)proto/osmosis/concentratedliquidity/v1beta1/incentive_record.proto(1 hunks)proto/osmosis/concentratedliquidity/v1beta1/pool.proto(1 hunks)proto/osmosis/concentratedliquidity/v1beta1/position.proto(0 hunks)proto/osmosis/concentratedliquidity/v1beta1/query.proto(4 hunks)proto/osmosis/concentratedliquidity/v1beta1/query.yml(1 hunks)proto/osmosis/concentratedliquidity/v1beta1/tick_info.proto(0 hunks)proto/osmosis/concentratedliquidity/v1beta1/tx.proto(1 hunks)proto/osmosis/gamm/poolmodels/balancer/v1beta1/tx.proto(2 hunks)proto/osmosis/gamm/poolmodels/stableswap/v1beta1/stableswap_pool.proto(4 hunks)proto/osmosis/gamm/poolmodels/stableswap/v1beta1/tx.proto(3 hunks)proto/osmosis/gamm/v1beta1/balancerPool.proto(3 hunks)proto/osmosis/gamm/v1beta1/genesis.proto(1 hunks)proto/osmosis/gamm/v1beta1/params.proto(1 hunks)proto/osmosis/gamm/v1beta1/query.proto(1 hunks)proto/osmosis/gamm/v1beta1/shared.proto(1 hunks)proto/osmosis/gamm/v1beta1/tx.proto(9 hunks)proto/osmosis/gamm/v2/query.proto(1 hunks)proto/osmosis/lockup/genesis.proto(1 hunks)proto/osmosis/lockup/lock.proto(1 hunks)proto/osmosis/lockup/params.proto(1 hunks)proto/osmosis/lockup/query.proto(1 hunks)proto/osmosis/lockup/tx.proto(6 hunks)proto/osmosis/poolmanager/v1beta1/genesis.proto(1 hunks)proto/osmosis/poolmanager/v1beta1/module_route.proto(1 hunks)proto/osmosis/poolmanager/v1beta1/query.proto(1 hunks)proto/osmosis/poolmanager/v1beta1/query.yml(1 hunks)proto/osmosis/poolmanager/v1beta1/swap_route.proto(1 hunks)proto/osmosis/poolmanager/v1beta1/taker_fee_share.proto(1 hunks)proto/osmosis/poolmanager/v1beta1/tracked_volume.proto(1 hunks)proto/osmosis/poolmanager/v1beta1/tx.proto(6 hunks)proto/osmosis/poolmanager/v2/query.proto(1 hunks)proto/osmosis/poolmanager/v2/query.yml(1 hunks)proto/proto-gen.sh(1 hunks)proto/quicksilver/proofs/v1/proof/proofs.proto(1 hunks)test/interchaintest/go.mod(1 hunks)test/simulation/helpers.go(3 hunks)test/simulation/sim_test.go(1 hunks)test/simulation/state.go(2 hunks)third-party-chains/celestia-types/types/row_proof.go(1 hunks)third-party-chains/celestia-types/types/share_proof.go(1 hunks)third-party-chains/osmosis-types/concentrated-liquidity/cl.go(0 hunks)third-party-chains/osmosis-types/concentrated-liquidity/codec.go(0 hunks)third-party-chains/osmosis-types/concentrated-liquidity/events.go(0 hunks)third-party-chains/osmosis-types/concentrated-liquidity/keyspace.md(0 hunks)third-party-chains/osmosis-types/concentrated-liquidity/listeners.go(0 hunks)third-party-chains/osmosis-types/concentrated-liquidity/math/math.go(6 hunks)third-party-chains/osmosis-types/concentrated-liquidity/math/precompute.go(1 hunks)third-party-chains/osmosis-types/concentrated-liquidity/math/tick.go(8 hunks)third-party-chains/osmosis-types/concentrated-liquidity/model/codec.go(2 hunks)third-party-chains/osmosis-types/concentrated-liquidity/model/msgs.go(0 hunks)third-party-chains/osmosis-types/concentrated-liquidity/model/pool.go(5 hunks)third-party-chains/osmosis-types/concentrated-liquidity/msgs.go(0 hunks)third-party-chains/osmosis-types/concentrated-liquidity/params.go(0 hunks)third-party-chains/osmosis-types/concentrated-liquidity/types/cl_pool_extensionI.go(2 hunks)third-party-chains/osmosis-types/concentrated-liquidity/types/codec.go(1 hunks)third-party-chains/osmosis-types/concentrated-liquidity/types/constants.go(2 hunks)
⛔ Files not processed due to max files limit (29)
- third-party-chains/osmosis-types/concentrated-liquidity/types/errors.go
- third-party-chains/osmosis-types/concentrated-liquidity/types/keys.go
- third-party-chains/osmosis-types/gamm/codec.go
- third-party-chains/osmosis-types/gamm/events.go
- third-party-chains/osmosis-types/gamm/hooks.go
- third-party-chains/osmosis-types/gamm/msg_lp.go
- third-party-chains/osmosis-types/gamm/msg_swap.go
- third-party-chains/osmosis-types/gamm/msgs.go
- third-party-chains/osmosis-types/gamm/pool-models/balancer/amm.go
- third-party-chains/osmosis-types/gamm/pool-models/balancer/codec.go
- third-party-chains/osmosis-types/gamm/pool-models/balancer/constants.go
- third-party-chains/osmosis-types/gamm/pool-models/balancer/doc.go
- third-party-chains/osmosis-types/gamm/pool-models/balancer/marshal.go
- third-party-chains/osmosis-types/gamm/pool-models/balancer/msgs.go
- third-party-chains/osmosis-types/gamm/pool-models/balancer/pool.go
- third-party-chains/osmosis-types/gamm/pool-models/balancer/pool_assets.go
- third-party-chains/osmosis-types/gamm/pool-models/balancer/pool_params.go
- third-party-chains/osmosis-types/gamm/pool-models/internal/cfmm_common/lp.go
- third-party-chains/osmosis-types/gamm/pool-models/stableswap/amm.go
- third-party-chains/osmosis-types/gamm/pool-models/stableswap/codec.go
- third-party-chains/osmosis-types/gamm/pool-models/stableswap/msgs.go
- third-party-chains/osmosis-types/gamm/pool-models/stableswap/pool.go
- third-party-chains/osmosis-types/gamm/pool-models/stableswap/pool_params.go
- third-party-chains/osmosis-types/gamm/route.go
- third-party-chains/osmosis-types/gamm/types/codec.go
- third-party-chains/osmosis-types/gamm/types/constants.go
- third-party-chains/osmosis-types/gamm/types/errors.go
- third-party-chains/osmosis-types/gamm/types/key.go
- third-party-chains/osmosis-types/gamm/types/pool.go
💤 Files with no reviewable changes (12)
- proto/osmosis/concentratedliquidity/v1beta1/tick_info.proto
- docker-compose.yml
- third-party-chains/osmosis-types/concentrated-liquidity/keyspace.md
- proto/osmosis/concentratedliquidity/v1beta1/position.proto
- third-party-chains/osmosis-types/concentrated-liquidity/codec.go
- third-party-chains/osmosis-types/concentrated-liquidity/params.go
- third-party-chains/osmosis-types/concentrated-liquidity/cl.go
- third-party-chains/osmosis-types/concentrated-liquidity/listeners.go
- third-party-chains/osmosis-types/concentrated-liquidity/msgs.go
- third-party-chains/osmosis-types/concentrated-liquidity/model/msgs.go
- third-party-chains/osmosis-types/concentrated-liquidity/events.go
- app/upgrades/v1_6.go
🧰 Additional context used
🧠 Learnings (4)
icq-relayer/cmd/run.go (1)
Learnt from: faddat
PR: quicksilver-zone/quicksilver#1067
File: icq-relayer/pkg/runner/run.go:808-808
Timestamp: 2024-11-12T07:06:35.954Z
Learning: The user has clarified that the `tmquery` package has been renamed to `cmtquery` due to Tendermint being renamed to Comet. This is reflected in the import statements and usage within the `icq-relayer/pkg/runner/run.go` file.
icq-relayer/pkg/runner/run.go (1)
Learnt from: faddat
PR: quicksilver-zone/quicksilver#1067
File: icq-relayer/pkg/runner/run.go:808-808
Timestamp: 2024-11-12T07:06:35.954Z
Learning: The user has clarified that the `tmquery` package has been renamed to `cmtquery` due to Tendermint being renamed to Comet. This is reflected in the import statements and usage within the `icq-relayer/pkg/runner/run.go` file.
third-party-chains/osmosis-types/concentrated-liquidity/types/cl_pool_extensionI.go (1)
Learnt from: joe-bowman
PR: quicksilver-zone/quicksilver#1152
File: third-party-chains/osmosis-types/concentrated-liquidity/model/pool.go:27-55
Timestamp: 2024-11-12T07:06:35.953Z
Learning: All files within the `third-party-chains` directory are vendored files from another project, intended to provide types for cross-chain queries. Modifications to these files should be minimal to keep them as close to the original as possible.
third-party-chains/osmosis-types/concentrated-liquidity/model/pool.go (2)
Learnt from: joe-bowman
PR: quicksilver-zone/quicksilver#1152
File: third-party-chains/osmosis-types/concentrated-liquidity/model/pool.go:27-55
Timestamp: 2024-11-12T07:06:35.953Z
Learning: All files within the `third-party-chains` directory are vendored files from another project, intended to provide types for cross-chain queries. Modifications to these files should be minimal to keep them as close to the original as possible.
Learnt from: joe-bowman
PR: quicksilver-zone/quicksilver#1152
File: third-party-chains/osmosis-types/concentrated-liquidity/model/pool.go:123-123
Timestamp: 2025-03-24T14:59:53.979Z
Learning: Files within the `third-party-chains/osmosis-types` directory are vendored from an upstream repository, and TODOs within these files can be ignored safely.
🧬 Code Definitions (6)
app/upgrades/v1_8.go (1)
app/keepers/keepers.go (2)
AppKeepers(82-133)AppKeepers(518-543)
cmd/quicksilverd/root.go (1)
app/app.go (1)
DefaultNodeHome(67-67)
app/config.go (1)
app/app.go (1)
NewQuicksilver(109-239)
app/keepers/keepers.go (3)
x/interchainstaking/keeper/keeper.go (3)
Keeper(45-62)Keeper(138-140)NewKeeper(66-112)x/interchainquery/keeper/keeper.go (2)
Keeper(21-26)NewKeeper(29-40)x/interchainstaking/types/expected_keepers.go (3)
AuthzKeeper(66-69)BankKeeper(36-47)AccountKeeper(31-33)
app/upgrades.go (2)
app/upgrades/types.go (1)
V010800UpgradeName(27-27)x/supply/types/keys.go (1)
ModuleName(4-4)
app/upgrades/upgrades.go (2)
app/upgrades/types.go (1)
V010800UpgradeName(27-27)app/upgrades/v1_8.go (1)
V010800UpgradeHandler(18-44)
🪛 YAMLlint (1.35.1)
proto/buf.gen.gogo.yaml
[error] 8-8: no new line character at the end of file
(new-line-at-end-of-file)
🪛 Buf (1.47.2)
proto/osmosis/gamm/v1beta1/genesis.proto
4-4: import "cosmos/base/v1beta1/coin.proto": file does not exist
(COMPILE)
proto/quicksilver/proofs/v1/proof/proofs.proto
4-4: import "celestia/core/v1/proof/proof.proto": file does not exist
(COMPILE)
proto/cosmos/lsmstaking/v1beta1/query.proto
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/osmosis/gamm/v1beta1/params.proto
4-4: import "cosmos/base/v1beta1/coin.proto": file does not exist
(COMPILE)
proto/osmosis/gamm/poolmodels/stableswap/v1beta1/stableswap_pool.proto
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/cosmos/lsmstaking/v1beta1/types.proto
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/osmosis/gamm/v2/query.proto
4-4: import "cosmos/base/query/v1beta1/pagination.proto": file does not exist
(COMPILE)
proto/osmosis/gamm/v1beta1/balancerPool.proto
8-8: import "amino/amino.proto": file does not exist
(COMPILE)
proto/osmosis/concentratedliquidity/poolmodel/concentrated/v1beta1/tx.proto
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/osmosis/gamm/v1beta1/shared.proto
4-4: import "cosmos/base/v1beta1/coin.proto": file does not exist
(COMPILE)
proto/osmosis/poolmanager/v2/query.proto
4-4: import "cosmos_proto/cosmos.proto": file does not exist
(COMPILE)
proto/osmosis/gamm/poolmodels/balancer/v1beta1/tx.proto
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/osmosis/poolmanager/v1beta1/taker_fee_share.proto
4-4: import "cosmos/base/v1beta1/coin.proto": file does not exist
(COMPILE)
proto/osmosis/concentratedliquidity/v1beta1/genesis.proto
4-4: import "cosmos_proto/cosmos.proto": file does not exist
(COMPILE)
proto/osmosis/gamm/poolmodels/stableswap/v1beta1/tx.proto
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/cosmos/lsmstaking/v1beta1/tx.proto
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/osmosis/gamm/v1beta1/query.proto
4-4: import "cosmos/base/query/v1beta1/pagination.proto": file does not exist
(COMPILE)
proto/osmosis/poolmanager/v1beta1/tx.proto
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/osmosis/lockup/tx.proto
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/osmosis/concentratedliquidity/v1beta1/tx.proto
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/osmosis/gamm/v1beta1/tx.proto
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/osmosis/poolmanager/v1beta1/query.proto
4-4: import "cosmos/base/query/v1beta1/pagination.proto": file does not exist
(COMPILE)
🔇 Additional comments (316)
third-party-chains/celestia-types/types/share_proof.go (1)
10-10: Update Import Path for Crypto Package.The import statement now correctly uses the CometBFT package (
"github.com/cometbft/cometbft/proto/tendermint/crypto") instead of the Tendermint one. This change is aligned with the PR objectives and ensures that cryptographic types (e.g.,Proof) are sourced from the updated dependency. Please verify that downstream references (such as in theToProto()method) continue to work as expected with CometBFT’s API.third-party-chains/osmosis-types/concentrated-liquidity/math/tick.go (8)
4-4: Imports look consistent with new library usage.
Usingfmtfor error formatting aligns with the changes below that usefmt.Errorf. The updated imports fromosmomathand the new path undergithub.com/quicksilver-zone/also appear appropriate for the upgraded dependencies.Also applies to: 6-7
47-51: Confirm no thread-safety or concurrency concerns when using mutable sqrt.
Switching fromosmomath.MonotonicSqrtto the mutable variantMonotonicSqrtMutcould offer performance improvements. However, please verify that this mutable call is not used in any concurrent context to avoid potential side effects.
79-82: Good modular design with TickToAdditiveGeometricIndices.
CallingTickToAdditiveGeometricIndicesneatly isolates the logic for additive ticks and exponent deltas, improving readability and maintainability.
84-89: Enhanced inline documentation.
These explanatory comments clarifying the price formula are a welcome addition, significantly improving readability for others.
93-93: Check for potential overflow in unscaledPrice arithmetic.
Although initializingunscaledPriceto 1,000,000 and multiplying by 10 for negative ticks is likely safe under typical usage, consider validating edge cases where large or very negativetickIndexmight exceed numeric bounds.Also applies to: 98-98, 100-101
204-204: Consistent error handling with fmt.Errorf.
These changes improve clarity when reporting invalid price values and help unify the code’s error-handling style.Also applies to: 206-206
279-283: Expanded explanation of candidate bucket indexing.
These comments clearly detail the logic for assigning asqrtPriceto the correct bucket range, aiding future maintainers.
299-317: Return flow relies on new custom error and boundary checks—ensure coverage.
The added branching withtypes.ErrCalculateSqrtPriceToTickand boundary checks forsqrtPriceTplus2seem correct. Recommend verifying edge scenarios (e.g., precisely matching max sqrt price) in tests for robust coverage.Also applies to: 320-322
proto/quicksilver/proofs/v1/proof/proofs.proto (1)
4-4: Verify Updated Import Path for Celestia Proof
The import statement has been updated to"celestia/core/v1/proof/proof.proto", but static analysis indicates that this file may not exist. Please verify that the new path is correct and that the corresponding file is present in the repository.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "celestia/core/v1/proof/proof.proto": file does not exist
(COMPILE)
third-party-chains/celestia-types/types/row_proof.go (1)
7-8: Update Import Paths to CometBFT Libraries
The previously used Tendermint imports have been replaced with the corresponding CometBFT imports. This change is in line with the broader dependency update. Please ensure that all method calls and dependent modules using these libraries remain compatible with the CometBFT versions.proto/osmosis/gamm/v1beta1/shared.proto (2)
4-4: Verify Import Path for Cosmos Coin Proto
The import"cosmos/base/v1beta1/coin.proto"is flagged by static analysis as possibly non-existent. Please double-check that this path is correct or update it if the location of the coin definitions has changed.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "cosmos/base/v1beta1/coin.proto": file does not exist
(COMPILE)
1-13: New Protocol Buffer Messages for Migration Records
The newMigrationRecordsandBalancerToConcentratedPoolLinkmessages are clearly defined to represent the links between balancer and concentrated liquidity pools. Ensure that consumers of these messages are updated accordingly for backward compatibility, if needed.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "cosmos/base/v1beta1/coin.proto": file does not exist
(COMPILE)
proto/osmosis/lockup/lock.proto (1)
9-9: Package Path Restructuring for Lockup Types
Thego_packageoption has been updated to"github.com/quicksilver-zone/quicksilver/third-party-chains/osmosis-types/lockup/types", which improves the organization of the lockup module types. Please verify that all components and import statements referencing this package have been updated to reflect the new structure.proto/osmosis/concentratedliquidity/v1beta1/pool.proto (1)
40-44: Update Custom Type forcurrent_sqrt_price
Thecurrent_sqrt_pricefield now uses the custom type from"github.com/osmosis-labs/osmosis/osmomath.BigDec"rather than the previous internal package path. Confirm that this change is consistent with how big decimal values are handled elsewhere in the codebase and that any associated calculations remain correct.app/ante.go (1)
11-12: Updated IBC Module ImportsThe import paths for the IBC modules have been updated from v6 to v7. Please verify that the APIs (for example, the usage of
NewRedundantRelayDecorator) are fully compatible with the v7 release. If there are any breaking changes in the decorator’s behavior or parameters, additional adjustments may be required.proto/osmosis/concentratedliquidity/v1beta1/incentive_record.proto (1)
9-9: Updated Go Package Option in Proto FileThe
go_packageoption now includes the/typessuffix, aligning with the updated package structure. Please ensure that any generated Go files correctly import this new package path and update client code accordingly.Makefile (2)
10-10: Dependency Upgrade – CometBFT VersionThe
TMVERSIONvariable is now sourced from the CometBFT module instead of Tendermint. Confirm that the output version string meets expectations and that all downstream usages (e.g. in linker flags) correctly reflect the new dependency version.
68-73: Linker Flag Update for CometBFTThe linker flag now embeds the CometBFT core semantic version (
TMCoreSemVer) using the updatedTMVERSION. Please verify that this version information is accurate and compatible with your runtime requirements.proto/osmosis/lockup/tx.proto (9)
6-6: Approval: Updated Import for Cosmos Message Types.
The addition ofimport "cosmos/msg/v1/msg.proto";aligns with the new metadata requirements for message signing and is correctly included.
11-11: Review: Updated go_package Option.
Thego_packagepath has been updated to"github.com/quicksilver-zone/quicksilver/third-party-chains/osmosis-types/lockup/types", which reflects the restructured package layout. Ensure downstream references align with this change.
29-30: Enhancement: Metadata Added to MsgLockTokens.
The options(amino.name) = "osmosis/lockup/lock-tokens"and(cosmos.msg.v1.signer) = "owner"enhance clarity in message identification and signing forMsgLockTokens. Confirm that all dependent modules and clients are updated accordingly.
49-50: Enhancement: Metadata for MsgBeginUnlockingAll.
The newly added options for amino name and signer inMsgBeginUnlockingAllimprove consistency and ensure proper message handling.
59-60: Enhancement: Consistent Metadata on MsgBeginUnlocking.
The inclusion of(amino.name)and(cosmos.msg.v1.signer)options inMsgBeginUnlockingaligns it with other message types. Please verify that any clients consuming this message support these updated metadata fields.
78-80: Enhancement: Added Metadata to MsgExtendLockup.
Defining(amino.name)as"osmosis/lockup/extend-lockup"and the signer option ensures thatMsgExtendLockupis processed consistently. Confirm that the verification logic downstream uses these indicators appropriately.
103-105: Enhancement: Metadata for MsgForceUnlock.
The options(amino.name)and(cosmos.msg.v1.signer)have been correctly added toMsgForceUnlock, ensuring consistency with other message definitions.
120-122: Enhancement: Updated Metadata in MsgSetRewardReceiverAddress.
By assigning(amino.name)as"osmosis/lockup/set-reward-receiver-address"and setting the signer to"owner", the message now carries improved metadata. Documentation and client integrations should be updated accordingly.
131-141: Note: Introduction of Deprecated Messages.
The new messagesMsgUnlockPeriodLockandMsgUnlockTokensare marked as deprecated for indexing purposes. Ensure that any consumers of these messages are aware of their deprecated status and that new implementations avoid using them..github/workflows/simulation.yml (1)
22-22: Update: Go Version Upgrade in Simulation Workflow.
The Go version has been updated to"1.23.7", which standardizes the environment across workflows. This change is consistent with other CI configurations in the project..github/workflows/docker.yaml (1)
29-29: Update: Consistent Go Version in Docker Workflow.
The Docker workflow now uses Go version"1.23.7", aligning it with project-wide updates and ensuring build consistency..github/workflows/buildtest.yaml (3)
38-38: Update: Go Version Set in Build Job.
The build job’s configuration now specifies"1.23.7"for the Go environment, ensuring compatibility with the project's recent changes.
69-69: Update: Go Version Set in Test Job.
The test job has been updated to use Go version"1.23.7", which maintains consistency across the CI pipeline.
120-120: Update: Go Version Set in Simulation Job.
The simulation job now utilizes Go version"1.23.7", further standardizing the CI environment.icq-relayer/Dockerfile (1)
1-1: Base Image Version Update Verified
The build stage now usesgolang:1.23.7-alpine3.21, which meets the objective of upgrading the Go version consistently across the project.Dockerfile (1)
1-1: Updated Builder Stage Base Image
The builder stage now reflects the updated imagegolang:1.23.7-alpine3.21, ensuring that the Go version upgrade is applied uniformly..github/workflows/golangci.yml (2)
26-26: Updated Go Version Parameter
Thego-versionparameter is updated to"1.23.7", which aligns with the repository-wide upgrade.
29-31: Upgraded golangci-lint Action Version
The action is now set togolangci/golangci-lint-action@v7with the linter version updated tov2.0.2. This upgrade should bring improvements in linting performance and new features..github/workflows/codeql.yml (1)
27-27: CodeQL Go Version Updated
Thego-versionin the CodeQL setup has been updated to1.23.7, ensuring that the CodeQL analysis runs with the same Go version as the rest of the project..github/workflows/devskim.yml (3)
10-10: Constrained Branch Trigger for Push Events
The push event is now limited to the"main"branch, which helps focus the DevSkim scans on the stable branch.
19-19: Updated Runner OS Version
Switching the runner toubuntu-22.04may offer better performance and updated tooling. This change aligns with current best practices.
30-31: Introduced Ignore Globs for DevSkim Scanner
The addition ofignore-globs: "third-party-chains/*"is a useful refinement that excludes third-party code from the scans, reducing false positives.app/tps_counter.go (1)
15-15: Import update from Tendermint to CometBFTThis change aligns with the PR objective to update dependencies, specifically replacing Tendermint imports with CometBFT equivalents. Since the log interface remains compatible, this change is straightforward and correct.
.github/workflows/icq-relayer-build-test.yml (2)
14-14: Go version update in test jobThe Go version is updated from 1.23.3 to 1.23.7, which aligns with the PR objective to upgrade dependencies. This ensures tests run with the latest Go version.
28-28: Go version update in build jobThe Go version is updated from 1.23.3 to 1.23.7, which aligns with the PR objective to upgrade dependencies. This ensures builds run with the latest Go version.
app/tps_counter_test.go (1)
16-16: Import update from Tendermint to CometBFTThis change aligns with the PR objective to update dependencies, specifically replacing Tendermint imports with CometBFT equivalents. It's consistent with the same update made in the main implementation file (app/tps_counter.go).
icq-relayer/cmd/run.go (1)
18-18: Import update from Tendermint to CometBFTThis change aligns with the PR objective to update dependencies, specifically replacing Tendermint imports with CometBFT equivalents. As indicated in the retrieved learnings, this is a known transition where Tendermint has been renamed to Comet.
icq-relayer/pkg/types/config.go (4)
22-22: Well-structured addition of the MaxTxsPerQuery fieldAdding this configuration parameter allows for better control over query batching, which can help optimize performance and resource usage.
64-70: Good implementation of default valuesSetting sensible defaults for both MaxTxsPerQuery and MaxMsgsPerTx ensures the application works correctly even with incomplete configuration, following the robustness principle.
78-78: Consistent initialization in NewConfigProperly initializing MaxTxsPerQuery in the NewConfig function ensures consistency with the defaults set in the InitializeConfigFromToml function.
106-106: Addition of Oraichain to supported chainsThe addition of Oraichain follows the same pattern as other chain entries, maintaining consistency in the codebase.
proto/osmosis/gamm/v1beta1/genesis.proto (2)
13-20: GenesisState definition follows Cosmos SDK patternsThe GenesisState message is properly structured with fields for pools, pool numbering, parameters, and migration records. The comment about renaming
next_pool_numbertonext_pool_idin a future version provides good context for future maintenance.
1-12:❓ Verification inconclusive
Verify import path for cosmos base proto
The static analysis tool indicates that the import path "cosmos/base/v1beta1/coin.proto" may not exist, which could cause compilation issues.
🏁 Script executed:
#!/bin/bash # Check if the imported proto file exists in the project fd -e proto 'coin.proto' | grep -E 'cosmos/base/v1beta1/coin\.proto' # Check for actual imports in the Go code to see if they're working rg -t go "\"cosmos/base/v1beta1\"" --no-ignoreLength of output: 115
VERIFY EXTERNAL DEPENDENCY FOR "cosmos/base/v1beta1/coin.proto"
Our automated searches did not find any occurrence of the file under this exact path in the repository. Since the Cosmos SDK’s protos can be provided as external dependencies rather than being stored locally, please manually verify that the build environment or dependency manager is properly including the
coin.protofile from the Cosmos SDK. If the file is meant to be local or the dependency is misconfigured, update the import path accordingly.
- Ensure that dependency management (e.g., module imports, vendoring, or external repository configuration) correctly provides
cosmos/base/v1beta1/coin.proto.- If the file is not expected to be provided externally, confirm its intended location and adjust the import path in
proto/osmosis/gamm/v1beta1/genesis.protoif necessary.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "cosmos/base/v1beta1/coin.proto": file does not exist
(COMPILE)
proto/osmosis/lockup/params.proto (1)
6-6:❓ Verification inconclusive
Package path updated for consistency
The go_package path has been updated to include "/types" at the end, which aligns with the PR objective of bumping Osmosis types to version 28.0.4.
Make sure that any Go code importing this package has also been updated to use the new path.
🏁 Script executed:
#!/bin/bash # Check for imports of the old package path that might need updating rg -t go "github.com/quicksilver-zone/quicksilver/third-party-chains/osmosis-types/lockup[^/]"Length of output: 96
I'm going to run an updated verification script using a refined regex to check if any Go code still imports the old package path (i.e. without the final “/types”). This should help us get more confidence that no outdated references exist.
🏁 Script executed:
#!/bin/bash # Refined search for old package imports without the trailing "/types" rg -t go "github\.com/quicksilver-zone/quicksilver/third-party-chains/osmosis-types/lockup(?!\/types)"Length of output: 479
Attention: Confirm Updated Imports for Osmosis Package
The go_package update in
proto/osmosis/lockup/params.protocorrectly appends/types, which is in line with bumping Osmosis types to version 28.0.4. I attempted to locate any Go code still referencing the old package path (without/types) using automated regex searches. Although our initial search returned no output—and subsequent refined searches using PCRE2 (viarg --pcre2) are recommended—the results weren't conclusive due to regex engine limitations.
- Action Required: Please manually verify that no Go files import the old package path
github.com/quicksilver-zone/quicksilver/third-party-chains/osmosis-types/lockup(i.e. without the trailing/types).proto/osmosis/lockup/genesis.proto (1)
8-8: Package path consistently updatedThis change is part of the broader updates to Osmosis types referenced in the PR objectives, ensuring all protobuf definitions use the consistent package structure with "/types" suffix.
proto/osmosis/poolmanager/v2/query.yml (1)
1-10: New query configuration properly structured for Osmosis PoolManager v2.This new YAML file correctly defines the query configuration for the Osmosis PoolManager v2 module, properly referencing the third-party-chains path and setting up the SpotPrice query functionality with its corresponding keeper function and CLI command.
app/metrics.go (1)
17-18: Import correctly updated from Tendermint to CometBFT.The ABCI types import has been properly updated from Tendermint to CometBFT, aligning with the PR objective to bump CometBFT to version 0.37.15. The API appears compatible, requiring no additional code changes.
proto/osmosis/poolmanager/v1beta1/genesis.proto (1)
12-12: Go package path correctly updated to include types subdirectory.The go_package option has been properly updated to place generated code in a dedicated types subdirectory, following standard Go module organization practices. This change is consistent with the Osmosis types update to v28.0.4.
proto/osmosis/poolmanager/v1beta1/tracked_volume.proto (1)
7-7: Go package path correctly updated for consistency across module.The go_package option has been properly updated to use the types subdirectory, maintaining consistency with other proto files in the poolmanager module. This change aligns with the broader Osmosis types update to v28.0.4.
proto/osmosis/gamm/v1beta1/params.proto (2)
4-4: Verify Import Path for coin.proto
Static analysis reported that the file"cosmos/base/v1beta1/coin.proto"might be missing. Please verify that this import path is correct for your Cosmos SDK version and project structure, and update it if necessary.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "cosmos/base/v1beta1/coin.proto": file does not exist
(COMPILE)
10-17: New Params Message Definition Looks Good
TheParamsmessage is clearly defined with the necessary serialization options. Ensure that thepool_creation_feefield, with its cast and YAML annotations, aligns with the expectations in the incentives module.test/simulation/sim_test.go (1)
17-19: Updated Logging and Database Dependencies
The migration from Tendermint to CometBFT libraries for both logging and database management is correctly reflected in the updated import statements. Please ensure all downstream uses of these libraries are consistent with this change.proto/osmosis/gamm/poolmodels/stableswap/v1beta1/stableswap_pool.proto (3)
4-4: Verify Amino Proto Import Path
Static analysis suggests that"amino/amino.proto"may not exist. Please confirm that this is the intended path for the Amino definitions or adjust the import to point to the correct location.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
19-20: New Amino Serialization Option for PoolParams
The addition of(amino.name) = "osmosis/gamm/StableswapPoolParams"in thePoolParamsmessage is appropriate for Amino serialization. Ensure this naming convention remains consistent with similar modules in your codebase.
41-42: New Amino Serialization Option for Pool Message
Adding the option(amino.name) = "osmosis/gamm/StableswapPool"enhances clarity for Amino-based serialization. Confirm that this setting aligns with the overall serialization strategy used across related proto files.proto/osmosis/poolmanager/v1beta1/swap_route.proto (1)
6-6: Updated Go Package Option
The change in thego_packageoption to"github.com/quicksilver-zone/quicksilver/third-party-chains/osmosis-types/poolmanager/types"reflects the new directory structure. Please verify that the repository’s file organization matches this updated path.proto/osmosis/lockup/query.proto (1)
12-12: Updated Go Package Declaration
The modification of thego_packageoption to append/typesfor the lockup module is clear and consistent with other updates. Ensure that this new path is reflected throughout the build and dependency configurations.proto/osmosis/poolmanager/v1beta1/module_route.proto (1)
6-6:❓ Verification inconclusive
Package path update: Ensure all imports are updated for consistency.
The Go package path has been updated to include a
/typessuffix. This change is part of the broader effort to reorganize and standardize the package structure.Please run this script to verify that all imports of this package have been updated to the new path:
🏁 Script executed:
#!/bin/bash # Check for any imports still using the old path rg -i "github.com/quicksilver-zone/quicksilver/third-party-chains/osmosis-types/poolmanager[^/]" --type goLength of output: 108
Manual Verification Needed: Confirm All Import Paths Consistently Use the New Package Suffix
The automated search did not return any outdated references, but the absence of output means we should manually verify that no Go files still import the old package path without the
/typessuffix. Please double-check the following:
- proto/osmosis/poolmanager/v1beta1/module_route.proto (line 6): The updated Go package path now includes a
/typessuffix.- All Go files: Review them to ensure any import of
github.com/quicksilver-zone/quicksilver/third-party-chains/osmosis-types/poolmanageris updated to
github.com/quicksilver-zone/quicksilver/third-party-chains/osmosis-types/poolmanager/types.Once you’ve confirmed that all references are updated, this part of the reorganization can be considered complete.
third-party-chains/osmosis-types/concentrated-liquidity/types/codec.go (2)
8-10: Appropriate Amino codec registration for the interface.The function correctly registers the
ConcentratedPoolExtensioninterface with the legacy Amino codec.
12-17: Correct interface registration for protobuf.The interface is properly registered with the interface registry using a fully qualified protobuf type name.
proto/cosmos/lsmstaking/v1beta1/query.proto (3)
10-10: Go package path defined appropriately.The Go package is correctly set to point to the project's LSM types module.
13-22: Well-structured response message for validators query.The
QueryValidatorsResponsemessage is properly defined with:
- A repeated field for validators with appropriate nullability settings
- Pagination support following Cosmos SDK conventions
This message structure aligns with typical Cosmos SDK query response patterns.
4-4:❓ Verification inconclusive
Missing import file detected.
The static analysis tool indicates that
"amino/amino.proto"referenced in line 4 does not exist. This may cause compilation errors.Verify that this import is available in your protobuf path. If not, you need to either:
- Add the missing proto file to your repository
- Update your build configuration to include the correct path
- Remove this import if it's not actually needed
🏁 Script executed:
#!/bin/bash # Check if amino/amino.proto exists in proto directories fd -e proto -g "*amino.proto" proto/Length of output: 38
Below is a follow-up verification step:
Additional Verification for Missing "amino/amino.proto" File
It looks like the first command did not return any results, so it’s unclear whether the file truly doesn’t exist or if it’s located somewhere unexpected. To be sure, please run the following script manually:
#!/bin/bash # Re-verify the presence of amino.proto under the proto directory find proto/ -type f -name 'amino.proto'If this command still produces no output, then the file is likely missing. In that case, please either add the missing proto file, update your build configuration to include the correct path, or remove the unused import.
🧰 Tools
🪛 Buf (1.47.2)
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
cmd/quicksilverd/forceprune.go (1)
18-19:❓ Verification inconclusive
Import path updated from Tendermint to CometBFT.
The import statements have been correctly updated from Tendermint to CometBFT, aligning with the PR objective to bump CometBFT to version 0.37.15.
Let's verify that all Tendermint imports have been updated to CometBFT throughout the codebase:
🏁 Script executed:
#!/bin/bash # Check for any remaining Tendermint imports rg -i "github.com/tendermint/tendermint" --type goLength of output: 50
Please re-verify the Tendermint imports across the repository
The changes in cmd/quicksilverd/forceprune.go (lines 18–19) correctly update the import paths from Tendermint to CometBFT. A preliminary search for
"github.com/tendermint/tendermint"returned no output, suggesting that these imports may have been fully replaced. However, since the absence of output might be due to low-quality inference, an additional verification step is warranted to search for any remaining Tendermint references.
- Actionable next step: Run an extended search for
"github.com/tendermint"in all Go files to confirm that no deprecated import patterns remain.Once you verify that this command returns no results, the update to CometBFT can be confidently approved.
🏁 Script executed:
#!/bin/bash # Extended search for any tendermint references in Go files rg -i "github.com/tendermint" --type goLength of output: 161
Import Path Update Verification – Manual Confirmation Needed
The changes in
cmd/quicksilverd/forceprune.go(lines 18–19) successfully update the import paths from Tendermint to CometBFT, aligning with the PR objective to bump CometBFT to version 0.37.15. An extended search for"github.com/tendermint"in Go files did not yield any output, suggesting that there are no remaining Tendermint references. However, since no output was produced—and given the possibility of low-confidence inference—it is important to manually verify that there are indeed no stray Tendermint imports remaining elsewhere in the repository.
- Updated File:
cmd/quicksilverd/forceprune.go(lines 18–19) now uses"github.com/cometbft/cometbft/config"andtmstore "github.com/cometbft/cometbft/store".- Search Outcome: The extended
rg -i "github.com/tendermint"search returned no results.- Next Step: Please manually confirm that the codebase does not contain any lingering Tendermint references before final approval.
proto/osmosis/gamm/v1beta1/balancerPool.proto (2)
76-77: Good addition of amino codec annotations.The addition of amino name options for the PoolParams and Pool messages aligns with the update of dependencies in this PR. These options provide explicit naming conventions for Amino serialization used in Cosmos SDK ecosystem.
Also applies to: 120-121
8-8:❓ Verification inconclusive
Import for amino/amino.proto might not be resolved correctly.
Static analysis indicates that "amino/amino.proto" file cannot be found. This dependency is needed for the amino options added to the PoolParams and Pool messages. Ensure that the proto file is correctly included in your project's dependencies or proto path configuration.
🏁 Script executed:
#!/bin/bash # Check if the amino/amino.proto file exists in the repository fd -t f "amino.proto" | grep -i aminoLength of output: 37
Action Required: Verify the 'amino/amino.proto' Dependency Configuration
It appears that the automated file search did not locate any instance of "amino.proto" in the repository. Please manually verify the dependency by confirming one of the following:
- External Dependency: If the amino proto is meant to come from an external package, ensure your build’s proto path configuration is set up to include that external source.
- Project Inclusion: If the proto should be part of the repository, add the missing "amino/amino.proto" file to your project's dependencies.
Double-check your project's dependency management and proto import paths to resolve the static analysis warning.
🧰 Tools
🪛 Buf (1.47.2)
8-8: import "amino/amino.proto": file does not exist
(COMPILE)
proto/osmosis/gamm/v2/query.proto (3)
14-20: Well-documented deprecated RPC endpoint.Good practice to clearly mark the SpotPrice RPC as deprecated and guide users to the alternative in x/poolmanager. This ensures a clean migration path as dependencies are updated.
22-40: Appropriate request/response message definitions with deprecation notices.The QuerySpotPriceRequest and QuerySpotPriceResponse messages are properly defined with clear deprecation notices. Particularly good that fields like withSwapFee are also marked as deprecated with explanation in comments.
4-11:❓ Verification inconclusive
Check unused imports and resolvability.
Several proto imports are included but some don't appear to be used in this file. Additionally, static analysis indicates that "cosmos/base/query/v1beta1/pagination.proto" might not be found. Consider removing unused imports and ensuring all dependencies are correctly configured in your proto path.
🏁 Script executed:
#!/bin/bash # Check if the pagination proto file exists in the repository fd -t f "pagination.proto" | grep -i cosmos/base/queryLength of output: 54
Verify proto import paths and assess usage.
- Confirm that the import
"cosmos/base/query/v1beta1/pagination.proto"is available—either present in the repository or supplied via an external dependency—as our initial search did not locate it.- Review the rest of the imports to determine if any are unused in
proto/osmosis/gamm/v2/query.protoand remove them if appropriate for clarity and maintainability.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "cosmos/base/query/v1beta1/pagination.proto": file does not exist
(COMPILE)
ROADMAP.md (2)
10-11: Successfully completed SDK 47 upgrade.The roadmap correctly reflects the completion of the "Upgrade to SDK 47" task, which aligns with the objectives of this PR. The next milestone for SDK 50 upgrade is still on the roadmap.
17-22: Updated feature roadmap with new priorities.The roadmap has been refreshed with new prioritized features:
- EventManager
- ClaimsManager refactor
- Changes to epoch handling (daily epochs and decoupling unbonding)
- Governance by Proxy and TSS
These updates likely reflect the architectural changes enabled by the SDK 47 upgrade.
app/app_test.go (2)
17-22: Successful migration from Tendermint to CometBFT imports.The import statements have been properly updated from Tendermint to CometBFT packages, which aligns with the dependency updates mentioned in the PR objectives. This is a necessary change as the Cosmos SDK has moved from Tendermint to CometBFT.
93-93:✅ Verification successful
Updated function signature for ExportAppStateAndValidators.
The function now takes an additional parameter (empty string slice). This change is consistent with updates to the ExportAppStateAndValidators method in the SDK 47 version.
🏁 Script executed:
#!/bin/bash # Check if there are other calls to ExportAppStateAndValidators in the codebase that might need updating rg "ExportAppStateAndValidators\(" --type goLength of output: 423
ExportAppStateAndValidators Signature Update Verified
- In app/app_test.go (line 93) the call now correctly uses explicit empty string slices (
[]string{}) to match the updated SDK 47 signature.- A review of the codebase shows that other calls (e.g., in test/simulation/helpers.go and cmd/quicksilverd/root.go) are still passing nil or variable-based slices. If nil values are intended to be equivalent to empty slices in this context, no further changes are needed—but you might want to double-check these for consistency.
proto/buf.yaml (1)
4-4:✅ Verification successful
Confirm Cosmos SDK version.
Upgrading the Cosmos SDK dependency tov0.47can introduce breaking changes.Kindly confirm that all references to the removed commit-based dependency have been replaced and validated with this new version. You can run a repository-wide search to ensure consistency:
🏁 Script executed:
#!/bin/bash # Description: Search for any references to old cosmos-sdk commits or versions. rg "cosmos-sdk" -A 5Length of output: 107010
Cosmos SDK Dependency Update Verified
The repository-wide search confirms that all references to the old commit-based dependency have been replaced and that the new dependency version (v0.47) is used consistently. All import paths for Cosmos SDK now follow the module-based convention (e.g., "github.com/cosmos/cosmos-sdk/…") with no lingering commit hash references.
app/upgrades/v1_8.go (1)
23-43: Validate upgrade steps and error handling.
The sequence of:
- Migrating Tendermint consensus parameters,
- Updating
AllowedClientswithLocalhost,- Pruning expired consensus states,
…appears aligned with standard Cosmos SDK upgrade patterns. Using
panicon errors is typical for final upgrade failures.proto/osmosis/concentratedliquidity/poolmodel/concentrated/v1beta1/tx.proto (2)
5-5: Confirm Cosmos msg import.
Importing"cosmos/msg/v1/msg.proto"aligns with the latest message handling approach in the Cosmos SDK. No immediate concerns detected.
16-17: New message metadata options.
The addedamino.nameandcosmos.msg.v1.signerproperly encode the message name and signer field. This will enhance clarity and consistency.docs/swagger.yml (4)
929-932: Documentation updated to clarify protocol buffer type server limitations.This addition provides accurate information about the current state of type server implementations for protocol buffers, noting that as of May 2023, there are no widely used implementations or plans to create one.
977-980: Enhanced documentation with additional unpacking method for Java.This example demonstrates an alternative way to unpack protocol buffer messages in Java using the
getDefaultInstance()method, which improves the completeness of the API documentation.
1246-1249: Documentation updated to clarify protocol buffer type server limitations.This is a duplicate of the earlier note about type server implementations, providing consistent information across similar sections of the documentation.
1294-1297: Enhanced documentation with additional unpacking method for Java.This is a duplicate of the earlier Java example for unpacking messages, maintaining consistency throughout the documentation.
icq-relayer/cmd/modules.go (2)
19-20: Updated IBC-Go dependency from v6 to v7.The import paths have been updated to use version 7 of the IBC-Go modules, aligning with the PR objective to bump ibc-go to version 7.9.2. This is part of the broader dependency updates throughout the codebase.
34-34:❓ Verification inconclusive
Simplified governance module initialization with empty proposal handlers.
The governance module initialization has been modified to use an empty slice of proposal handlers instead of the previous implementation that included specific handlers. This simplification may affect the available governance proposal types in the application.
🏁 Script executed:
#!/bin/bash # Check if there are any other places in the codebase where governance proposal handlers are defined # This helps verify if the handlers were moved elsewhere or intentionally removed echo "Searching for governance proposal handlers in the codebase..." rg -A 2 -B 2 "NewAppModuleBasic.*ProposalHandler" --type go echo "Searching for places where proposal handlers might be registered elsewhere..." rg -A 2 -B 2 "RegisterProposalType" --type goLength of output: 1541
Attention: Verify Governance Proposal Type Registration
The initialization of the governance module in
icq-relayer/cmd/modules.gonow uses an empty slice of proposal handlers:gov.NewAppModuleBasic([]govclient.ProposalHandler{}),Our recent search confirms:
- There are no additional proposal handler registrations in this module.
- Relevant proposal types (e.g.,
ProposalTypeAddProtocolData,ProposalTypeRegisterZone,ProposalTypeUpdateZone) continue to be registered in other parts of the codebase (x/participationrewards/types/codec.goandx/interchainstaking/types/codec.go).Next Steps:
- Intention Check: Confirm that the empty slice is an intentional simplification. If proposal handlers were meant to be centralized here, consider integrating the missing handlers.
- Review TODOs: Note the TODO comments in
icq-relayer/cmd/modules.gosuggesting that specific proposal types (including osmosis and others) might be added later.Please verify that this design aligns with your overall governance proposal registration strategy.
proto/osmosis/poolmanager/v1beta1/taker_fee_share.proto (2)
1-8: Structure looks good with appropriate package and imports.The file structure follows standard Protocol Buffers conventions with proper syntax, package naming, and imports.
🧰 Tools
🪛 Buf (1.47.2)
4-4: import "cosmos/base/v1beta1/coin.proto": file does not exist
(COMPILE)
9-62: Well-documented message definitions with proper annotations.The three message types (
TakerFeeShareAgreement,TakerFeeSkimAccumulator, andAlloyContractTakerFeeShareState) are clearly documented with comprehensive comments explaining their purpose and functionality. The field annotations using gogoproto are appropriate for integrating with the Cosmos SDK ecosystem.proto/cosmos/lsmstaking/v1beta1/types.proto (2)
1-16: Appropriate package and imports for LSM functionality.The file correctly establishes the cosmos.lsmstaking.v1beta1 package with necessary imports for the Validator message.
🧰 Tools
🪛 Buf (1.47.2)
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
17-86: Well-structured Validator message with clear deprecation notice.The Validator message contains all necessary fields for representing validator data in the liquid staking module context. I particularly appreciate the clear documentation around the deprecated
min_self_delegationfield (line 60-66), which explains it has been replaced by the validator bond in the LSM architecture.The field types and annotations are appropriate for Cosmos SDK integration.
proto/osmosis/poolmanager/v2/query.proto (3)
1-11: Appropriate setup for poolmanager v2 query service.The file correctly establishes the osmosis.poolmanager.v2 package with necessary imports and proper go_package option.
🧰 Tools
🪛 Buf (1.47.2)
4-4: import "cosmos_proto/cosmos.proto": file does not exist
(COMPILE)
12-21: Clear documentation for SpotPriceV2 method.The Query service with the SpotPriceV2 method is well-documented, explaining the 36 decimal place precision of the returned spot price. The HTTP annotation is properly configured for RESTful access.
23-40: Request and response messages properly defined.The SpotPriceRequest and SpotPriceResponse messages are appropriately structured with proper field annotations. The response correctly uses a custom type for BigDec with non-nullable configuration.
icq-relayer/pkg/types/rpc.go (4)
3-13: Successfully migrated from Tendermint to CometBFT imports.The import statements have been correctly updated to use CometBFT packages instead of Tendermint packages, aligning with the PR objectives to bump CometBFT to version 0.37.15.
15-15: Updated comment to reference CometBFT.The comment has been appropriately updated to reference CometBFT while maintaining the explanation about the copy-pasted implementation.
412-423: Well-implemented Header method.The new Header method follows the same pattern as other methods in the file, properly handling the optional height parameter and returning the appropriate result type.
425-435: Well-implemented HeaderByHash method.The new HeaderByHash method is properly implemented, following the consistent pattern of the codebase. It correctly handles the hash parameter and returns the appropriate result type.
test/simulation/state.go (2)
24-25: Adoption of CometBFT libraries
The import references have changed from Tendermint to CometBFT. This aligns with the overall library upgrade.
155-162: Commented out parameter generation
The code that randomly generates parameters for simulation is now commented out. Verify whether this is intentional or if it should be re-enabled for accurate simulation coverage.proto/osmosis/concentratedliquidity/v1beta1/query.yml (1)
1-82: New concentrated liquidity query definitions
All configurations look correctly structured. Please confirm that you have corresponding tests or validations to ensure each defined query works as intended.app/config.go (5)
17-17: Switch to CometBFT DB
This change replaces the Tendermint DB import with CometBFT DB. Please confirm compatibility and test coverage for the new DB backend.
32-32: Updated Chain ID
The ChainID now uses "quicksilver-1" instead of "quicktest-1." Ensure that all references and configuration scripts are updated accordingly.
46-46: Use of validator interface
Switching tonetwork.ValidatorIfosters greater flexibility and extensibility.
48-48: Use of GetCtx().Logger
Replacingval.Ctx.Loggerwithval.GetCtx().Loggerpromotes consistent, interface-based context usage.
62-62: Explicit ChainID setup
Callingbaseapp.SetChainID("quicksilver-1")clarifies the configured network identifier within the BaseApp.app/upgrades_test.go (1)
20-21: IBC-Go v7 upgrade
Imports have been updated to v7. Confirm that all lingering references to v6 are removed or updated and that the new module version is fully compatible.third-party-chains/osmosis-types/concentrated-liquidity/types/constants.go (3)
1-1: Package name change aligns with repository structureThe package name has been changed from
concentrated_liquiditytotypes, which is consistent with the directory structure and improves organization.
6-6: Import path updated to point to upstream Osmosis repositoryThe import path has been updated to use the original Osmosis repository instead of the Quicksilver fork, which aligns with the PR's objective to update Osmosis types to version 28.0.4.
36-36: TODO comment remains unaddressedThis TODO references an issue in the Osmosis repository that should be tracked.
Is https://github.com/osmosis-labs/osmosis/issues/5726 still open?.golangci.yml (6)
1-1: Upgrading to golangci-lint v2The configuration version has been updated to "2", which is appropriate for the golangci-lint v2.0.2 mentioned in the PR summary.
5-5: Linter configuration approach changedChanged from
disable-all: truetodefault: none, which is the recommended approach in golangci-lint v2. This maintains the same behavior of only enabling explicitly listed linters.
16-22: Linter selection updatedAdded
reviveandusetestingwhile removinggciandgofumptfrom the linters list. The latter two have been moved to the formatters section, which is the correct location in golangci-lint v2.
23-87: Comprehensive configuration for revive linterThe detailed configuration for the
revivelinter is well-structured, selectively disabling certain rules that aren't applicable to this codebase while keeping most of the important ones enabled.
88-107: Improved exclusion organizationThe exclusions section has been reorganized to use the new structure supported by golangci-lint v2, with presets for common exclusion patterns and specific rules for particular linters.
110-133: Formatters section added for code formatting tools
gciandgofumpthave been moved from linters to formatters, which is the correct approach in golangci-lint v2. The section includes appropriate configuration for import grouping with Cosmos SDK, CometBFT, and other project-specific imports.proto/osmosis/gamm/poolmodels/balancer/v1beta1/tx.proto (2)
9-9: Import path updated for balancerPool.protoThe import path for balancerPool.proto has been updated to use the correct path within the Osmosis repository structure.
19-21: Added Amino and Cosmos message optionsThese options improve compatibility with the Cosmos SDK by:
- Specifying the Amino encoding name for the message
- Identifying which field is the transaction signer
This is consistent with the Cosmos SDK v0.47 standards and part of the dependency upgrade.
proto/osmosis/concentratedliquidity/v1beta1/genesis.proto (6)
15-27: Well-defined FullTick message structureThe FullTick message is properly defined with appropriate field types and gogoproto annotations for YAML serialization.
29-49: Comprehensive PoolData message structureThe PoolData message properly encapsulates all necessary data for pool serialization in genesis state:
- Uses Any type for polymorphic pool implementation
- Includes ticks, accumulators, and incentive records
- Has appropriate annotations for YAML serialization and null handling
51-56: Well-structured PositionData messageThe PositionData message properly associates positions with their corresponding lock IDs and accumulator records.
58-73: Complete GenesisState definition with migration thresholdsThe GenesisState message includes all necessary fields for module initialization:
- Module parameters
- Pool and position data
- ID counters for positions and incentive records
- Migration thresholds for compatibility with updated versions
These thresholds are important for supporting safe migrations when upgrading the chain.
75-84: AccumObject message with clear documentationThe AccumObject message is well-documented, explaining why KVStore is excluded from genesis handling. This provides context for future developers and makes the design decisions clear.
1-14:❌ Incorrect review comment
New proto file with appropriate package and imports
This new file defines the genesis state for the concentrated liquidity module, with imports for required dependencies. However, the static analysis indicates that "cosmos_proto/cosmos.proto" may be missing.
🏁 Script executed:
#!/bin/bash # Check if the cosmos_proto/cosmos.proto file exists in the repository echo "Searching for cosmos.proto file..." fd -t f "cosmos.proto" --exec echo "Found cosmos proto at: {}" # Check if any proto files import cosmos_proto/cosmos.proto successfully echo "Checking other imports of cosmos_proto/cosmos.proto..." rg -l "import \"cosmos_proto/cosmos.proto\"" --type protoLength of output: 348
🏁 Script executed:
#!/bin/bash echo "Searching for 'cosmos.proto' file using fd without file type restrictions..." fd -t f cosmos.proto || echo "No cosmos.proto files found." echo "Searching for any occurrences of 'import \"cosmos_proto/cosmos.proto\"' in the repository without file type restrictions..." rg -l 'import "cosmos_proto/cosmos.proto"'Length of output: 2073
Attention: Cosmos Proto Import Is an External Dependency
After verifying the repository, we found that although no file named
cosmos.protoexists in the repository (as confirmed by thefdsearch), multiple proto files (e.g., inproto/osmosis/poolmanager/v1beta1/genesis.proto,proto/quicksilver/supply/v1/messages.proto, etc.) use the lineimport "cosmos_proto/cosmos.proto". This indicates that the dependency is expected to be provided externally (for example via the proto include paths) rather than residing in the repository.
- The absence of a local
cosmos_proto/cosmos.protofile is consistent with how external dependencies are managed.- The usage in this genesis file aligns with similar references across the codebase.
No changes are required for the genesis file.
Likely an incorrect or invalid review comment.
🧰 Tools
🪛 Buf (1.47.2)
4-4: import "cosmos_proto/cosmos.proto": file does not exist
(COMPILE)
proto/osmosis/concentratedliquidity/params.proto (2)
31-41:❓ Verification inconclusive
Confirm deprecated field usage.
The field
authorized_quote_denomsis now marked as deprecated. Verify if it's still referenced elsewhere and consider removing or replacing its usage in a future major release to avoid accumulating technical debt.Here's a script to search for references in the codebase:
🏁 Script executed:
#!/bin/bash rg "authorized_quote_denoms" -A 3 -B 3Length of output: 7582
Deprecation Confirmed for Field
authorized_quote_denoms
- Verified that
authorized_quote_denomsis still present across the codebase—in both the concentrated liquidity module (inproto/osmosis/concentratedliquidity/params.protoand its generated counterparts) and the poolmanager modules.- In
proto/osmosis/concentratedliquidity/params.proto, the field is clearly marked as deprecated.- Its continued appearance in generated files (e.g., in third-party chains and in
proto/osmosis/poolmanager/v1beta1/genesis.proto) suggests it’s maintained for backward compatibility.- Recommend reviewing client usage and dependencies to plan removal or replacement in a future major release, thereby avoiding long-term technical debt.
7-7:✅ Verification successful
Verify updated go_package references.
Make sure the updated package path reflects across the codebase and that no legacy references to the old package path remain.
Run the following script to locate any leftover references:
🏁 Script executed:
#!/bin/bash rg "third-party-chains/osmosis-types/concentrated-liquidity" -A 3 -B 3Length of output: 17862
Package Reference Update Verified
The updated go_package value in
proto/osmosis/concentratedliquidity/params.protonow correctly reflects the new package path:"github.com/quicksilver-zone/quicksilver/third-party-chains/osmosis-types/concentrated-liquidity/types"A repository-wide search confirms that all references using the
"third-party-chains/osmosis-types/concentrated-liquidity"pattern are consistent with the intended split between subpackages (e.g.,/typesvs./model). No legacy package paths were detected.
- File Updated:
proto/osmosis/concentratedliquidity/params.proto- Other References: Files in
x/participationrewards/keeper,x/claimsmanager/types, and various proto files appropriately reference either/typesor/modelbased on their roles.Everything appears aligned with the updated package structure.
app/test_helpers.go (4)
78-78: Updated chain ID in Setup.You’ve changed the chain ID to
"quicksilver-1"here. Ensure this is the intended default for chain initialization.
93-95: Double-check consensus parameter omission.Removing or commenting out the default consensus parameters can affect tests. Confirm that the application’s consensus behavior aligns with your intended test scenarios.
192-192: Validate new SendEnabled configuration.
[]banktypes.SendEnabled{}has been introduced for the genesis state. Verify that this correctly sets up send-related parameters or if you need additional entries here.
22-29:✅ Verification successful
Migrating from Tendermint to CometBFT.
All references to Tendermint have been replaced with CometBFT. This looks correct, but confirm that all linked imports and functionality are supported in the new library without introducing regression.
🏁 Script executed:
#!/bin/bash # Verify that no references to the old Tendermint imports remain rg "tendermint" -A 3 -B 3Length of output: 63175
Action Required: Confirm Migration Consistency in Test Helpers
The migration in
app/test_helpers.goappears to be correctly implemented. All imports in this file have been updated to use thecometbftlibrary (e.g.,github.com/cometbft/cometbft/abci/types,github.com/cometbft/cometbft/crypto/secp256k1, etc.), including the proto types imported astmprotofrom within thecometbftpackage. There are no lingering direct Tendermint references in this file.A quick grep across the repository did highlight some uses of legacy Tendermint references in other parts of the codebase (such as within IBC light client modules or in test files). However, those appear either to be maintained by external dependencies (e.g., ibc-go’s
07-tendermintclient) or are expected legacy references that are independent of the migration performed in this file.Please ensure that these external dependencies have been carefully validated for compatibility with the new CometBFT library, even though the changes in
app/test_helpers.gothemselves do not introduce regressions.third-party-chains/osmosis-types/concentrated-liquidity/model/codec.go (2)
7-8: Import paths updated to match new types organization structure.The import paths have been updated to include the
/typessuffix, which aligns with the dependency updates mentioned in the PR objectives. This change supports the bump to Osmosis types version 28.0.4.
28-28: Service descriptor registration correctly commented out.The commented out line indicates the service descriptor registration is handled elsewhere, which is consistent with overall code reorganization happening in this update.
third-party-chains/osmosis-types/concentrated-liquidity/model/pool.go (6)
7-14: Import paths updated to match dependency versions.The import paths have been correctly updated to match the dependency versions mentioned in the PR objectives. Particularly noteworthy is the direct import from the
osmosis-labs/osmosis/osmomathpackage instead of the vendored path.
58-65: Address decoding simplification.The address decoding has been simplified by using
sdk.AccAddressFromBech32directly instead of a utility function. This change maintains functionality while reducing code complexity.
67-74: Address decoding simplification for incentives address.Similar to the previous change, this simplifies the address decoding for the incentives address.
76-82: Address decoding simplification for spread rewards address.Consistent with the previous address handling changes, this simplifies the decoding process.
111-129: Optimized spot price calculation.The spot price calculation has been optimized by storing the squared price value once and reusing it, instead of recalculating it in each return statement. This improves efficiency and readability.
248-270: Simplified liquidity calculation.The calculation of actual amounts has been simplified by directly passing the
liquidityDeltaparameter to the calculation functions instead of converting it first. This maintains functionality while making the code more direct and efficient.third-party-chains/osmosis-types/concentrated-liquidity/types/cl_pool_extensionI.go (3)
1-1: Package name updated to match directory structure.The package has been renamed from
concentrated_liquiditytotypes, which aligns with the directory structure and follows standard Go conventions for package organization.
6-10: Updated import paths for dependency compatibility.The import paths have been updated to use direct dependencies where appropriate (osmomath from osmosis-labs) and to include
/typesin the poolmanager import, maintaining consistency with the updated dependency structure.
25-25: Return type change for GetLiquidity method.The return type has been changed from
osmomath.Dectosdkmath.LegacyDec. This change is part of the dependency updates mentioned in the PR objectives and ensures compatibility with the updated libraries.proto/osmosis/gamm/poolmodels/stableswap/v1beta1/tx.proto (3)
17-21: Added Amino name and signer options to MsgCreateStableswapPool.These options enhance the serialization and authentication capabilities of the message by:
- Defining a canonical Amino name for serialization
- Specifying the field that should be used as the transaction signer
These changes align with Cosmos SDK best practices for message definitions.
45-49: Added Amino name and signer options to MsgStableSwapAdjustScalingFactors.Similar to the previous message, these options enhance serialization and authentication capabilities, maintaining consistency across message definitions.
4-6:❓ Verification inconclusive
Added amino and cosmos message imports for enhanced serialization.
These imports enable Amino serialization and proper message signing, which are important for transaction handling in Cosmos-SDK based chains.
🏁 Script executed:
#!/bin/bash # Check if the amino.proto file exists within the repository or vendored dependencies fd -t f "amino.proto" -I -pLength of output: 27
Attention: The import statements for Amino and Cosmos messages were added to support enhanced serialization for transaction handling. However, our initial search for the
"amino.proto"file did not return any results. Please manually verify that the file exists either in the repository or is provided via vendored/external dependencies before proceeding.
- Confirm that the
"amino/amino.proto"file is available in your vendored dependencies or external packages.- Verify that the intended functionality for Amino serialization is supported by the resolved dependency.
🧰 Tools
🪛 Buf (1.47.2)
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
icq-relayer/pkg/types/client.go (4)
21-26: Imports updated for CometBFT and ibc-go v7
These import path changes align with the project's move from Tendermint to CometBFT and ibc-go from v6 to v7. No concerns here.Also applies to: 30-30, 36-39, 49-49
550-550: Switched broadcast mode to async
Changing toBroadcastMode_BROADCAST_MODE_ASYNCallows faster sends but may need additional checks to confirm transaction finality.Ensure this shift in broadcasting behavior is compatible with downstream logic that expects synchronous confirmation.
566-566: Correct approach to check final transaction code
CheckingtxRes.TxResponse.Codeensures we evaluate the final result rather than the initial broadcast response. Looks good.
571-571: Returning final transaction hash from the retrieved transaction
This change ensures consistency with the newly fetchedtxResobject.icq-relayer/pkg/runner/run.go (3)
21-25: Updated imports for CometBFT and ibc-go v7
These adjustments match the overall dependency upgrade to CometBFT and ibc-go v7.Also applies to: 27-28, 31-32
418-420: Updating request limit and pagination programmatically
Dynamically settingrequest.Limitandrequest.Pagination.Limitfromcfg.MaxTxsPerQueryensures consistent pagination.
437-466: Custom decoding and filtering only MsgSend transactions
Filtering out messages that are notMsgSendensures the final response is tailored to what’s needed. The approach looks sound.app/keepers/keepers.go (20)
4-6: Imports for packet-forward-middleware v7 and consensus keeper
These version bumps and additional imports align with the updated frameworks.Also applies to: 20-20
44-45: CometBFT logging and OS utilities
Switching to CometBFT's log and OS packages reflects the new platform. No issues found.
47-56: Upgrading IBC apps from v6 to v7
All references updated to v7 IBCA modules. This is consistent with the PR objectives.
83-83: Added AppCodec field to AppKeepers
IncorporatingAppCodecprovides a clean way to store the codec at the keeper level.
99-99: Switch from value to pointer in Gov and Crisis keepers, added Consensus/Upgrade
Using pointers for these keepers is a standard approach to ensure shared state references, and adding new keepers is aligned with the app’s architecture.Also applies to: 104-106
147-147: Logger added to NewAppKeepers
Passing a logger ensures streaming services can emit logs. SettingAppCodecis also well placed here.Also applies to: 150-150
159-161: Loading streaming services with logger
Integrating the logger toLoadStreamingServiceshelps with structured logs.
207-207: Params keeper initialization
No issues. Ensures parameter subspace is properly configured.
211-211: Establishing scoped IBC keeper
Scopes the capability to IBC modules. This is standard for multi-tenant capability usage.
218-218: Defining govAuthority
Creating a module address for gov references is a clean approach.
223-229: Injections of govAuthority across keepers
PassinggovAuthoritythroughout crisis, bank, staking, slashing, packet-forward, and ICS keepers centralizes governance control.Also applies to: 242-242, 250-250, 253-253, 258-258, 284-284, 287-287, 321-321, 417-417, 434-434
349-352: PacketForwardModule initialization
Binding the keeper and subspace is consistent with the pattern used by other modules.
378-378: Setting QueryRouter on ICAHost
Enabling GRPC queries on the ICA host keeper can expand query functionality for interchain accounts.
381-385: Creating and attaching ConsensusKeeper
This sets the base app’s parameter store to the consensus keeper. Implementation looks straightforward.Also applies to: 386-388
452-452: IBC module for interchainstaking
Wrapping the ICS keeper with an IBC module is standard IBC integration.
472-472: Adding route for ICA host
Registering the ICA host submodule route ensures proper packet handling.
492-492: Registering IBC client proposal handlers
Proposals to upgrade or create IBC clients route properly viaibcexported.RouterKey.
506-506: govAuthority passed to GovKeeper
Ensures governance authority is recognized for transaction fees or special permissions.
509-509: SetLegacyRouter on GovKeeper
This finalizes linking the legacy proposal router to GovKeeper.
527-527: Added subspaces in ParamsKeeper
Each relevant module subspace is registered, matching the newly added or upgraded modules.Also applies to: 533-535
app/app.go (11)
11-13: Adoption of additional cosmos SDK imports.
These added imports (cast,autocli/v1, andreflection/v1) are consistent with the updated SDK functionalities. No concerns regarding correctness or usage.
17-17: New import for node gRPC service.
Thenodeserviceimport appears valid and is used to register gRPC routes. No issues.
21-22: Introduced runtime-related imports.
These imports (runtime,runtime/services) enable auto CLI query and reflection. Usage looks correct.
37-44: Migration from Tendermint to CometBFT and IBC-Go v7.
Replacing old Tendermint references withcometbftequivalents, plus the addition of IBC-Go v7 imports, is aligned with the PR’s dependency bumps. No issues found.
79-79: Implementing the new runtime.AppI interface.
Declaring_ runtime.AppI = (*Quicksilver)(nil)ensures Quicksilver meets the updated interface requirements. No concerns.
139-139: Explicitly setting TxEncoder.
CallingbApp.SetTxEncoder(encodingConfig.TxConfig.TxEncoder())is a good practice to ensure compatibility with the updated TxConfig. No issues.
162-162: Passing logger to keepers.
Providing theloggerparameter toNewAppKeeperscan improve observability within keepers. Good addition.
176-176: Registering invariants for crisis checks.
app.mm.RegisterInvariants(app.CrisisKeeper)helps enforce invariants at startup or on-demand. This is essential for detecting potential issues early.
189-194: AutoCLI and reflection services registration.
Registering the AutoCLI query server and reflection service enables dynamic introspection of module interfaces. The panic on reflection error is acceptable during startup; just ensure reflection creation is highly unlikely to fail at runtime.
285-285: Exposed ModuleAccountAddrs method.
This function enumerates module account addresses. The public interface suggests external usage; nothing problematic stands out.
296-296: Exposed BlockedAddrs method.
Provides addresses that should be blocked from receiving external tokens. The logic is straightforward. No issues found.app/upgrades.go (2)
7-7: Added crisis module import.
Bringing incrsistypesaligns with the new store addition for the crisis module. Implementation looks correct.
53-56: New v1.8.0 upgrade case.
Addingcrsistypes.ModuleNameensures the crisis store is recognized on store upgrades. Matches the PR’s focus on dependency updates.app/export.go (6)
11-11: Switched to CometBFT proto import.
Migrating totmprotofrom CometBFT is in line with the updated dependencies. No concerns.
34-34: Module-based genesis export.
ExportGenesisForModulessupports partial module exports. Good approach for fine-grained control.
40-40: Simplified validator retrieval.
Switched tostaking.WriteValidators(ctx, app.StakingKeeper)removes pointer manipulation, which is clearer.
49-49: Retrieving consensus params through app method.
app.GetConsensusParams(ctx)is consistent with the refactored approach for retrieving chain parameters. No issues.
57-57: Simplified jail address check.
Combining this into a single boolean assignment clarifies the logic for applying allowed addresses. No concerns.
17-19:✅ Verification successful
ExportAppStateAndValidators signature update.
The addition ofmodulesToExport []stringoffers more selective exports. Verify that all external calls provide the correct modules slice.
🏁 Script executed:
#!/bin/bash # Search for references to ExportAppStateAndValidators to ensure the new parameter is handled properly rg -A 3 'ExportAppStateAndValidators\('Length of output: 938
Verified: External Calls Properly Updated
The newmodulesToExport []stringparameter is consistently handled in all references—all callers (in simulation, production, and tests) are now correctly passing a modules slice (withnilor an explicit empty slice as appropriate).test/simulation/helpers.go (3)
16-17: Use of CometBFT imports appears consistent.These imports correctly replace the previous Tendermint references. Ensure all usage throughout the file aligns with the new packages and that no references to the old Tendermint imports remain.
26-26: No functional impact from thenolint:gocriticcomment.This function signature remains the same, so there are no operational changes here. The linter directive is acceptable if it prevents spurious warnings.
88-88: Additional argument inExportAppStateAndValidators.The extra
nilparameter aligns with changes elsewhere, presumably for module-specific exports or new functionality. Ensure that any downstream usage is updated accordingly.app/keepers/keys.go (4)
4-4: Upgraded Packet Forward Middleware import.Switching to
v7/packetforward/typesis consistent with the rest of the IBC-Go v7 changes. No issues noted.
12-13: Added new Cosmos SDK modules.Imports for
consensustypesandcrisistypesindicate usage of those features in the updated SDK. Ensure these are registered and initialized properly if used by the application.
23-27: IBC-Go v7 imports for interchain accounts and transfers.Changing from v6 references to v7 references is appropriate. Validate that all references to the previous version have been removed for consistency.
57-57: Replacingibchost.StoreKeywithibcexported.StoreKey.This change is a standard approach in the IBC-Go v7 upgrade. No issues noted.
app/upgrades/upgrades.go (1)
19-20: New upgrade handler forV010800.Adding the
V010800UpgradeHandlerto the upgrade list is coherent with the new version. Confirm that the migration logic is fully tested before production release.cmd/quicksilverd/root.go (7)
31-37: Switched from Tendermint to CometBFT imports.These updated imports reflect the CometBFT migration. The references in the rest of the file seem aligned. No immediate concerns.
66-66: Broadcast mode now tied to CLI flag.Using
flags.FlagBroadcastModeinstead of a hardcoded mode allows customization at runtime. This is a flexible improvement.
102-102: Addedgenutiltypes.DefaultMessageValidatorparameter.This enables stricter or more standardized validation for genesis transactions. Check if this validator imposes any new constraints on custom messages.
251-251: Creating snapshot directory.The snapshot directory is appended under
homeDir/data/snapshots. Double-check permission handling and edge cases if the directory is missing or not writable.
275-275: Setting the chain ID in BaseApp.Using
baseapp.SetChainID(chainID)is mandatory for ledger logic, so this is correct. Ensure the chain ID is well-formed to avoid runtime errors.
303-303: ExpandedappExportto specify modules to export.Allowing custom modules to export state is a useful improvement. Confirm any newly supported modules have adequate logic for their exports.
337-337: Export with new modules parameter.Passing
modulesToExportinExportAppStateAndValidatorsmatches the function’s updated signature. Check integration tests for any regression in export functionality.proto/osmosis/poolmanager/v1beta1/tx.proto (12)
10-10: Updated go_package path to reflect new third-party chain structureThe go_package path has been updated to point to the quicksilver third-party-chains directory, which aligns with the dependency upgrades mentioned in the PR objectives.
18-19: New RPC methods added to the Msg serviceTwo new RPC methods have been added to the service:
SetTakerFeeShareAgreementForDenomSetRegisteredAlloyedPoolThese additions extend the functionality of the pool manager to support fee sharing agreements and alloy pools.
24-25: Added amino.name and cosmos.msg.v1.signer options to MsgSwapExactAmountInThese options improve integration with Cosmos SDK by standardizing naming and signing conventions. The amino.name is used for backwards compatibility with amino encoding, while cosmos.msg.v1.signer specifies which field contains the address that needs to sign the message.
50-51: Added amino.name and cosmos.msg.v1.signer options to MsgSplitRouteSwapExactAmountInSimilar to the previous options added to MsgSwapExactAmountIn, these standardize naming and signing conventions for the MsgSplitRouteSwapExactAmountIn message.
73-74: Added amino.name and cosmos.msg.v1.signer options to MsgSwapExactAmountOutThese options provide consistent naming and signing conventions for MsgSwapExactAmountOut, matching the pattern used in other message types.
99-100: Added amino.name and cosmos.msg.v1.signer options to MsgSplitRouteSwapExactAmountOutThese options establish consistent naming and signing conventions for MsgSplitRouteSwapExactAmountOut, following the same pattern as other message types.
122-123: Added amino.name and cosmos.msg.v1.signer options to MsgSetDenomPairTakerFeeThese options provide consistent naming and signing conventions for MsgSetDenomPairTakerFee, aligning with the patterns established for other message types.
136-163: Added new message type MsgSetTakerFeeShareAgreementForDenomThis new message type enables setting fee sharing agreements for specific denominations in trading routes. It includes:
- Properly documented fields explaining the purpose of each parameter
- Required options for amino encoding and message signing
- A well-documented implementation for managing taker fee sharing agreements
The implementation aligns with Cosmos SDK conventions and extends the poolmanager functionality.
165-178: Added new message type MsgSetRegisteredAlloyedPoolThis new message type provides functionality to register an alloyed pool by its ID. The message:
- Uses proper Cosmos SDK conventions for options and documentation
- Has clear field definitions with good documentation
- Includes a documented purpose for when pools should be registered
This addition enhances the pool manager's capabilities for handling specialized pool types.
180-196: Deprecated denom0 and denom1 fields in DenomPairTakerFeeThe fields
denom0anddenom1have been marked as deprecated, which is a good practice to maintain backward compatibility while transitioning to a more descriptive naming convention withtokenInDenomandtokenOutDenom.
197-198: Added new tokenInDenom and tokenOutDenom fields to DenomPairTakerFeeThese new fields replace the deprecated
denom0anddenom1fields with more descriptive names that better reflect their purpose in uni-directional trading pairs. This change improves code clarity and reduces potential confusion.
4-4:❓ Verification inconclusive
Missing import file for "amino/amino.proto"
The import
"amino/amino.proto"appears to be missing. The static analysis shows this file doesn't exist, which could cause compilation errors. Ensure that this proto file is available in your proto include paths or fix the import.
🏁 Script executed:
#!/bin/bash # Check if the amino proto file exists in the project find . -name "amino.proto" | grep -E "amino/amino.proto|amino\.proto"Length of output: 69
Manual Check Required: Verify the Inclusion of "amino/amino.proto"
The automated search within the repository didn’t locate the file "amino/amino.proto". Before proceeding, please manually verify whether this proto file is provided externally (for example, through your proto include paths or an external dependency) or if an alternative file should be imported instead.
- Ensure that your build configuration or dependency management correctly supplies "amino/amino.proto".
- If the file is indeed missing and not available via external dependency, update the import or supply the file to prevent potential compilation errors.
🧰 Tools
🪛 Buf (1.47.2)
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
icq-relayer/go.mod (4)
3-3: Updated Go version to 1.23.7The Go version has been updated from 1.23.3 to 1.23.7, which aligns with the PR objectives to update dependencies. This ensures compatibility with the latest Go security updates and bug fixes.
6-19: Updated core dependencies to latest versionsKey upgrades include:
cosmossdk.io/mathto v1.5.1github.com/cometbft/cometbftto v0.37.15 (replacing Tendermint)github.com/cosmos/cosmos-sdkto v0.47.16github.com/cosmos/ibc-go/v7to v7.9.2github.com/quicksilver-zone/quicksilverto v1.8.0-beta.11These updates align with the PR objectives to upgrade cosmos-sdk, cometbft, ibc-go, and other dependencies.
31-36: Added new Cosmos SDK direct dependenciesAdded new direct dependencies from the Cosmos SDK ecosystem:
cosmossdk.io/apicosmossdk.io/corecosmossdk.io/depinjectcosmossdk.io/errorscosmossdk.io/logcosmossdk.io/tools/rosettaThese are required for compatibility with the updated Cosmos SDK v0.47.16.
215-215: Updated osmomath replacementThe replacement directive for osmomath has been updated to use a specific SDK47-compatible fork maintained by the Quicksilver team. This ensures compatibility with the SDK v0.47 upgrade.
app/upgrades/types.go (2)
19-26: Added new mainnet upgrade version constantsSeveral new mainnet upgrade version constants have been added:
- V010700UpgradeName through V010707UpgradeName
These constants define upgrades for v1.7.0 through v1.7.7, which appear to be references to recently completed upgrades.
27-27: Added new upgrade constant for v1.8.0Added V010800UpgradeName constant for the v1.8.0 upgrade. This matches the PR objective of updating to newer dependency versions, which would typically require a new upgrade handler.
proto/cosmos/lsmstaking/v1beta1/tx.proto (9)
13-13: Custom go_package path for lsmstaking proto definitionsThe go_package path points to a custom package location in the quicksilver codebase (
github.com/quicksilver-zone/quicksilver/x/lsmtypes) rather than using the standard cosmos package. This is unusual but may be intentional to allow for customization of the LSM staking module.Please verify this is the intended package path for these types and not a mistake.
19-24: Implementation of MsgUnbondValidatorThe MsgUnbondValidator message provides a way for validators to gracefully transition to unbonded status without experiencing slashing penalties. The message includes:
- Proper cosmos.msg.v1.signer annotation
- Appropriate amino.name for compatibility
- A single validator_address field for validation
This implementation follows Cosmos SDK message conventions.
29-46: Implementation of MsgTokenizeShares and responseThe MsgTokenizeShares message allows delegations to be tokenized, converting traditional staking positions into transferable tokens. The message includes:
- Proper cosmos.msg.v1.signer and amino.name annotations
- Required gogoproto options for proper encoding
- Fields for delegator_address, validator_address, amount, and tokenized_share_owner
- A response message with an amount field
This implementation follows Cosmos SDK message conventions and enhances liquid staking capabilities.
48-63: Implementation of MsgRedeemTokensForShares and responseThe MsgRedeemTokensForShares message enables the conversion of tokenized shares back into native delegations. The message includes:
- Proper cosmos.msg.v1.signer and amino.name annotations
- Required gogoproto options
- Fields for delegator_address and amount
- A response message with an amount field
This implementation complements the MsgTokenizeShares message and follows Cosmos SDK conventions.
65-79: Implementation of MsgTransferTokenizeShareRecord and responseThe MsgTransferTokenizeShareRecord message facilitates the transfer of tokenized share records between addresses. The message includes:
- Proper cosmos.msg.v1.signer and amino.name annotations
- Required gogoproto options
- Fields for tokenize_share_record_id, sender, and new_owner
- An empty response message
This implementation follows Cosmos SDK conventions and enhances tokenized share management.
81-93: Implementation of MsgDisableTokenizeShares and responseThe MsgDisableTokenizeShares message allows an address to prevent further tokenization of their shares. The message includes:
- Proper cosmos.msg.v1.signer and amino.name annotations
- Required gogoproto options
- A delegator_address field
- An empty response message
This implementation enhances user control over tokenization features.
95-112: Implementation of MsgEnableTokenizeShares and responseThe MsgEnableTokenizeShares message allows an address to re-enable tokenization after previously disabling it. The message includes:
- Proper cosmos.msg.v1.signer and amino.name annotations
- Required gogoproto options
- A delegator_address field
- A response with a completion_time field to indicate when re-enabling takes effect
The completion_time field uses Protobuf timestamp with proper gogoproto options.
114-128: Implementation of MsgValidatorBond and responseThe MsgValidatorBond message enables a validator to bond additional delegated tokens to themselves. The message includes:
- Proper cosmos.msg.v1.signer and amino.name annotations
- Required gogoproto options
- Fields for delegator_address and validator_address
- An empty response message
This implementation follows Cosmos SDK conventions and enhances validator operations.
4-4:❓ Verification inconclusive
Missing import file for "amino/amino.proto"
The import
"amino/amino.proto"appears to be missing. The static analysis shows this file doesn't exist, which could cause compilation errors. Ensure that this proto file is available in your proto include paths or fix the import.
🏁 Script executed:
#!/bin/bash # Check if the amino proto file exists in the project find . -name "amino.proto" | grep -E "amino/amino.proto|amino\.proto"Length of output: 69
Action Required: Verify the "amino/amino.proto" Import
The import in
proto/cosmos/lsmstaking/v1beta1/tx.proto:import "amino/amino.proto";appears to reference a file that our automated search did not locate in the repository. This missing proto file may lead to compilation errors during builds. Please manually verify the following:
- Confirm whether
amino/amino.protoexists elsewhere (perhaps as an external dependency, submodule, or within a different directory not covered by our current search).- If the file should be internal, add it to the repository at the expected location.
- If it is provided externally, ensure that your proto include paths and build configurations are updated accordingly.
Manual confirmation is advised given the ambiguous automated check output.
🧰 Tools
🪛 Buf (1.47.2)
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/osmosis/gamm/v1beta1/tx.proto (3)
10-10: Updated go_package path for better organizationThe go_package path has been updated to include a
/typessubdirectory, which follows good practice for organizing protobuf-generated code.
26-27: Added Amino serialization and signer optionsAdding these options for each message type provides proper serialization support and explicitly defines the signer field, improving clarity and functionality.
Also applies to: 56-57, 82-83, 107-108, 134-135, 164-165, 192-193, 220-221
4-4:❓ Verification inconclusive
Import file not found: amino/amino.proto
The static analysis indicates that the imported file "amino/amino.proto" does not exist. This could lead to compilation errors.
🏁 Script executed:
#!/bin/bash # Check if the amino/amino.proto file exists in the repository fd --type f "amino.proto" --search-path ./protoLength of output: 47
Attention: Verify 'amino/amino.proto' Import
The automated search did not find any file matching "amino.proto" under the
./protodirectory. This raises a concern that the import statement may reference a non-existent file, potentially leading to compilation errors. Please manually verify if the file namedamino/amino.protois meant to exist in the repository:
- Confirm whether
amino/amino.protoshould be present.- If the file exists at a different location, update the import path accordingly.
- If it is no longer needed, consider removing the import statement.
🧰 Tools
🪛 Buf (1.47.2)
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
third-party-chains/osmosis-types/concentrated-liquidity/math/math.go (5)
6-6: Updated import path for osmomath packageThe import path has been updated to reference the osmosis-labs organization's repository, which aligns with the dependency updates in this PR.
82-84: TODOs in performance-critical mathematical codeThere are multiple TODOs in this performance-critical financial code that should be addressed:
TODO (perf): Don't truncate after liq.MulRoundUp(diff)...TODO (perf): QuoRoundUpMut with no reallocation for internal scratch var.These TODOs indicate potential optimizations that could improve performance and reduce memory allocations.
114-115: TODO: Make a MulDecCeilMut to save more internal opsThis TODO indicates a potential optimization opportunity for improved performance in a critical mathematical operation.
84-84: Updated calculations to match type changesThe internal calculations have been modified to accommodate the type changes (BigDec to Dec). Please ensure these changes maintain the required precision for financial calculations.
Consider adding comprehensive unit tests to verify that these calculation changes don't affect numerical outcomes.
Also applies to: 92-92, 115-115, 121-121, 154-154, 167-167, 176-176
60-60:❓ Verification inconclusive
Function parameter type changes from BigDec to Dec
Multiple function signatures have been changed to use
osmomath.Decinstead ofosmomath.BigDecfor the liquidity parameter. This could affect precision in calculations, which is critical for financial operations.Also applies to: 99-99, 148-148, 166-166, 175-175
🏁 Script executed:
#!/bin/bash # Check for any other uses of these functions in the codebase to verify compatibility echo "Searching for uses of CalcAmount0Delta and CalcAmount1Delta..." rg "CalcAmount0Delta|CalcAmount1Delta|GetNextSqrtPriceFromAmount0OutRoundingUp|GetNextSqrtPriceFromAmount1InRoundingDown|GetNextSqrtPriceFromAmount1OutRoundingDown" --type goLength of output: 3436
Action Required: Verify Liquidity Calculation Precision
The liquidity parameter in functions like
CalcAmount0Delta(as well as similar functions) has been changed fromosmomath.BigDectoosmomath.Dec. Our repository search shows that function calls in files such asthird-party-chains/osmosis-types/concentrated-liquidity/model/pool.gonow consistently pass liquidity values of typeosmomath.Dec.However, please verify that the precision characteristics of
osmomath.Decare sufficient for financial operations, as this change could impact the fine-grained accuracy expected in these calculations.• Affected function definitions in
third-party-chains/osmosis-types/concentrated-liquidity/math/math.goat line 60 and related locations.
• Related usage inthird-party-chains/osmosis-types/concentrated-liquidity/model/pool.go.proto/osmosis/concentratedliquidity/v1beta1/query.proto (5)
11-13: Updated imports to use v1beta1 directoryThe imports now reference the v1beta1 directory for incentive_record.proto, position.proto, and tick_info.proto, which provides better organization and versioning for the protocol buffers.
15-15: Updated go_package path for improved organizationThe go_package path has been updated from "model" to "client/queryproto", which better reflects the purpose of this file and improves the package structure.
65-80: Uncommented and implemented additional RPC methodsThree new RPC methods have been uncommented and implemented:
- PoolAccumulatorRewards - Returns pool-global accumulator rewards
- IncentiveRecords - Returns incentive records for a given poolId
- TickAccumulatorTrackers - Returns tick accumulator trackers
This enhances the API functionality and aligns with the updates mentioned in the PR objectives.
242-285: Added message definitions for new RPC methodsThe corresponding message definitions for the new RPC methods have been added:
- PoolAccumulatorRewardsRequest/Response
- TickAccumulatorTrackersRequest/Response
- IncentiveRecordsRequest/Response
This completes the implementation of the new API functionality.
198-198: Updated custom type path for current_sqrt_priceThe custom type for current_sqrt_price has been updated to reference "github.com/osmosis-labs/osmosis/osmomath.BigDec", which aligns with the changes in the math.go file and ensures consistency across the codebase.
proto/osmosis/concentratedliquidity/v1beta1/tx.proto (8)
1-3: Review of file header and package definition.The syntax, package, and initial lines follow conventional gRPC definitions. No immediate issues found in these lines.
9-10: go_package option check.The go_package string is properly set to reflect your repository path. No additional concerns here.
11-25: Service definition structure.The service defines multiple RPC operations for liquidity positions. The naming and structure align well with typical
Msgservices.
27-79: MsgCreatePosition request & response validation.
- Fields
tokens_provided,token_min_amount0, andtoken_min_amount1are well-defined to handle multiple token inputs.- The
liquidity_createdfield in the response uses aLegacyDectype, which may be valid given existing code patterns, but ensure downstream usage is consistent with current library standards.Please confirm that the receiving modules or front-end components expect
LegacyDecfor liquidity.
81-133: MsgAddToPosition messages.The approach for adding liquidity (deleting old position and creating a new one internally) appears consistent with the comments. The repeated usage of string-based math types (e.g.,
cosmossdk.io/math.Int) ensures large numeric range support.
135-198: MsgWithdrawPosition and reward collection messages.No immediate concerns within these messages. The
withdrawing liquidityfields and the repeated coin arrays inMsgCollectSpreadRewards/MsgCollectIncentivesare standard.
200-224: MsgFungifyChargedPositions / MsgTransferPositions.These final messages expand position management capabilities.
MsgTransferPositionsResponseis empty, which is acceptable if no data is returned upon successful ownership transfer.
4-8:❓ Verification inconclusive
Verify existence of 'amino/amino.proto' import.
The static analysis hint indicates that
"amino/amino.proto"may not exist or cannot be resolved. Please ensure this file is indeed present or remove/fix the import reference.Run the following script to verify if
amino.protoexists and is properly addressed in the codebase:
🏁 Script executed:
#!/bin/bash # Searching for amino.proto in the codebase fd amino.protoLength of output: 16
Attention: Manual Verification Required for "amino/amino.proto" Import
The static analysis hint flagged a potential issue with the
"amino/amino.proto"import, and the previousfdsearch did not conclusively locate the file in the repository. Please run the above script or verify manually to confirm whether the file exists. If it does exist, ensure that the import path inproto/osmosis/concentratedliquidity/v1beta1/tx.protois correct; otherwise, remove or update the import reference accordingly.
- File under review:
proto/osmosis/concentratedliquidity/v1beta1/tx.proto(lines 4-8)- Action: Verify the existence and correct location of the imported file
amino/amino.proto.
🏁 Script executed:
#!/bin/bash # Using find to search for amino.proto in the codebase find . -type f -name "amino.proto"Length of output: 156
Manual Verification Required for 'amino/amino.proto' Import
The automated search commands did not yield any results for the file"amino/amino.proto". This suggests that the file might not be present in the repository as expected. Please manually verify whether the file exists (perhaps as part of a submodule or external dependency), and update or remove the import inproto/osmosis/concentratedliquidity/v1beta1/tx.proto(lines 4–8) accordingly.
- File under review:
proto/osmosis/concentratedliquidity/v1beta1/tx.proto- Action: Manually check the expected location or dependency for
"amino/amino.proto"and adjust the import reference if necessary.🧰 Tools
🪛 Buf (1.47.2)
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
proto/osmosis/gamm/v1beta1/query.proto (6)
1-3: File header and package definition.The syntax and package names are conventional. No immediate issues.
15-16: go_package definition.The go_package definition properly references your third-party-chains directory. No issues here.
17-113: Query service definitions (Pools, NumPools, etc.).
- Multiple RPC endpoints marked as deprecated, indicating the recommended usage is shifted to
x/poolmanager. This is acceptable if backward compatibility is required.- HTTP annotations for RESTful endpoints look consistent with standard patterns.
115-283: Message definitions and repeated fields.
- Pagination messages and repeated coin fields are well-structured.
- The usage of
option deprecated = truefor certain request/response messages aligns with your plan to rely on other modules.
284-359: Additional queries (SpotPrice, SwapExactAmountIn/Out, CFMM links).No concurrency or security concerns, as these are purely data definitions. The repeated usage of
google.api.httpoptions is consistent and suitable for REST endpoints.
4-4:✅ Verification successful
Verify existence of 'cosmos/base/query/v1beta1/pagination.proto' import.
As flagged by static analysis, ensure this import path is correct and the referenced file exists in your repository or dependencies.
🏁 Script executed:
#!/bin/bash # Searching for pagination.proto in the codebase fd pagination.protoLength of output: 21
I'll need to gather more evidence before definitively approving this change because the initial search (using
fd pagination.proto) didn't return any results. This could mean the file isn’t present locally, a different file path is used, or it’s coming from an external dependency.Action Required: Verify the Import Path
The current search returned no output, so please run an additional search for any references to:
import "cosmos/base/query/v1beta1/pagination.proto"Confirm manually (or by running an enhanced script) that the file exists either in your repository or among the imported dependencies.
Once you have the output from this command, please verify that the import path is correct or update it accordingly.
🏁 Script executed:
#!/bin/bash # Re-verify the presence of the import reference across the codebase rg 'import "cosmos/base/query/v1beta1/pagination.proto"'Length of output: 1053
Action: Confirm Dependency for "cosmos/base/query/v1beta1/pagination.proto" Import
The static analysis flagged the import in proto/osmosis/gamm/v1beta1/query.proto. A subsequent search using ripgrep shows that this import is consistently used in multiple proto files across the repository (e.g., proto/quicksilver/claimsmanager/v1/query.proto, proto/osmosis/poolmanager/v1beta1/query.proto, etc.). This consistency suggests that the import is intentional and likely provided via an external dependency.
Please ensure that the dependency supplying "cosmos/base/query/v1beta1/pagination.proto" is correctly integrated into your build configuration. If the file is expected to be in the local repository but isn’t present, update the dependency or the file path accordingly.
🧰 Tools
🪛 Buf (1.47.2)
4-4: import "cosmos/base/query/v1beta1/pagination.proto": file does not exist
(COMPILE)
app/modules.go (11)
4-5: Updated Packet-Forward Middleware v7 imports.This aligns with the PR objective to bump the IBC apps and CometBFT libraries. No concerns.
42-45: Switching to IBC-Go v7 references.References to
github.com/cosmos/ibc-go/v7for ICA and Transfer modules confirm the version upgrade. Good consistency.
82-83: Proposal handlers configuration.Adds
paramsclient.ProposalHandlerand merges with existing upgrade proposals. This is a clean approach to ensure governance proposals are properly handled.
92-92: Addition ofibctm.AppModuleBasic.Enables the light client for Tendermint. Consistent with the new imports. No issues.
144-145: Auth module constructor updated with subspace.Reflects the standard pattern of passing subspace for parameter integration. No issues.
146-146: Bank module constructor updated with subspace.Similarly consistent approach for integrating module params.
148-152: Refined crisis, gov, slashing, distribution, staking modules with subspace arguments.Passing the subspace properly integrates param management. Aligns with typical Cosmos SDK patterns.
186-186: Auth module usage in simulation.Provides the subspace for simulation support. Matches the changes in the main module constructor.
188-190: Simulation for gov, slashing, distribution, staking with updated subspace.Same approach as the main modules. Ensures consistent configuration in simulations.
272-272: Replacing ibchost.ModuleName with ibcexported.ModuleName in orderEndBlockers.Complies with IBC-Go v7 shift to the
ibcexportedreference.
316-316: Replacing ibchost.ModuleName with ibcexported.ModuleName in orderInitBlockers.Maintains consistency with IBC-Go v7 updates.
go.mod (8)
3-3: Update Go Version Reference
The Go version has been bumped from 1.23.3 to 1.23.7. This change is clear and aligns with our updated development environment.
6-10: Dependency Version Bumps (Cosmos SDK & Related Modules)
The updates for dependencies such ascosmossdk.io/api v0.3.1,cosmossdk.io/errors v1.0.2,cosmossdk.io/math v1.5.1, andgithub.com/celestiaorg/go-square/v2 v2.2.0are visible here. These align with the upgrade objectives. Please verify that these new versions work harmoniously with the rest of the codebase.
13-16: Critical Dependency Upgrades: CometBFT & Cosmos-SDK
The changes updatinggithub.com/cometbft/cometbftto v0.37.15 andgithub.com/cosmos/cosmos-sdkto v0.47.16 are central to this PR. Be sure that any breaking changes introduced by these major upgrades are fully validated by integration and unit tests.
18-20: IBC and Middleware Updates
The revision ofgithub.com/cosmos/ibc-apps/middleware/packet-forward-middleware/v7to v7.1.3 andgithub.com/cosmos/ibc-go/v7to v7.9.2 are in line with our objectives. Please ensure that any necessary migration or compatibility work is completed.
23-23: Linting Dependency Update
github.com/golangci/golangci-lint/v2has been updated to v2.0.2. Confirm that this new version does not introduce unexpected linting rule changes in our CI/CD pipeline.
368-381: Replacement Directives Validation
Thereplacesection (lines 368–381) correctly handles custom overrides—for example, remapping the keyring package and the protobuf dependency. Re-check theosmomathoverride to ensure it meets the target versioning for Osmosis types as expected.
383-383: Safety Retraction Notice
The retraction directive (retract v1.7.0 // safety bug) is clearly marked. This critical update will help avoid known issues in v1.7.0.
27-27:❓ Verification inconclusive
Review Osmosis Math Dependency Replacement
In the replacement block, the dependency
github.com/osmosis-labs/osmosis/osmomathis now redirected to
github.com/quicksilver-zone/osmomath v0.0.16-sdk47.
Note that our PR objectives mention bumping Osmosis types to version 28.0.4. Please verify that this replacement version correctly reflects our intended update or adjust as needed.
Action Required: Verify Osmosis Math Dependency Update
The current dependency in
go.modat line 27:github.com/osmosis-labs/osmosis/osmomath v0.0.16needs to be replaced with:
github.com/quicksilver-zone/osmomath v0.0.16-sdk47according to the intended redirection. Please double-check that this substitution aligns with our PR objectives—specifically, that it supports bumping Osmosis types to version 28.0.4—and adjust the dependency if necessary.
proto/osmosis/poolmanager/v1beta1/query.proto (29)
1-3: New Proto File Setup
This new file starts with a correct proto3 syntax declaration and a clear package name (osmosis.poolmanager.v1beta1). Overall, the file layout is clean.
16-16: Updated Go Package Option
The go_package option is now set to
"github.com/quicksilver-zone/quicksilver/third-party-chains/osmosis-types/poolmanager/client/queryproto"
which reflects the new package structure. Confirm that all backend references and client imports have been updated accordingly in other parts of the codebase.
18-21: RPC Method: Params
The RPC methodParamsis added with an HTTP GET option. This method follows our standard and should integrate smoothly with service handlers.
22-27: RPC Method: EstimateSwapExactAmountIn
This method is defined correctly with its HTTP GET mapping. As this is key to swap estimation functionality, ensure that its corresponding implementation rigorously validates inputs and handles error cases.
28-42: RPC Method: EstimateSwapExactAmountInWithPrimitiveTypes
The added method offers an alternative query interface using primitive types with clear inline documentation and HTTP mapping. Verify that client implementations are updated to leverage these new parameters if needed.
44-48: RPC Method: EstimateSinglePoolSwapExactAmountIn
The method for estimating swap amounts in a single pool is defined with a neatly concatenated HTTP endpoint. Please confirm that the service logic can handle this revised endpoint without ambiguity.
50-53: RPC Method: EstimateSwapExactAmountOut
This endpoint maps the HTTP GET for swap-out estimation and appears correctly set up. Validate that the response returns accurate calculations.
55-60: RPC Method: EstimateSwapExactAmountOutWithPrimitiveTypes
This method extends the query interface using primitive types for swap-out estimations. Ensure that its implementation mirrors the corresponding “in” variant appropriately in its processing logic.
62-66: RPC Method: EstimateSinglePoolSwapExactAmountOut
The HTTP mapping for this RPC spans multiple lines but remains correct. Confirm that the URL pattern is as intended and that the service handler composes the response as expected.
68-71: RPC Method: NumPools
A straightforward query that returns the number of pools. Validate the backend correctly calculates the pool count, especially under high-load conditions.
73-77: RPC Method: Pool
The endpoint designed to return the pool by its id is well defined. Consider robust error handling for cases where an invalid pool id is provided.
78-81: RPC Method: AllPools
This method to return all pools provides a clear HTTP mapping. If pagination or sorting is needed in the future, it might be worth revisiting the design.
82-85: RPC Method: ListPoolsByDenom
The new endpoint for listing pools by denomination is clearly defined. Ensure that the filtering logic in the implementation maintains good performance with large datasets.
87-91: RPC Method: SpotPrice
This simple yet crucial method returns the spot price. Double-check that the endpoint’s URL and response format match the client expectations for real-time price queries.
93-96: RPC Method: TotalPoolLiquidity
The mapping properly exposes the liquidity of a specified pool. It’s important to verify that the liquidity calculation considers all edge cases.
98-101: RPC Method: TotalLiquidity
Aggregating liquidity across all pools is a fundamental API endpoint. Consider monitoring its performance when data volumes are high.
103-106: RPC Method: TotalVolumeForPool
This endpoint is defined to return a pool’s total volume. Confirm that the calculation logic is both accurate and efficient under varying load conditions.
108-111: RPC Method: TradingPairTakerFee
The mapping for returning the trading pair taker fee is clear. Ensure that the fee calculation logic is kept consistent with any updates in fee models.
113-118: RPC Method: EstimateTradeBasedOnPriceImpact
This endpoint will estimate trade outcomes based on price impact. The design of returning 0 for both input and output on failure is acceptable—but verify that this fallback behavior is well documented and handled gracefully in clients.
120-127: RPC Method: AllTakerFeeShareAgreements
This method gathers all taker fee share agreements. It is important that the service aggregates these agreements with both completeness and performance in mind.
129-138: RPC Method: TakerFeeShareAgreementFromDenom
This endpoint correctly implements the retrieval of a taker fee share agreement by denom. Confirm that unique identification via denom is robust and does not cause collisions.
140-147: RPC Method: TakerFeeShareDenomsToAccruedValue
The method’s HTTP mapping spans multiple concatenated lines, which is acceptable. Just ensure that the final URL is constructed correctly and that the backend calculates the accrued value accurately.
149-155: RPC Method: AllTakerFeeShareAccumulators
This endpoint (for taker fee share accumulators) is straightforward. Validate that the accumulator values are updated and retrieved accurately, especially during period transitions.
157-165: RPC Method: RegisteredAlloyedPoolFromDenom
The endpoint to query registered alloyed pool state by denom is added. Ensure that the returned contract state fully represents the pool’s fee distribution configuration.
167-175: RPC Method: RegisteredAlloyedPoolFromPoolId
This method mirrors the previous one but uses pool id as the identifier. Verify that the mapping and the response consistency match expectations.
177-183: RPC Method: AllRegisteredAlloyedPools
This endpoint aggregates all registered alloyed pools. It is vital to confirm that the response format and data completeness meet the frontend’s consumption needs.
186-194: Message Group: Params
The definitions forParamsRequestandParamsResponseare straightforward. Just ensure that theParamstype used in the response is defined and maintained elsewhere in the project.
232-486: Message Definitions Verification
The remainder of the file encompasses message definitions for swap estimations, pool queries, fee share queries, and related response types. All gogoproto options (such as custom types, nullability, and moretags) appear to be used consistently. Please verify these definitions against the backend implementations to ensure data‑type consistency across the system.
4-4:❓ Verification inconclusive
Missing Import File Detected
Static analysis has flagged that the import
import "cosmos/base/query/v1beta1/pagination.proto";
may not reference an existing file. Please verify whether this file has been moved, renamed, or is expected to come from an external dependency.
Below is a shell script to search the repository for the file referenced by the import:
#!/bin/bash # Search for the file "cosmos/base/query/v1beta1/pagination.proto" in the repository. fd "cosmos/base/query/v1beta1/pagination.proto"Please run this script to verify whether the file exists in the repository. Depending on the output:
- If the file is found: You can confirm that the import points to an existing file (possibly as an external dependency), and the review comment may be reconsidered or updated accordingly.
- If the file is not found: It indicates that the import indeed references a missing file, and the code or its dependencies need to be updated to reflect the correct location or include the missing file.
🧰 Tools
🪛 Buf (1.47.2)
4-4: import "cosmos/base/query/v1beta1/pagination.proto": file does not exist
(COMPILE)
CHANGELOG.md (4)
3-4: New Unreleased Changelog Section Added
The "Unreleased" section now clearly highlights key upcoming dependency upgrades (Cosmos-SDK 0.47, IBC-go v7.9.2, and CometBFT v0.37.15). This provides immediate visibility into what’s pending for the next release cycle.
5-8: Dependency Upgrade Notices in Changelog
The bullet points detailing upgrades to Cosmos-SDK, IBC-go, and CometBFT are clear and concise. This transparency will help both developers and users understand the current state of dependency management.
11-70: Detailed Release Documentation for Recent Versions
The changelog now documents multiple release versions (e.g., v1.7.7, v1.7.6, etc.) with detailed notes on configuration changes, feature additions, and bug fixes. This level of detail is very useful for historical tracking. Please keep this format maintained in future updates.
1-295: Comprehensive Changelog Updated
Overall, the updated CHANGELOG.md effectively tracks unreleased changes and all versioned releases with thorough notes and contributor references. This will aid in maintaining transparency and traceability across our releases.
| @@ -1,12 +1,14 @@ | |||
| syntax = "proto3"; | |||
| package osmosis.lockup; | |||
|
|
|||
| import "amino/amino.proto"; | |||
There was a problem hiding this comment.
Critical: Non-Existent Import Reference.
The import statement import "amino/amino.proto"; is flagged by static analysis as referencing a file that does not exist. Please verify if the intended file path is correct or remove this import if obsolete.
🧰 Tools
🪛 Buf (1.47.2)
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
| @@ -1,7 +1,8 @@ | |||
| syntax = "proto3"; | |||
| package osmosis.concentratedliquidity.poolmodel.concentrated.v1beta1; | |||
|
|
|||
| import "cosmos/base/v1beta1/coin.proto"; | |||
| import "amino/amino.proto"; | |||
There was a problem hiding this comment.
Resolve missing amino.proto import.
Static analysis indicates that amino/amino.proto may not exist or is not accessible. Double-check that it is included in the project or appropriately vendored.
🧰 Tools
🪛 Buf (1.47.2)
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
| import "amino/amino.proto"; | ||
| import "cosmos/base/v1beta1/coin.proto"; | ||
| import "cosmos/msg/v1/msg.proto"; |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Missing proto file dependency
The static analysis indicates that the imported file "amino/amino.proto" doesn't exist, which could cause compilation issues.
🏁 Script executed:
#!/bin/bash
# Check if the amino.proto file exists in the repository
echo "Searching for amino.proto file..."
fd -t f "amino.proto" --exec echo "Found amino proto at: {}"
# Check if any proto files import amino/amino.proto successfully
echo "Checking other imports of amino/amino.proto..."
rg -l "import \"amino/amino.proto\"" --type protoLength of output: 320
Manual Verification Required: Recheck "amino.proto" Dependency
It appears that the initial automated checks for the existence of "amino/amino.proto" were inconclusive due to file type filtering issues. The shell script produced no output—likely because the --type proto flag did not match any files and led to an "unrecognized file type" error with rg.
Please re-run the following revised shell script to search for the file and the import statement without file type restrictions:
Once these commands have been executed, manually verify whether "amino/amino.proto" exists in the repository or if any proto file correctly imports it. If the file is indeed missing, then the dependency must be added or the import removed to prevent compilation issues.
🏁 Script executed:
#!/bin/bash
echo "Searching for amino.proto in all files ending with .proto..."
fd -t f -e proto "amino.proto" --exec echo "Found amino.proto at: {}"
echo "Searching for import statements of 'amino/amino.proto' in proto files..."
rg -l -g "*.proto" 'import "amino/amino.proto"'Length of output: 1131
Attention: "amino/amino.proto" Dependency Missing
The updated search confirms that while numerous proto files (including proto/osmosis/gamm/poolmodels/balancer/v1beta1/tx.proto on lines 4–6) continue to import "amino/amino.proto", the actual file is not present in the repository. This missing dependency is likely to cause compilation issues.
- Action Items:
- Verify whether
"amino/amino.proto"should be present in the repository. - If the file is required, add it to the appropriate location.
- Otherwise, update or remove the import in affected files.
- Verify whether
🧰 Tools
🪛 Buf (1.47.2)
4-4: import "amino/amino.proto": file does not exist
(COMPILE)
| @@ -121,7 +105,7 @@ func GetAppWithContext(t *testing.T, init bool) (*Quicksilver, sdk.Context) { | |||
| t.Helper() | |||
|
|
|||
| app := Setup(t, !init) | |||
| ctx := app.BaseApp.NewContext(false, tmproto.Header{Height: 1, ChainID: "mercury-1", Time: time.Now().UTC()}) | |||
| ctx := app.NewContext(false, tmproto.Header{Height: 1, ChainID: "mercury-1", Time: time.Now().UTC()}) | |||
There was a problem hiding this comment.
Inconsistent chain ID.
Here the chain ID is set to "mercury-1", which conflicts with line 78 using "quicksilver-1". This discrepancy may cause confusion or unexpected behavior when running tests.
- ctx := app.NewContext(false, tmproto.Header{Height: 1, ChainID: "mercury-1", Time: time.Now().UTC()})
+ ctx := app.NewContext(false, tmproto.Header{Height: 1, ChainID: "quicksilver-1", Time: time.Now().UTC()})📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ctx := app.NewContext(false, tmproto.Header{Height: 1, ChainID: "mercury-1", Time: time.Now().UTC()}) | |
| ctx := app.NewContext(false, tmproto.Header{Height: 1, ChainID: "quicksilver-1", Time: time.Now().UTC()}) |
| V010602UpgradeName = "v1.6.2" | ||
| V010603UpgradeName = "v1.6.3" | ||
| V010604UpgradeName = "v1.6.4" | ||
| TestChainID = "testchain1-1" |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Updated TestChainID to "testchain1-1"
The TestChainID constant has been updated from "testchain1" to "testchain1-1", which may impact test environments. Ensure all references to this chain ID are updated accordingly in your test infrastructure.
🏁 Script executed:
#!/bin/bash
# Search for any references to the old testchain1 ID that might need to be updated
grep -r "testchain1\"" --include="*.go" --include="*.json" . | grep -v "testchain1-1"Length of output: 148
Action Required: Update TestChainID in Tests
Please update the reference in the test file since the TestChainID constant in app/upgrades/types.go has been changed from "testchain1" to "testchain1-1". Currently, there's an outdated reference in:
x/participationrewards/keeper/keeper_test.go(line with"testchain1")
Make sure to update this reference to "testchain1-1" to align your test infrastructure with the updated chain ID and avoid potential test failures.
| github.com/cosmos/cosmos-sdk v0.46.16 | ||
| github.com/cosmos/go-bip39 v1.0.0 | ||
| github.com/cosmos/gogoproto v1.7.0 | ||
| github.com/cosmos/ibc-apps/middleware/packet-forward-middleware/v6 v6.1.2 | ||
| github.com/cosmos/ibc-go/v6 v6.3.1 |
There was a problem hiding this comment.
Cosmos SDK version doesn't match PR objectives
The Cosmos SDK version (0.46.16) doesn't match the PR objective of bumping to 0.47.16. This could lead to compatibility issues with other upgraded dependencies.
Consider updating to the version specified in the PR objectives:
- github.com/cosmos/cosmos-sdk v0.46.16
+ github.com/cosmos/cosmos-sdk v0.47.16📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| github.com/cosmos/cosmos-sdk v0.46.16 | |
| github.com/cosmos/go-bip39 v1.0.0 | |
| github.com/cosmos/gogoproto v1.7.0 | |
| github.com/cosmos/ibc-apps/middleware/packet-forward-middleware/v6 v6.1.2 | |
| github.com/cosmos/ibc-go/v6 v6.3.1 | |
| github.com/cosmos/cosmos-sdk v0.47.16 | |
| github.com/cosmos/go-bip39 v1.0.0 | |
| github.com/cosmos/gogoproto v1.7.0 | |
| github.com/cosmos/ibc-apps/middleware/packet-forward-middleware/v6 v6.1.2 | |
| github.com/cosmos/ibc-go/v6 v6.3.1 |
| github.com/cosmos/ibc-apps/middleware/packet-forward-middleware/v6 v6.1.2 | ||
| github.com/cosmos/ibc-go/v6 v6.3.1 |
There was a problem hiding this comment.
PFM and IBC-Go versions don't match PR objectives
The PR objectives state:
- Bumping ibc-go to version 7.9.2 (currently using v6.3.1)
- Bumping PFM to version 7.1.2 (currently using v6.1.2)
This mismatch could lead to dependency incompatibilities.
Consider updating to the versions specified in the PR objectives:
- github.com/cosmos/ibc-apps/middleware/packet-forward-middleware/v6 v6.1.2
- github.com/cosmos/ibc-go/v6 v6.3.1
+ github.com/cosmos/ibc-apps/middleware/packet-forward-middleware/v7 v7.1.2
+ github.com/cosmos/ibc-go/v7 v7.9.2📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| github.com/cosmos/ibc-apps/middleware/packet-forward-middleware/v6 v6.1.2 | |
| github.com/cosmos/ibc-go/v6 v6.3.1 | |
| github.com/cosmos/ibc-apps/middleware/packet-forward-middleware/v7 v7.1.2 | |
| github.com/cosmos/ibc-go/v7 v7.9.2 |
| github.com/spf13/viper v1.19.0 | ||
| github.com/stretchr/testify v1.9.0 | ||
| github.com/syndtr/goleveldb v1.0.1-0.20220721030215-126854af5e6d | ||
| github.com/tendermint/tendermint v0.34.33 |
There was a problem hiding this comment.
Still referencing Tendermint instead of CometBFT
This dependency is still referencing Tendermint directly, while the PR objective is to bump CometBFT version.
Although there's a replace directive at line 358 that points to CometBFT, for clarity and consistency, consider updating the direct dependency:
- github.com/tendermint/tendermint v0.34.33
+ github.com/cometbft/cometbft v0.37.15📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| github.com/tendermint/tendermint v0.34.33 | |
| github.com/cometbft/cometbft v0.37.15 |
| @@ -0,0 +1,362 @@ | |||
| module github.com/quicksilver-zone/quicksilver/test/interchaintest | |||
|
|
|||
| go 1.23.3 | |||
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Go version 1.23.3 appears invalid - please verify
The specified Go version (1.23.3) seems unusually high, as Go versions typically follow semantic versioning and the latest stable release is much lower than 1.23. This might cause build failures.
🌐 Web query:
What is the latest stable version of Go?
💡 Result:
The latest stable version of Go is 1.24.1, released on March 4, 2025[1][3][7]. This minor update includes security fixes for the net/http package and bug fixes across several components like cgo, the compiler, the go command, and runtime packages[1].
Key details:
- Go follows a six-month release cycle, with major versions supported until two newer releases are available[1][3].
- The current major version Go 1.24 was initially released on February 11, 2025[1][4].
- The release maintains Go's compatibility promise, ensuring source code stability across versions[3][4].
- New features in Go 1.24 include full support for generic type aliases, experimental concurrency testing tools, and improved WebAssembly support[4][7].
Developers can download binaries for all supported platforms from the official Go downloads page[7].
Citations:
- 1: https://go.dev/doc/devel/release
- 2: https://github.com/golang/tools/releases
- 3: https://en.wikipedia.org/wiki/Go_(programming_language)
- 4: https://tip.golang.org/doc/go1.24
- 5: https://antonz.org/which-go/
- 6: https://tip.golang.org/doc/go1.23
- 7: https://go.dev/dl/
- 8: https://hub.docker.com/_/golang
Action Required: Update Go Directive Format in test/interchaintest/go.mod
The go directive currently reads go 1.23.3, but as per standard Go module conventions, only the major and minor version should be specified (e.g. go 1.23). Moreover, with the latest stable release being Go 1.24.1, please confirm if you wish to stick with the intended 1.23 series or upgrade to the current stable version.
- If you intend to use Go 1.23, change the directive to
go 1.23. - Otherwise, update it to reflect the current series with
go 1.24.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
icq-relayer/go.mod (1)
216-216: Commented Replace Directive ReminderThe commented-out replace directive for
github.com/quicksilver-zone/quicksilver => ../appears to be left intentionally. If this is meant only for local development or temporary testing, consider adding a clarifying comment to avoid confusion in future reviews.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (3)
go.sumis excluded by!**/*.sumgo.work.sumis excluded by!**/*.sumicq-relayer/go.sumis excluded by!**/*.sum
📒 Files selected for processing (3)
app/keepers/keepers.go(22 hunks)go.mod(15 hunks)icq-relayer/go.mod(6 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- app/keepers/keepers.go
- go.mod
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: test quicksilver (darwin, arm64)
- GitHub Check: test quicksilver (amd64, linux)
- GitHub Check: test quicksilver (amd64, windows)
- GitHub Check: Analyze
🔇 Additional comments (6)
icq-relayer/go.mod (6)
3-3: Update Go VersionThe Go version has been updated from
1.23.3to1.23.7. This upgrade should help maintain compatibility with the newer dependency releases and toolchain improvements. Please double-check that nothing in the toolchain or build scripts is adversely affected by this change.
6-7: Updated Dependencies: cosmossdk.io/math and tomlThe dependency
cosmossdk.io/mathhas been bumped fromv1.5.0tov1.5.1andgithub.com/BurntSushi/tomlis now set tov1.5.0. These updates are straightforward; however, verify that these version changes are compatible across the codebase.
9-11: Core Dependency UpgradesThe following core dependencies have been updated:
github.com/cometbft/cometbftis now atv0.37.15.github.com/cosmos/cosmos-sdkhas been updated tov0.47.17(note: the PR objectives mentioned v0.47.16; please verify that the extra patch version is intentional).github.com/cosmos/ibc-go/v7is now atv7.10.0.These changes align with the ecosystem upgrades. It would be prudent to run integration tests to ensure that the changes do not introduce any compatibility issues.
15-19: Additional Dependency UpdatesThe updates for
github.com/prometheus/client_golangtov1.21.1,github.com/quicksilver-zone/quicksilvertov1.8.0-beta.11,github.com/spf13/cobratov1.9.1, andgithub.com/spf13/vipertov1.20.1are now in place. These align well with the overall dependency refresh strategy.
22-210: Indirect Dependencies OverhaulA considerable number of indirect dependencies have been updated or added. This includes updates to several
cosmossdk.iomodules, as well as numerous other third-party libraries (e.g., Google packages, gRPC packages, etc.). While these updates appear comprehensive and methodical, please ensure that robust integration and regression tests are executed to capture any unforeseen dependency conflicts or behavioral changes.
212-217:❓ Verification inconclusive
Replace Directive for Osmosis Types
The replace block now maps
github.com/osmosis-labs/osmosis/osmomath => github.com/quicksilver-zone/osmomath v0.0.16-sdk47.
Given that the PR objectives mention bumping Osmosis types to version28.0.4, please confirm that thev0.0.16-sdk47tag indeed reflects the intended update of Osmosis types. Document any intentional deviations if this is a temporary or experimental fork.
I'll begin by verifying the versions mentioned in the directive. I want to check whether there are any occurrences of the target version
"28.0.4"in the repository and also see where"0.0.16-sdk47"is referenced. This should help confirm if the version bump has been applied consistently or if the replacement directive is indeed intentional.
🏁 Script executed:
#!/bin/bash echo "Searching for '28.0.4' occurrences in the repository:" rg --no-heading -n '28\.0\.4' echo "" echo "Searching for '0.0.16-sdk47' occurrences in the repository:" rg --no-heading -n '0\.0\.16-sdk47'Length of output: 1046
Attention: Osmosis Types Replacement Verification
The replacement directive maps
github.com/osmosis-labs/osmosis/osmomath => github.com/quicksilver-zone/osmomath v0.0.16-sdk47
but we noticed that no occurrences of the target version "28.0.4" exist in the repository. Please confirm if the custom fork tagged "v0.0.16-sdk47" is intentionally used to meet the requirements of bumping Osmosis types—even though it differs from "28.0.4"—or if an update is needed. If this deviation is planned (e.g., for temporary or experimental purposes), kindly document the rationale.
1. Summary
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Refactor
Chores