Handle the $ variables in Spotlight queries

[tiennou]

Fixes #2140

[pjrobertson]

Latest QS is 10.9+ right?
In that case we need to change this line

Don't see anything wrong with this though, as long as it doesn't break existing Spotlight Query stuff

[pjrobertson]

...is it worth adding unit tests for doing a query with the two examples given in #2140 ? :-)

[skurfer]

Latest QS is 10.9+ right?
In that case we need to change this line

That’s already changed in #2096 and #2104. No need to do it a third time. 😃

[skurfer]

I wonder why this doesn’t like * now…

2015/10/29 12:11:33.956 AM Quicksilver[605]: An error ocurred while scanning "Comment Tags": Syntax error in Metadata query string: kMDItemFinderComment LIKE[cd] '*#*'
2015/10/29 12:11:33.959 AM Quicksilver[605]: An error ocurred while scanning "Yojimbo Items and Tags": Syntax error in Metadata query string: kMDItemKind LIKE 'Yojimbo*'

[pjrobertson]

Looks like NSPredicate and Spotlight use different syntax :(

https://developer.apple.com/library/ios/documentation/Cocoa/Conceptual/Predicates/Articles/pSpotlightComparison.html

Edit: but still, that doesn't explain why it did work before, and not now.

[tiennou]

@pjrobertson Thanks, I knew there was some differences between the 2 syntaxes but wasn't able to find the actual documentation.

@skurfer Was this running the fix or the master version ?

[skurfer]

that doesn't explain why it did work before, and not now.

I don’t see them using single quotes in any of the examples. Maybe that’s the problem, and not the asterisk.

Was this running the fix or the master version ?

The queries work with master, but fail with this change.

[tiennou]

Differences are that NSPredicate mandates quoting constants and its LIKE clauses are not the same. We can fix that by making it try both syntaxes, but meh.

[skurfer]

is it worth adding unit tests for doing a query with the two examples given

Along with a few others? Yes. I put it on my Remember the Milk Quicksilver list.