Use automaton for multi term query warmups#6361
Open
rdettai-sk wants to merge 1 commit intomainfrom
Open
Conversation
rdettai-sk
changed the title
rdettai-sk
force-pushed
the
multi-term-automaton-warmup
branch
from
8225165 to
965a084
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We noticed that term sets and multi term queries can be very slow. Things are especially bad for term sets targeting dynamic fields -> the whole
_dynamicpostings list is currently warmed up, which can be huuuuuge (in our case close to 10% of the split).This PR uses the automaton warmup for each field that has more than N (currently N=2) non positional terms inside the query.
This PR doesn't address the question of positional terms.
Unfortunately I didn't find a good way to test that the warm up is indeed smaller.