Skip to content

Don't log NotFound as a critical error in delete_evicted_splits #6622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joepio wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Don't log NotFound as a critical error in delete_evicted_splits #6622

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions quickwit/quickwit-storage/src/split_cache/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,10 +176,12 @@ impl SearchSplitCache {
fn delete_evicted_splits(root_path: &Path, splits_to_delete: &[SplitId]) {
for split_to_delete in splits_to_delete {
let split_file_path = root_path.join(split_file(split_to_delete));
if let Err(_io_err) = std::fs::remove_file(&split_file_path) {
if let Err(io_err) = std::fs::remove_file(&split_file_path)
&& io_err.kind() != io::ErrorKind::NotFound
{
// This is an pretty critical error. The split size is not tracked anymore at this
// point.
error!(path=%split_file_path.display(), "failed to remove split file from cache directory. This is critical as the file is now not taken in account in the cache size limits");
error!(path=%split_file_path.display(), error=%io_err, "failed to remove split file from cache directory. This is critical as the file is now not taken in account in the cache size limits");
}
}
}
Expand Down