Fix loading of web page. #67
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The web page would initially not load properly due to some null/undefined mismatch. I'm not too familiar with the subtleties of null vs. undefined so feel free to point me to a better fix if necessary.
jpountz
added a commit
to jpountz/tantivy-search.github.io
that referenced
this pull request
Apr 29, 2025
This updates the website to work with the new format of the results.json file, and includes quickwit-oss/search-benchmark-game#67 as well.
|
I pushed one more commit so that the site can be served from "/" or "/bench" without having to be rebuilt, following the recommendation at https://create-react-app.dev/docs/deployment/#serving-the-same-build-from-different-paths to configure |
jpountz
added a commit
to jpountz/tantivy-search.github.io
that referenced
this pull request
May 1, 2025
This applies the commit from quickwit-oss/search-benchmark-game#67 that configures `homepage: .` in `package.json` so that the same site can be served from `/` (e.g. when running `make serve` in `search-benchmark-game`) or from `/bench` (public results of the benchmark).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The web page would initially not load properly due to some null/undefined mismatch. I'm not too familiar with the subtleties of null vs. undefined so feel free to point me to a better fix if necessary.