#20: Adding a functionality to download transmissions as .wav files.#41
Open
otanim wants to merge 1 commit intoquiet:masterfrom
Open
#20: Adding a functionality to download transmissions as .wav files.#41otanim wants to merge 1 commit intoquiet:masterfrom
otanim wants to merge 1 commit intoquiet:masterfrom
Conversation
Member
|
Hi @otanim Thanks for the PR. I'd like this functionality to make use of libsndfile, same as the C library does so that they generate the same file. The JS building pipeline (via emscripten) will need to bundle libsndfile and then the JS layer can call into it using similar logic as the C encode_file.c program. I'd be happy to give suggestions on this process if it helps. Cheers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal is to allow record transmissions, this resolves #20 issue.
With the following changes now you can set the following 2 new parameters for the transmitter:
Example: