[CON-659] General audit #145
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
|
||
| setBalance(assets) | ||
| console.log(assets) | ||
| setBalance(result) |
There was a problem hiding this comment.
Incorrect response property access breaks token balance functionality
The response destructuring was changed from extracting assets to extracting result, which breaks the wallet token balance feature. The QuickNode qn_getWalletTokenBalance API returns a response containing an assets array property with the token balances. When using ethers.js provider.send(), the JSON-RPC result is returned directly, so the code should extract assets from data, not result. This change causes balance to be set to undefined, preventing tokens from being displayed.
CONTRIBUTING.md
Outdated
| - **Title** from the first `# Heading` in your README.md | ||
| - **Description** from `package.json`'s `description` field | ||
|
|
||
| Optional: Install the pre-commit hook to update automatically on each commit: |
There was a problem hiding this comment.
We mention the pre-commit hook earlier in Setup, but here it's mentioned again as optional.
README.md
Outdated
| cd qn-guide-examples/<example-folder> | ||
| # Install dependencies for the chosen runtime (e.g., npm install, yarn, pip, go mod download) | ||
| cp .env.example .env # if provided | ||
| # Update .env with your Quicknode endpoint keys and any required secrets |
There was a problem hiding this comment.
I think this should be
Update .env with your Quicknode endpoint URLs and any required secrets
README.md
Outdated
|
|
||
| ## Community & Support | ||
|
|
||
| - Join the Quicknode Discord for questions and collaboration: https://discord.gg/quicknode |
There was a problem hiding this comment.
I would make "Quicknode Discord" the link vs a raw URL
README.md
Outdated
|
|
||
| - Join the Quicknode Discord for questions and collaboration: https://discord.gg/quicknode | ||
| - Repo-specific bugs or requests: open a GitHub issue so we can track it. | ||
| - Need help with Quicknode products? Reach out via support: https://support.quicknode.com/ |
There was a problem hiding this comment.
Same here, link "Reach out via support"
| const params = [{ | ||
| wallet: wallet, | ||
| } | ||
| }] |
There was a problem hiding this comment.
Incorrect API parameter format breaking NFT Explorer
The API calls to Quicknode methods are now passing parameters as an array wrapped around an object instead of passing the object directly. The reference scripts in scripts/getWalletTokenBalance.js and similar files show these methods expect provider.send(method, {...params}) not provider.send(method, [{...params}]). This breaks all three pages since the API will reject the malformed parameters.
Note
Rebrand and docs overhaul
README.mdwith badges, usage guidance, and auto-generated project directory; adds comprehensiveCONTRIBUTING.md; updatesCLAUDE.mdNew/updated examples and guides
Streams/ai-bot-discordand updates Streams setup docs; multiple minor README fixes across AI, EVM MCP, Solana, Base, Bitcoin, Console APINFT Collection Explorer improvements
alt), and UI styling; updatestsconfig.jsontoreact-jsxRemovals and misc tweaks
enhanced-apis/get-receipts-by-addressexampleWritten by Cursor Bugbot for commit d156d04. This will update automatically on new commits. Configure here.