Addresses TODOs in TokenGate component. #138
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed some ToDos
johnpmitsch
reviewed
Nov 12, 2025
Contributor
johnpmitsch
left a comment
johnpmitsch
left a comment
There was a problem hiding this comment.
Seems like this moves the verification message and adds another error type but there's a lot of TODOs removed that don't seem addressed here
| 'This message is used to verify your wallet ownership.\n\nSigning this message will not make any transactions.'; | ||
| await signer.signMessage(message); | ||
| // TODO: Store the hashed message, and re-verify hash instead of having to ask wallet to sign each time | ||
| // https://github.com/ethers-io/ethers.js/issues/447 |
| // Using this global state to persist the verification state between page navigation | ||
| // TODO: Can we do this with a localstorage or a cookie in a secure way? | ||
| // that can't be faked by non-nft holders with an expiration? | ||
| // TODO: Can we use redux here? |
Contributor
There was a problem hiding this comment.
@kayvee-x are these TODOs addressed by these changes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ERRORstatus toOWNERSHIP_STATUSenum for proper error handling