fix: handle rng-seed values greater than 2^32-1#328
Open
asaites wants to merge 1 commit into
Open
Conversation
Values larger than 2^32-1 should be converted to a byte array before passing them onward to the seeded-random-state function. Closes: quil-lang#327
Member
|
Thanks for the patch. I'll try to have it reviewed by tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Values larger than$2^{32}-1$ should be converted to a byte array before passing them onward to the
seeded-random-statefunction.Note to reviewers: I am not experienced with lisp, and so used generative AI to write the
integer->ub32-vectorfunction. My apologies if it is not a particularly idiomatic way to accomplish this in lisp, but in any case, the important aspect for the fix is thatget-random-stateconverts larger values to an array (or rejects them).Closes: #327