Skip to content

Fix invalid-workflow-config notice overlapping the fields in Set-remote and commit dialogs - #765

Merged
fiskus merged 1 commit into
mainfrom
fix-invalid-config-notice-overlap
Jul 13, 2026
Merged

Fix invalid-workflow-config notice overlapping the fields in Set-remote and commit dialogs#765
fiskus merged 1 commit into
mainfrom
fix-invalid-config-notice-overlap

Conversation

@fiskus

@fiskus fiskus commented Jul 13, 2026

Copy link
Copy Markdown
Member

Summary

When a bucket's workflows/config.yml is malformed, the Set-remote popup and the commit dialog show an invalid-config notice naming the schema-violation reason. For a short reason it looked fine, but a long multi-line reason (e.g. a full JSON-schema violation path) overlapped the field above it instead of taking its own space.

Cause: the notice reused .qui-workflow-error, styled position: absolute; bottom: -8px — sized for a short one-line workflow error. Being out of normal flow it couldn't push siblings down, and bottom-anchored it grew upward over the Bucket field. It was the sole user of that class, and because the workflow selector is a shared component, it overlapped in both the popup and the commit dialog.

Fix: render .qui-workflow-error in normal flow (display: block, top margin, overflow-wrap: anywhere) — mirroring .qui-workflow-hint, which is exactly how the Unavailable state already renders its notice in the same box without overlap. One CSS rule; no markup change.

Found while running the workflow-support feature test against a bucket with a deliberately-broken config.

Testing

Verified in the running app (Set-remote popup and commit dialog): a long invalid-config reason now wraps below the field and claims its own vertical space — no overlap. Pure CSS; the notice's text/link and the enforcement behavior are unchanged. wasm clippy clean.

Versions

quilt-sync 0.18.3-alpha12.

Greptile Summary

This PR fixes the workflow config notice layout and bumps the app version.

  • Changed .qui-workflow-error to render in normal flow with wrapping.
  • Added a changelog entry for v0.18.3-alpha12.
  • Updated the quilt-sync version in the manifest and lockfile.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
quilt-sync/ui/assets/css/components/workflow_select.css Changes the malformed workflow-config notice from absolute positioning to normal-flow wrapped text.
quilt-sync/src-tauri/Cargo.toml Bumps the quilt-sync package version to 0.18.3-alpha12.
Cargo.lock Updates the locked quilt-sync package version to match the manifest.
quilt-sync/CHANGELOG.md Adds the v0.18.3-alpha12 changelog note for the workflow notice layout fix.

Reviews (1): Last reviewed commit: "Wrap the invalid-config notice instead o..." | Re-trigger Greptile

The Set-remote popup and commit dialog rendered a malformed-workflow-config
notice with position:absolute, sized for a short one-line error; a long
schema-violation reason grew upward out of flow and overlapped the field
above it. Render it in normal flow so it claims its own space and wraps.
@fiskus
fiskus merged commit 3e7ed3f into main Jul 13, 2026
7 checks passed
@fiskus
fiskus deleted the fix-invalid-config-notice-overlap branch July 13, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant