Fix invalid-workflow-config notice overlapping the fields in Set-remote and commit dialogs - #765
Merged
Merged
Conversation
The Set-remote popup and commit dialog rendered a malformed-workflow-config notice with position:absolute, sized for a short one-line error; a long schema-violation reason grew upward out of flow and overlapped the field above it. Render it in normal flow so it claims its own space and wraps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a bucket's
workflows/config.ymlis malformed, the Set-remote popup and the commit dialog show an invalid-config notice naming the schema-violation reason. For a short reason it looked fine, but a long multi-line reason (e.g. a full JSON-schema violation path) overlapped the field above it instead of taking its own space.Cause: the notice reused
.qui-workflow-error, styledposition: absolute; bottom: -8px— sized for a short one-line workflow error. Being out of normal flow it couldn't push siblings down, and bottom-anchored it grew upward over the Bucket field. It was the sole user of that class, and because the workflow selector is a shared component, it overlapped in both the popup and the commit dialog.Fix: render
.qui-workflow-errorin normal flow (display: block, top margin,overflow-wrap: anywhere) — mirroring.qui-workflow-hint, which is exactly how theUnavailablestate already renders its notice in the same box without overlap. One CSS rule; no markup change.Found while running the workflow-support feature test against a bucket with a deliberately-broken config.
Testing
Verified in the running app (Set-remote popup and commit dialog): a long invalid-config reason now wraps below the field and claims its own vertical space — no overlap. Pure CSS; the notice's text/link and the enforcement behavior are unchanged. wasm clippy clean.
Versions
quilt-sync
0.18.3-alpha12.Greptile Summary
This PR fixes the workflow config notice layout and bumps the app version.
.qui-workflow-errorto render in normal flow with wrapping.v0.18.3-alpha12.quilt-syncversion in the manifest and lockfile.Confidence Score: 5/5
This looks safe to merge.
Important Files Changed
quilt-syncpackage version to0.18.3-alpha12.quilt-syncpackage version to match the manifest.v0.18.3-alpha12changelog note for the workflow notice layout fix.Reviews (1): Last reviewed commit: "Wrap the invalid-config notice instead o..." | Re-trigger Greptile