Skip to content

Improve f64 encoding #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
quininer merged 1 commit into from
Nov 17, 2025
Merged

Improve f64 encoding #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 22 additions & 14 deletions src/core/enc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,9 @@ impl Encode for TypeNum<u16> {
match u8::try_from(self.value) {
Ok(x) => TypeNum::new(self.type_, x).encode(writer)?,
Err(_) => {
let [x0, x1] = self.value.to_be_bytes();
writer.push(&[self.type_ | 0x19, x0, x1])?
let mut buf = [self.type_ | 0x19, 0, 0];
buf[1..3].copy_from_slice(&self.value.to_be_bytes());
writer.push(&buf)?
}
}
Ok(())
Expand All @@ -83,8 +84,9 @@ impl Encode for TypeNum<u32> {
match u16::try_from(self.value) {
Ok(x) => TypeNum::new(self.type_, x).encode(writer)?,
Err(_) =>{
let [x0, x1, x2, x3] = self.value.to_be_bytes();
writer.push(&[self.type_ | 0x1a, x0, x1, x2, x3])?;
let mut buf = [self.type_ | 0x1a, 0, 0, 0, 0];
buf[1..5].copy_from_slice(&self.value.to_be_bytes());
writer.push(&buf)?;
}
}
Ok(())
Expand All @@ -97,8 +99,9 @@ impl Encode for TypeNum<u64> {
match u32::try_from(self.value) {
Ok(x) => TypeNum::new(self.type_, x).encode(writer)?,
Err(_) => {
let [x0, x1, x2, x3, x4, x5, x6, x7] = self.value.to_be_bytes();
writer.push(&[self.type_ | 0x1b, x0, x1, x2, x3, x4, x5, x6, x7])?;
let mut buf = [self.type_ | 0x1b, 0, 0, 0, 0, 0, 0, 0, 0];
buf[1..9].copy_from_slice(&self.value.to_be_bytes());
writer.push(&buf)?;
}
}
Ok(())
Expand Down Expand Up @@ -349,35 +352,39 @@ impl<T: Encode> Encode for types::Maybe<&'_ Option<T>> {
impl Encode for half::f16 {
#[inline]
fn encode<W: Write>(&self, writer: &mut W) -> Result<(), Error<W::Error>> {
let [x0, x1] = self.to_be_bytes();
writer.push(&[marker::F16, x0, x1])?;
let mut buf = [marker::F16, 0, 0];
buf[1..3].copy_from_slice(&self.to_be_bytes());
writer.push(&buf)?;
Ok(())
}
}

impl Encode for types::F16 {
#[inline]
fn encode<W: Write>(&self, writer: &mut W) -> Result<(), Error<W::Error>> {
let [x0, x1] = self.0.to_be_bytes();
writer.push(&[marker::F16, x0, x1])?;
let mut buf = [marker::F16, 0, 0];
buf[1..3].copy_from_slice(&self.0.to_be_bytes());
writer.push(&buf)?;
Ok(())
}
}

impl Encode for f32 {
#[inline]
fn encode<W: Write>(&self, writer: &mut W) -> Result<(), Error<W::Error>> {
let [x0, x1, x2, x3] = self.to_be_bytes();
writer.push(&[marker::F32, x0, x1, x2, x3])?;
let mut buf = [marker::F32, 0, 0, 0, 0];
buf[1..5].copy_from_slice(&self.to_be_bytes());
writer.push(&buf)?;
Ok(())
}
}

impl Encode for f64 {
#[inline]
fn encode<W: Write>(&self, writer: &mut W) -> Result<(), Error<W::Error>> {
let [x0, x1, x2, x3, x4, x5, x6, x7] = self.to_be_bytes();
writer.push(&[marker::F64, x0, x1, x2, x3, x4, x5, x6, x7])?;
let mut buf = [marker::F64, 0, 0, 0, 0, 0, 0, 0, 0];
buf[1..9].copy_from_slice(&self.to_be_bytes());
writer.push(&buf)?;
Ok(())
}
}
Expand Down Expand Up @@ -478,6 +485,7 @@ fn test_encoded() -> anyhow::Result<()> {
1.1f64, "0xfb3ff199999999999a";
@ #[cfg(feature = "half-f16")] half::f16::from_f32(1.5), "0xf93e00";
@ #[cfg(feature = "half-f16")] half::f16::from_f32(65504.0), "0xf97bff";
types::F16(0x7bff), "0xf97bff";
100000.0f32, "0xfa47c35000";
3.4028234663852886e+38f32, "0xfa7f7fffff";
1.0e+300f64, "0xfb7e37e43c8800759c";
Expand Down