docs(quinn): Revise SendStream::write docs#2227
Merged
gretchenfrage merged 1 commit intoquinn-rs:mainfrom Aug 19, 2025
Merged
Conversation
Collaborator
|
Initial bikeshedding:
|
djc
reviewed
May 12, 2025
flub
reviewed
May 14, 2025
Contributor
flub
left a comment
There was a problem hiding this comment.
Overall I like these changes!
Contributor
This mirrors how tokio talks about it. They use a section header named |
Member
|
@gretchenfrage want to polish this up so we can merge it? |
Collaborator
Author
Member
Collaborator
Author
|
My revision of this PR is in-progress, I'm hoping I can put it back into review tomorrow. I appreciate your patience with me as my capacity has been reduced a lot recently. |
Aligns with 100 columns, attempts to improve clarity, takes inspiration from tokio::io::AsyncWriteExt docs.
185d300 to
8e7240b
Compare
Collaborator
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns with 100 columns, attempts to improve clarity, takes inspiration from tokio::io::AsyncWriteExt docs.