Conversation
paulcdejean
requested review from
Ralith,
djc and
gretchenfrage
as code owners
|
Fixes #2425 |
|
There's currently TODOs all over the place here. I did try and dig through the code and see what the feature flags were actually doing but I'm not going to have the same depth of understanding as a maintainer. Happy to update this based on feedback, however I'm not going to be able to complete the existing TODOs on my own without feedback or assistance. |
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
Also worth documenting tracing-log?
|
Ready for re review! Thanks for all the helpful feedback. |
|
Do you know this crate: https://docs.rs/document-features/latest/document_features/ it's very useful for this case. |
|
(If you rebase on |
paulcdejean
force-pushed
the
issue-2425
branch
from
ca38117 to
2a5a5a5
Compare
|
I rebased. Should I also squash? Or will do you the squashing? |
paulcdejean
force-pushed
the
issue-2425
branch
from
a476616 to
15108d2
Compare
|
I saw you said to squash so I squashed. |
| //! | ||
| //! - `runtime-tokio`: Enable integration with the tokio async runtime. | ||
| //! - `runtime-smol`: Enable integration with the smol runtime. | ||
| //! - `smol`: Also enable integration with the smol runtime. |
There was a problem hiding this comment.
What's the difference between runtime-smol and smol? Should be explained here.
There was a problem hiding this comment.
I have no idea. @djc do you have any idea? Looking at the code I'm not sure how to better document this.
There was a problem hiding this comment.
See here:
|
@Frando I reworked the crypto section based on your feedback and based on digging into the code more. |
paulcdejean
force-pushed
the
issue-2425
branch
from
6528c3c to
82609f2
Compare
|
This PR is currently soft blocked by #2443 |
|
@paulcdejean #2443 is merged JSYK. Interested in rebasing and squashing? |
|
Thanks for letting me know. My life has been kinda hectic as of late, but definitely will take a pass at this again next time I sit down for programming time. |
|
@djc @gretchenfrage can someone else take this? I haven't been active in the rust or quic spaces recently. Feel free to copy and paste my changes or similar if that would be helpful. |
6 participants
No description provided.