Introduce max_outgoing_bytes_per_second option#2556
Introduce max_outgoing_bytes_per_second option#2556aochagavia wants to merge 1 commit intoquinn-rs:mainfrom
max_outgoing_bytes_per_second option#2556Conversation
e3d3cbb to
cfcf4eb
Compare
|
fyi. requirement discussed in draft-many-tiptop-quic-profile |
cfcf4eb to
4a0acfe
Compare
4a0acfe to
cc79677
Compare
|
Looking at the code, it seems like it could also live inside a congestion controller because all we do is manipulate the congestion window. In all honesty, that approach seems cleaner to me than what I've implemented in this PR. What do you think? The only caveat I can think of right now is that the initial congestion window needs to be calculated based on the initial RTT (which is configurable), and the congestion controller doesn't have access to that information. |
|
I like that, as written, this feature will Just Work with any congestion controller. I'm not absolutely certain how broadly useful it is, but there's definitely a number of internet applications where a manual total bandwidth limit is handy. |
|
In that case, let's keep things as-is :) |
cc @Ralith
This is something we discussed a while ago. It came up in the context of deep space QUIC networking, which requires being able to rate-limit outgoing traffic (traditional congestion control algorithms don't work when an ACK takes minutes to arrive 😅).