0.11.x: avoid unwrapping VarInt decoding during parameter parsing#2559
Merged
0.11.x: avoid unwrapping VarInt decoding during parameter parsing#2559
Conversation
```
warning: called `unwrap` on `self.exit_probe_rtt_at` after checking its variant with `is_none`
--> quinn-proto/src/congestion/bbr/mod.rs:247:48
|
238 | if self.exit_probe_rtt_at.is_none() {
| ----------------------------------- help: try: `if let Some(<item>) = self.exit_probe_rtt_at`
...
247 | } else if is_round_start && now >= self.exit_probe_rtt_at.unwrap() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
= note: `#[warn(clippy::unnecessary_unwrap)]` on by default
```
djc
force-pushed
the
0.11.x-params-var-ints
branch
3 times, most recently
from
3dcca3d to
cb5ae6d
Compare
djc
force-pushed
the
0.11.x-params-var-ints
branch
from
cb5ae6d to
a2ab220
Compare
Member
Author
|
Not sure what's going on with these WASM failures: All of these changes are backported from main; merging without approval for release. |
This was referenced Mar 9, 2026
This was referenced Mar 10, 2026
1 task
This was referenced Mar 11, 2026
superninja-app bot
pushed a commit
to arkavo-org/arkavo-edge
that referenced
this pull request
Mar 11, 2026
Bump quinn-proto from 0.11.13 to 0.11.14 in two sub-workspaces to address a high-severity unauthenticated remote denial-of-service vulnerability (RUSTSEC-2026-0037 / GHSA-6xvm-j4wr-6v98, CVSS 8.7). Receiving QUIC transport parameters containing invalid values could trigger a panic in quinn-proto's transport parameter parsing code due to improper use of unwrap() calls, allowing any unauthenticated remote attacker to crash a Quinn endpoint with a single malformed packet. Affected sub-workspaces: - crates/arkavo-protocol/fuzz/ (Dependabot alert #27) - examples/fleet-immunity/mcp-fleet-env/ (Dependabot alert #26) Changes: - Add [patch.crates-io] quinn-proto = =0.11.14 to both Cargo.toml files - Update Cargo.lock entries to quinn-proto 0.11.14 (checksum: 434b42fec591c96ef50e21e886936e66d3cc3f737104fdb9b737c40ffb94c098) References: - https://rustsec.org/advisories/RUSTSEC-2026-0037.html - GHSA-6xvm-j4wr-6v98 - quinn-rs/quinn#2559
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport to 0.11.x:
Fixes GHSA-6xvm-j4wr-6v98.