Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functional inputs serialisation to csv #1506

Closed
wants to merge 4 commits into from
Closed

Functional inputs serialisation to csv #1506

wants to merge 4 commits into from

Conversation

louispt1
Copy link
Contributor

@louispt1 louispt1 commented Mar 7, 2025 •
edited
Loading

Goes with this PR from ETModel: quintel/etmodel#4433

@louispt1 louispt1 requested review from noracato and mabijkerk March 7, 2025 12:13
@louispt1 louispt1 mentioned this pull request Mar 7, 2025
Open
mabijkerk
mabijkerk requested changes Mar 10, 2025
View reviewed changes
Copy link
Member

@mabijkerk mabijkerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noracato should review the code itself, but I tested it and it works as I would expect 🙌🏻 Only question @louispt1 is why you removed one of the migrations? Finally, a next step would be to add the locales to this download, but that would be an enhancement. Let's first get this PR merged.

@louispt1
Copy link
Contributor Author

@noracato should review the code itself, but I tested it and it works as I would expect 🙌🏻 Only question @louispt1 is why you removed one of the migrations? Finally, a next step would be to add the locales to this download, but that would be an enhancement. Let's first get this PR merged.

Sorry I didn't mean to push removing the migration - I'm just using an old db that doesn't need it. I've added it back in.

@louispt1
Copy link
Contributor Author

This has been picked up with a different approach in quintel/etmodel#4433

@louispt1 louispt1 closed this Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mabijkerk mabijkerk mabijkerk requested changes

@noracato noracato Awaiting requested review from noracato

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louispt1 @mabijkerk