Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Rails 7.1 with messagepack as base serialiser #1528

Closed
wants to merge 4 commits into from

Conversation

noracato
Copy link
Member

Update Rails to 7.1.5 in order to prepare for issue #1509

@noracato noracato requested a review from louispt1 March 24, 2025 14:55
Copy link
Contributor

@louispt1 louispt1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed so far - seems good to me, hopefully the Nokogiri stuff is just to do with the necessary Ruby 3.2 changes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to remove this once finished with the change

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even need this file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, but it ships with Rails 🤷‍♀️

@noracato
Copy link
Member Author

Superseded by #1532

@noracato noracato closed this Mar 28, 2025
@noracato noracato deleted the rails-7.1 branch March 28, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants