Attach / Detach user curves #1530
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c could still be refactored but leaving it for now
louispt1
force-pushed
the
attach-detach-curves
branch
from
3587f87 to
48e1570
Compare
…to match expectations, tidied up
louispt1
force-pushed
the
attach-detach-curves
branch
from
48e1570 to
1f939e7
Compare
This was
linked to
issues
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds upon #1529 to refactor the attach and detach services and their spec to be able work with the new UserCurve model. Notably - adjusting attach and detach causes the custom curves endpoint to break, which is reflected in the spec (currently failing for that endpoint).
Closes #1521, #1522, #1519, #1518, #1520, #1523, #1524
Edit: This PR supersedes #1529.