Skip to content

Conversation

@mirekdlugosz
Copy link
Contributor

@mirekdlugosz mirekdlugosz commented Nov 18, 2025

Add RHEL 10 and Centos 10 (do we need this?) to packit configuration. These targets are already enabled on copr side. Comments are added/modified to be consistent with quipucordsctl.

Relates to JIRA: DISCOVERY-972

Summary by Sourcery

Update packit configuration to add builds for RHEL 10 and CentOS Stream 10 and standardize comments in .packit.yaml

Build:

  • Add RHEL 10 x86_64 and aarch64 targets to copr_build in .packit.yaml
  • Add CentOS Stream 10 x86_64 and aarch64 targets to copr_build in .packit.yaml
  • Standardize RHEL casing in comments

@mirekdlugosz mirekdlugosz requested review from a team November 18, 2025 11:20
@sourcery-ai
Copy link

sourcery-ai bot commented Nov 18, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR extends the Packit CI configuration by updating comments for consistency and adding RHEL 10 and CentOS Stream 10 build targets to the existing .packit.yaml targets list.

File-Level Changes

Change Details Files
Updated comment casing for RHEL version support
  • Changed comment from “rhel-8 and rhel-9” to “RHEL 8 and RHEL 9” for consistency
.packit.yaml
Added RHEL 10 build targets
  • Added “- rhel-10-x86_64”
  • Added “- rhel-10-aarch64”
.packit.yaml
Added CentOS Stream 10 build targets
  • Added “- centos-stream-10-x86_64”
  • Added “- centos-stream-10-aarch64”
.packit.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.97%. Comparing base (049012a) to head (2dc0b34).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #388   +/-   ##
=======================================
  Coverage   95.97%   95.97%           
=======================================
  Files         118      118           
  Lines        7622     7622           
=======================================
  Hits         7315     7315           
  Misses        307      307           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@nicolearagao nicolearagao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when u say it's already enabled on COPR side, what do u mean ?

@mirekdlugosz
Copy link
Contributor Author

@nicolearagao In copr project you can go to Settings and select "chroots" for package. If I select chroots on copr side, they show up on project overview page (screenshot below), even if I never build any packages. I don't know what happens when you build packages for chroot with packit, but don't enable chroot on copr side. My impression is that these two lists should be in sync.

Screenshot From 2025-11-19 11-28-34

@mirekdlugosz mirekdlugosz merged commit 8431ce7 into main Nov 19, 2025
27 checks passed
@mirekdlugosz mirekdlugosz deleted the packit-rhel10 branch November 19, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants