add typing to mutagen.File
#695
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is needed for py.typed libraries because > Imported symbols are considered private by default. ref: https://github.com/microsoft/pyright/blob/main/docs/typed-libraries.md#library-interface fixes quodlibetgh-647
Member
|
I've merged #696 instead, since this included unrelated changes. Thanks! |
scratchmex
changed the title
mutagen.File
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is needed for py.typed libraries because
ref: https://github.com/microsoft/pyright/blob/main/docs/typed-libraries.md#library-interface
I tested locally and the types are detected ok
fixes gh-647
edit: this now only include the typing to the signature of
mutagen.Filewhich I previously added