HLLD solver: Fix pressure scaling for low-Mach flows#1372
Conversation
for more information, see https://pre-commit.ci
…m:quokka-astro/quokka into nkriel-fix-HLLD-low-Mach-pressure-scaling
for more information, see https://pre-commit.ci
|
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
for more information, see https://pre-commit.ci
…m:quokka-astro/quokka into nkriel-fix-HLLD-low-Mach-pressure-scaling
for more information, see https://pre-commit.ci
…m:quokka-astro/quokka into nkriel-fix-HLLD-low-Mach-pressure-scaling
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
AstroKriel
changed the title
AstroKriel
requested review from
BenWibking,
chongchonghe and
markkrumholz
as code owners
dosubot
Bot
added
the
size:L
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the HLLD Riemann solver to include a pressure correction for low-Mach number flows, based on the work of Minoshima & Miyoshi (2021). The changes in src/hydro/HLLD.hpp appear to correctly implement the new formulation for the intermediate state pressure. A new test problem, MHDBalsaraVortex, is added to verify the changes, which is a good practice. However, I've found a potential issue in the analytical solution of this new test problem where the velocity and magnetic field perturbations seem to be incorrectly scaled by vortex_radius. This could lead to an incorrect error norm calculation if vortex_radius is not equal to 1. My review includes a suggestion to fix this.
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
for more information, see https://pre-commit.ci
|
2 participants
Description
This PR updates the HLLD solver to apply the same low-Mach pressure correction already implemented in the HLLC solver.
Related issues
Fixes the remaining issues detailed in #528
Checklist
/azp run.