MHD Convergence tests#1434
Conversation
lizmcole
requested review from
BenWibking,
chongchonghe and
markkrumholz
as code owners
dosubot
Bot
added
the
size:L
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…thub.com/quokka-astro/quokka into lizmcole/Richardson-convergence-test-MHD
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…thub.com/quokka-astro/quokka into lizmcole/Richardson-convergence-test-MHD
for more information, see https://pre-commit.ci
…thub.com/quokka-astro/quokka into lizmcole/Richardson-convergence-test-MHD
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
I've deleted the input files I inadvertently committed when testing this PR. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Just FYI- It's not necessary to merge with development if the changes w.r.t. development are trivial. Those will get auto-merged in when the PR goes into the merge queue. It's only necessary to explicitly merge in development when there are merge conflicts. |
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
|
Looks like the MHD ASAN test is timing out. It may be necessary to reduce the problem size in the automated test to get this to run in a reasonable amount of time. |
In my view, it would be okay to exclude all but one of the MHD wave tests for the purpose of the ASAN test. Any given wave is likely to cover nearly all of the uninitialized value issues in the MHD solver. |
still includes the regular alfven wave problems in testing
Updated working directory and modified test command to exclude slow cases.
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
3 participants
Description
This adds convergence tests for the MHD problems FastWave and AlfvenWaveCircular. The Fast Wave now can operate at an angle. This also adds the SlowWave convergence test and the Entropy wave convergence test.
Related issues
Checklist
Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an
xinside the square brackets[ ]in the Markdown source below:/azp run.