Skip to content

Runtime BC control for both cc and fc variables #1516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chongchonghe merged 30 commits into from
Dec 25, 2025
Merged

Runtime BC control for both cc and fc variables #1516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
77c9b69
v1, working
chongchonghe Dec 15, 2025
f7fbead
clean
chongchonghe Dec 15, 2025
8c95d2a
add all missing BC typesd
chongchonghe Dec 15, 2025
8b97272
simpler method
chongchonghe Dec 15, 2025
2ca94f8
cleanup
chongchonghe Dec 15, 2025
66b3ac6
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 15, 2025
dd5287e
backward compatibility
chongchonghe Dec 16, 2025
eae759f
tidy
chongchonghe Dec 16, 2025
d11a3a2
remove all BCs_cc in problem cpp files
chongchonghe Dec 16, 2025
8e26ce3
refactor in
chongchonghe Dec 16, 2025
b8c5142
more in change
chongchonghe Dec 16, 2025
3a638f5
all problem files
chongchonghe Dec 16, 2025
08df6b1
all input files
chongchonghe Dec 16, 2025
732716f
MHD support reflecting
chongchonghe Dec 16, 2025
b47a322
tidy
chongchonghe Dec 16, 2025
d1f1bf5
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 16, 2025
37ad321
remove repetitions in all in files
chongchonghe Dec 16, 2025
802728d
Merge branch 'chong/BC/quokka-bc-v2' of https://github.com/quokka-ast…
chongchonghe Dec 16, 2025
fbd0d28
update more in files
chongchonghe Dec 16, 2025
e3360bc
add doc about `quokka.bc` for MHd
chongchonghe Dec 18, 2025
5040f1e
tidy
chongchonghe Dec 18, 2025
4c86b88
fix some Sonar warnings
chongchonghe Dec 18, 2025
f44ef19
update missed is_periodic
chongchonghe Dec 18, 2025
a65cc35
merge
chongchonghe Dec 18, 2025
6978a84
mroe infiles
chongchonghe Dec 18, 2025
c31eeef
revert __to_underlying
chongchonghe Dec 18, 2025
f30da46
Merge branch 'development' into chong/BC/quokka-bc-v2
chongchonghe Dec 21, 2025
0a44f92
sonar cloud
chongchonghe Dec 21, 2025
3d65cc0
correct mistakes in all radhydro_shell_xxx.in files
chongchonghe Dec 24, 2025
b9b2206
Merge branch 'development' into chong/BC/quokka-bc-v2
chongchonghe Dec 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/markdown/mhd_module.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,4 +126,4 @@ more detail in [Runtime parameters](parameters.md):
(default `Balsara2025`).
- `artificial_viscosity_k` – optional scalar viscosity coefficient that adds a
diffusive flux to the momentum equations and can damp post-shock oscillations.

- `quokka.bc` – (required) choose `periodic` or `reflecting` for the boundary conditions. For reflecting boundaries, we use `amrex::BCType::reflect_even` for all magnetic field components. Support for properly reflecting magnetic field boundaries will be added in the future.
2 changes: 1 addition & 1 deletion inputs/Advection.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# *****************************************************************
geometry.prob_lo = 0.0 0.0 0.0
geometry.prob_hi = 1.0 1.0 1.0
geometry.is_periodic = 1 1 1
quokka.bc = periodic periodic periodic

# *****************************************************************
# VERBOSITY
Expand Down
2 changes: 1 addition & 1 deletion inputs/Advection2D.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# *****************************************************************
geometry.prob_lo = 0.0 0.0 0.0
geometry.prob_hi = 1.0 1.0 1.0
geometry.is_periodic = 1 1 1
quokka.bc = periodic periodic periodic

# *****************************************************************
# VERBOSITY
Expand Down
2 changes: 1 addition & 1 deletion inputs/AdvectionSemiellipse.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# *****************************************************************
geometry.prob_lo = 0.0 0.0 0.0
geometry.prob_hi = 1.0 1.0 1.0
geometry.is_periodic = 1 1 1
quokka.bc = periodic periodic periodic

# *****************************************************************
# VERBOSITY
Expand Down
2 changes: 1 addition & 1 deletion inputs/AlfvenWaveCircular.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# *****************************************************************
geometry.prob_lo = 0.0 0.0 0.0
geometry.prob_hi = 1.0 1.0 1.0
geometry.is_periodic = 1 1 1
quokka.bc = periodic periodic periodic

# *****************************************************************
# VERBOSITY
Expand Down
2 changes: 1 addition & 1 deletion inputs/AlfvenWaveLinear.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# *****************************************************************
geometry.prob_lo = 0.0 0.0 0.0
geometry.prob_hi = 1.0 1.0 1.0
geometry.is_periodic = 1 1 1
quokka.bc = periodic periodic periodic

# *****************************************************************
# VERBOSITY
Expand Down
2 changes: 1 addition & 1 deletion inputs/BinaryOrbitAMR.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# *****************************************************************
geometry.prob_lo = -2.5e13 -2.5e13 -2.5e13
geometry.prob_hi = 2.5e13 2.5e13 2.5e13
Comment thread
markkrumholz marked this conversation as resolved.
geometry.is_periodic = 1 0 0
quokka.bc = periodic periodic reflecting

# *****************************************************************
# VERBOSITY
Expand Down
4 changes: 2 additions & 2 deletions inputs/BinaryOrbitCIC.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# *****************************************************************
geometry.prob_lo = -2.5e13 -2.5e13 -2.5e13
geometry.prob_hi = 2.5e13 2.5e13 2.5e13
geometry.is_periodic = 1 1 0
quokka.bc = periodic periodic reflecting

# *****************************************************************
# VERBOSITY
Expand All @@ -30,5 +30,5 @@ plotfile_interval = -1
tiny_profiler.enabled = 0

cfl = 0.3
max_timesteps = 2000
max_timesteps = 20
stop_time = 5.0e7 # s
2 changes: 1 addition & 1 deletion inputs/BinaryOrbit_refactor.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# *****************************************************************
geometry.prob_lo = -2.5e13 -2.5e13 -2.5e13
geometry.prob_hi = 2.5e13 2.5e13 2.5e13
geometry.is_periodic = 1 1 1
quokka.bc = periodic periodic periodic

# *****************************************************************
# VERBOSITY
Expand Down
2 changes: 1 addition & 1 deletion inputs/BinaryOrbit_refactor_init.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# *****************************************************************
geometry.prob_lo = -2.5e13 -2.5e13 -2.5e13
geometry.prob_hi = 2.5e13 2.5e13 2.5e13
geometry.is_periodic = 1 1 1
quokka.bc = periodic periodic periodic

# *****************************************************************
# VERBOSITY
Expand Down
2 changes: 1 addition & 1 deletion inputs/BinaryOrbit_refactor_splitparticle.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# *****************************************************************
geometry.prob_lo = -2.5e13 -2.5e13 -2.5e13
geometry.prob_hi = 2.5e13 2.5e13 2.5e13
geometry.is_periodic = 1 1 1
quokka.bc = periodic periodic periodic

# *****************************************************************
# VERBOSITY
Expand Down
2 changes: 1 addition & 1 deletion inputs/BinaryOrbit_split.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# *****************************************************************
geometry.prob_lo = -2.5e13 -2.5e13 -2.5e13
geometry.prob_hi = 2.5e13 2.5e13 2.5e13
geometry.is_periodic = 1 1 1
quokka.bc = periodic periodic periodic

# *****************************************************************
# VERBOSITY
Expand Down
2 changes: 1 addition & 1 deletion inputs/BrioWuShockTube.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# *****************************************************************
geometry.prob_lo = 0.0 0.0 0.0
geometry.prob_hi = 1.0 1.0 1.0
geometry.is_periodic = 0 1 1
quokka.bc = ext_dir periodic periodic

# *****************************************************************
# VERBOSITY
Expand Down
2 changes: 1 addition & 1 deletion inputs/CurrentSheet.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# *****************************************************************
geometry.prob_lo = -0.5 -0.5 -0.5
geometry.prob_hi = 0.5 0.5 0.5
geometry.is_periodic = 1 1 1
quokka.bc = periodic periodic periodic

# *****************************************************************
# VERBOSITY
Expand Down
2 changes: 1 addition & 1 deletion inputs/DiskGalaxy.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# Box size is [-600 kpc, 600 kpc]^3
geometry.prob_lo = -1.8514065526075864e24 -1.8514065526075864e24 -1.8514065526075864e24
geometry.prob_hi = 1.8514065526075864e24 1.8514065526075864e24 1.8514065526075864e24
geometry.is_periodic = 0 0 0
quokka.bc = reflecting reflecting reflecting

# *****************************************************************
# VERBOSITY
Expand Down
2 changes: 1 addition & 1 deletion inputs/DustDamping.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# *****************************************************************
geometry.prob_lo = 0.0 0.0 0.0
geometry.prob_hi = 1.0 1.0 1.0
geometry.is_periodic = 1 1 1
quokka.bc = periodic periodic periodic

# *****************************************************************
# VERBOSITY
Expand Down
2 changes: 1 addition & 1 deletion inputs/DustDrag.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# *****************************************************************
geometry.prob_lo = 0.0 0.0 0.0
geometry.prob_hi = 1.0 1.0 1.0
geometry.is_periodic = 1 1 1
quokka.bc = periodic periodic periodic

# *****************************************************************
# VERBOSITY
Expand Down
2 changes: 1 addition & 1 deletion inputs/DustDrag3D.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# *****************************************************************
geometry.prob_lo = 0.0 0.0 0.0
geometry.prob_hi = 1.0 1.0 1.0
geometry.is_periodic = 1 1 1
quokka.bc = periodic periodic periodic

# *****************************************************************
# VERBOSITY
Expand Down
2 changes: 1 addition & 1 deletion inputs/DustSoundwave.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# *****************************************************************
geometry.prob_lo = 0.0 0.0 0.0
geometry.prob_hi = 1.0 1.0 1.0
geometry.is_periodic = 1 1 1
quokka.bc = periodic periodic periodic

# *****************************************************************
# VERBOSITY
Expand Down
2 changes: 1 addition & 1 deletion inputs/FCQuantities.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# *****************************************************************
geometry.prob_lo = 0.0 0.0 0.0
geometry.prob_hi = 1.0 1.0 1.0
geometry.is_periodic = 1 1 1
quokka.bc = periodic periodic periodic

# *****************************************************************
# VERBOSITY
Expand Down
2 changes: 1 addition & 1 deletion inputs/FastWave.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# *****************************************************************
geometry.prob_lo = 0.0 0.0 0.0
geometry.prob_hi = 1.0 1.0 1.0
geometry.is_periodic = 1 1 1
quokka.bc = periodic periodic periodic

# *****************************************************************
# VERBOSITY
Expand Down
2 changes: 1 addition & 1 deletion inputs/FieldLoop.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# *****************************************************************
geometry.prob_lo = -1.0 -0.578125 -1.0
geometry.prob_hi = 1.0 0.578125 1.0
geometry.is_periodic = 1 1 1
quokka.bc = periodic periodic periodic

# *****************************************************************
# VERBOSITY
Expand Down
2 changes: 1 addition & 1 deletion inputs/GravRadParticle3D.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# *****************************************************************
geometry.prob_lo = -2.0 -2.0 -2.0
geometry.prob_hi = 2.0 2.0 2.0
geometry.is_periodic = 0 0 0
quokka.bc = reflecting reflecting reflecting

# *****************************************************************
# VERBOSITY
Expand Down
2 changes: 1 addition & 1 deletion inputs/HighMach_reference.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# *****************************************************************
geometry.prob_lo = 0.0 0.0 0.0
geometry.prob_hi = 1.0 1.0 1.0
geometry.is_periodic = 1 1 1
quokka.bc = periodic periodic periodic

# *****************************************************************
# VERBOSITY
Expand Down
2 changes: 1 addition & 1 deletion inputs/blast2d.in → inputs/HydroBlast2D.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# *****************************************************************
geometry.prob_lo = 0.0 0.0 0.0
geometry.prob_hi = 1.0 1.0 1.0
geometry.is_periodic = 0 0 0
quokka.bc = reflecting reflecting reflecting

# *****************************************************************
# VERBOSITY
Expand Down
2 changes: 1 addition & 1 deletion inputs/blast_unigrid_128.in → inputs/HydroBlast3D.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# *****************************************************************
geometry.prob_lo = 0.0 0.0 0.0
geometry.prob_hi = 1.2 1.2 1.2
geometry.is_periodic = 0 0 0
quokka.bc = reflecting reflecting reflecting

# *****************************************************************
# VERBOSITY
Expand Down
2 changes: 1 addition & 1 deletion inputs/HydroContact.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# *****************************************************************
geometry.prob_lo = 0.0 0.0 0.0
geometry.prob_hi = 1.0 1.0 1.0
geometry.is_periodic = 1 1 1
quokka.bc = periodic periodic periodic

# *****************************************************************
# VERBOSITY
Expand Down
2 changes: 1 addition & 1 deletion inputs/HydroHighMach.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# *****************************************************************
geometry.prob_lo = 0.0 0.0 0.0
geometry.prob_hi = 1.0 1.0 1.0
geometry.is_periodic = 1 1 1
quokka.bc = periodic periodic periodic

# *****************************************************************
# VERBOSITY
Expand Down
2 changes: 1 addition & 1 deletion inputs/HydroLeblanc.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# *****************************************************************
geometry.prob_lo = 0.0 0.0 0.0
geometry.prob_hi = 9.0 1.0 1.0
geometry.is_periodic = 0 1 1
quokka.bc = foextrap periodic periodic

# *****************************************************************
# VERBOSITY
Expand Down
2 changes: 1 addition & 1 deletion inputs/HydroQuirk.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# *****************************************************************
geometry.prob_lo = 0.0 0.0 0.0
geometry.prob_hi = 1.0 0.125 1.0
geometry.is_periodic = 0 1 1
quokka.bc = ext_dir periodic periodic

# *****************************************************************
# VERBOSITY
Expand Down
2 changes: 1 addition & 1 deletion inputs/HydroSMS.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# *****************************************************************
geometry.prob_lo = 0.0 0.0 0.0
geometry.prob_hi = 1.0 1.0 1.0
geometry.is_periodic = 0 1 1
quokka.bc = ext_dir periodic periodic

# *****************************************************************
# VERBOSITY
Expand Down
2 changes: 1 addition & 1 deletion inputs/HydroShocktube.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# *****************************************************************
geometry.prob_lo = 0.0 0.0 0.0
geometry.prob_hi = 5.0 1.0 1.0
geometry.is_periodic = 0 1 1
quokka.bc = ext_dir periodic periodic

# *****************************************************************
# VERBOSITY
Expand Down
2 changes: 1 addition & 1 deletion inputs/HydroShocktubeCMA.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# *****************************************************************
geometry.prob_lo = 0.0 0.0 0.0
geometry.prob_hi = 1.0 1.0 1.0
geometry.is_periodic = 0 1 1
quokka.bc = ext_dir periodic periodic

# *****************************************************************
# VERBOSITY
Expand Down
2 changes: 1 addition & 1 deletion inputs/HydroVacuum.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# *****************************************************************
geometry.prob_lo = 0.0 0.0 0.0
geometry.prob_hi = 1.0 1.0 1.0
geometry.is_periodic = 0 1 1
quokka.bc = ext_dir periodic periodic

# *****************************************************************
# VERBOSITY
Expand Down
2 changes: 1 addition & 1 deletion inputs/HydroWave.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# *****************************************************************
geometry.prob_lo = 0.0 0.0 0.0
geometry.prob_hi = 1.0 1.0 1.0
geometry.is_periodic = 1 1 1
quokka.bc = periodic periodic periodic

# *****************************************************************
# VERBOSITY
Expand Down
2 changes: 1 addition & 1 deletion inputs/HydroWaveFc.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# *****************************************************************
geometry.prob_lo = 0.0 0.0 0.0
geometry.prob_hi = 1.0 1.0 1.0
geometry.is_periodic = 1 1 1
quokka.bc = periodic periodic periodic

# *****************************************************************
# VERBOSITY
Expand Down
2 changes: 1 addition & 1 deletion inputs/KelvinHelmholz.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# *****************************************************************
geometry.prob_lo = 0.0 0.0 0.0
geometry.prob_hi = 1.0 1.0 1.0
geometry.is_periodic = 1 1 1
quokka.bc = periodic periodic periodic

# *****************************************************************
# VERBOSITY
Expand Down
2 changes: 1 addition & 1 deletion inputs/KelvinHelmholz_512.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# *****************************************************************
geometry.prob_lo = 0.0 0.0 0.0
geometry.prob_hi = 1.0 1.0 1.0
geometry.is_periodic = 1 1 1
quokka.bc = periodic periodic periodic

# *****************************************************************
# VERBOSITY
Expand Down
2 changes: 1 addition & 1 deletion inputs/KelvinHelmholz_tracer.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# *****************************************************************
geometry.prob_lo = 0.0 0.0 0.0
geometry.prob_hi = 1.0 1.0 1.0
geometry.is_periodic = 1 1 1
quokka.bc = periodic periodic periodic

# *****************************************************************
# VERBOSITY
Expand Down
2 changes: 1 addition & 1 deletion inputs/MHDBitwiseICs.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# *****************************************************************
geometry.prob_lo = 0.0 0.0 0.0
geometry.prob_hi = 1.0 1.0 1.0
geometry.is_periodic = 1 1 1
quokka.bc = periodic periodic periodic

# *****************************************************************
# VERBOSITY
Expand Down
2 changes: 1 addition & 1 deletion inputs/MHDBlast.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# *****************************************************************
geometry.prob_lo = -0.5 -0.5 -0.5
geometry.prob_hi = 0.5 0.5 0.5
geometry.is_periodic = 1 1 1
quokka.bc = periodic periodic periodic

# *****************************************************************
# VERBOSITY
Expand Down
2 changes: 1 addition & 1 deletion inputs/NscbcChannel.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# *****************************************************************
geometry.prob_lo = 0.0 0.0 0.0
geometry.prob_hi = 100.0 12.5 12.5
geometry.is_periodic = 0 1 1
quokka.bc = ext_dir periodic periodic

# *****************************************************************
# VERBOSITY
Expand Down
2 changes: 1 addition & 1 deletion inputs/OrszagTang.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# *****************************************************************
geometry.prob_lo = -0.5 -0.5 -0.5
geometry.prob_hi = 0.5 0.5 0.5
geometry.is_periodic = 1 1 1
quokka.bc = periodic periodic periodic

# *****************************************************************
# VERBOSITY
Expand Down
2 changes: 1 addition & 1 deletion inputs/ParticleAccretion.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# box size: (-7.7696 pc, 7.7696 pc)
geometry.prob_lo = -9.590075420e+19 -9.590075420e+19 -9.590075420e+19
geometry.prob_hi = 9.590075420e+19 9.590075420e+19 9.590075420e+19
geometry.is_periodic = 0 0 0
quokka.bc = reflecting reflecting reflecting

# *****************************************************************
# VERBOSITY
Expand Down
Loading
Loading