[URGENT] Update turbulence submodule with a bug fix

[chongchonghe]

Description

Update turbulence submodule with fix to an MPI bug: chfeder/turbulence_generator#2

Checklist

Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an x inside the square brackets [ ] in the Markdown source below:

• I have added a description (see above).
• I have added a link to any related issues (if applicable; see above).
• I have read the Contributing Guide.
• I have added tests for any new physics that this PR adds to the code.
• (For quokka-astro org members) I have manually triggered the GPU tests with the magic comment /azp run.

[gemini-code-assist]

Summary of Changes

Hello @chongchonghe, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request urgently updates the turbulence submodule to integrate a critical MPI bug fix. The change ensures that the project benefits from enhanced stability and correct behavior, particularly in parallel computing scenarios that rely on the turbulence component.

Highlights

• Submodule Update: The turbulence submodule has been updated to a newer commit 4b726bb6c6ea2ab3daa7fd0711a4504c3c0ad5cf.
• MPI Bug Fix: This submodule update specifically incorporates a fix for an MPI-related bug, as referenced in the upstream turbulence_generator pull request.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the turbulence submodule to a new commit. The description indicates this is to incorporate a fix for an MPI bug. The change is limited to updating the submodule's commit hash, with no other code changes in this repository. This suggests the update is API-compatible and should be a safe bug fix. Assuming the new submodule commit is from a stable source and has been tested, this change is appropriate.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[chongchonghe]

@BenWibking Have you seen this kind of error? It seems to be a github workflow system issue.

E: Failed to fetch store:/var/lib/apt/lists/partial/ports.ubuntu.com_ubuntu-ports_dists_noble-updates_universe_dep11_Components-arm64.yml.xz Hash Sum mismatch

[chongchonghe]

Seems like a github server fail. I think we can bypass it for this PR.