Skip to content

Add check_changes in diskgalaxy workflow#1558

Merged
chongchonghe merged 1 commit into
developmentfrom
chong/logi/check-diskgalaxy
Jan 4, 2026
Merged

Add check_changes in diskgalaxy workflow#1558
chongchonghe merged 1 commit into
developmentfrom
chong/logi/check-diskgalaxy

Conversation

@chongchonghe

Copy link
Copy Markdown
Contributor

Description

DiskGalaxy workflow is preventing a trivial PR from passing all tests immediately. This PR fixes it.

Checklist

Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an x inside the square brackets [ ] in the Markdown source below:

  • I have added a description (see above).
  • I have added a link to any related issues (if applicable; see above).
  • I have read the Contributing Guide.
  • I have added tests for any new physics that this PR adds to the code.
  • (For quokka-astro org members) I have manually triggered the GPU tests with the magic comment /azp run.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. github_actions Pull requests that update GitHub Actions code labels Jan 4, 2026
@sonarqubecloud

sonarqubecloud Bot commented Jan 4, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jan 4, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c7753bbf00

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/rocm-diskgalaxy-container.yml
@chongchonghe chongchonghe enabled auto-merge January 4, 2026 04:38
@chongchonghe chongchonghe added this pull request to the merge queue Jan 4, 2026
Merged via the queue into development with commit 1852bc6 Jan 4, 2026
53 of 54 checks passed
@chongchonghe chongchonghe deleted the chong/logi/check-diskgalaxy branch January 4, 2026 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants