Add a Makefile in tests/

[chongchonghe]

Description

Add a Makefile in tests/ to config, build, and run test problems with a single short command:

JOB=<JobName> make b     # build
JOB=<JobName> make r     # run

You can also do export JOB=<JobName> once in a shell, and subsequent make b and make r will build and run <JobName>

Coding agent integration

This Makefile workflow integrates very well with coding agents like Claude Code. You simply prompt claude to "Validate your implementation with the XXX test problem. Read @tests/Makefile to learn how to validate a test problem"

Checklist

Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an x inside the square brackets [ ] in the Markdown source below:

• I have added a description (see above).
• I have added a link to any related issues (if applicable; see above).
• I have read the Contributing Guide.
• I have added tests for any new physics that this PR adds to the code.
• (For quokka-astro org members) I have manually triggered the GPU tests with the magic comment /azp run.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

[gemini-code-assist]

Summary of Changes

Hello @chongchonghe, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new Makefile within the tests/ directory to standardize and simplify the workflow for configuring, building, and executing test problems. This enhancement aims to improve developer efficiency by providing concise commands for common testing tasks and facilitates integration with AI coding agents for automated validation.

Highlights

• New Makefile for Test Automation: A new Makefile has been added to the tests/ directory to streamline the process of configuring, building, and running test problems.
• Simplified Test Workflow: Developers can now use JOB=<JobName> make b to build a specific test problem and JOB=<JobName> make r to run it, significantly simplifying the testing procedure.
• Coding Agent Integration: The Makefile is designed to integrate seamlessly with coding agents, allowing them to easily validate implementations against specific test problems.
• Build Configuration and Cleanup: The Makefile includes targets for initial CMake configuration (make config), cleaning runtime output files (make clean), and resetting the tests/ directory to a clean state (make fullclean).

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• tests/Makefile
  • Added a new Makefile to the tests/ directory.
  • Included targets for config, b (build), r (run), br (build and run), clean, and fullclean.
  • Defined default variables for job name, dimensions, number of processors, and build arguments.
  • Provided instructions and examples for using the Makefile, including an agent workflow.

Activity

• No specific activity (comments, reviews, progress) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a Makefile to simplify building and running tests, which is a valuable addition to the developer workflow. My review has identified several issues, including a critical one in the fullclean target that could lead to data loss, and a bug in the clean target that prevents it from working. I have also provided a number of suggestions to enhance the Makefile's portability, correctness, and overall usability.