Skip to content

[DO NOT MERGE] AI code audit results#1676

Draft
BenWibking wants to merge 5 commits intodevelopmentfrom
BenWibking/code-audit
Draft

[DO NOT MERGE] AI code audit results#1676
BenWibking wants to merge 5 commits intodevelopmentfrom
BenWibking/code-audit

Conversation

@BenWibking
Copy link
Collaborator

@BenWibking BenWibking commented Feb 24, 2026

Description

These are the candidate issues identified by a semi-automated code audit run with Codex.

A summary of the issues ordered by severity is here:
https://github.com/quokka-astro/quokka/issues?q=is%3Aissue%20state%3Aopen%20label%3Acode-audit

Prompt:

Audit the code in src/ for bugs. You should try to understand how all of the code works by reading the documentation in docs/. (Ignore anything in paper/.) You should examine every function and every class in every C++ source file. Keep going until you've completed a thorough audit. Keep track of your results for each function in a Markdown log as you go.

Related issues

N/A

Checklist

Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an x inside the square brackets [ ] in the Markdown source below:

  • I have added a description (see above).
  • I have added a link to any related issues (if applicable; see above).
  • I have read the Contributing Guide.
  • I have added tests for any new physics that this PR adds to the code.
  • (For quokka-astro org members) I have manually triggered the GPU tests with the magic comment /azp run.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @BenWibking, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a comprehensive set of markdown files detailing candidate issues identified through a semi-automated code audit. The findings cover a wide range of potential problems, from numerical robustness and correctness bugs to portability limitations and resource management concerns. The primary purpose is to document these issues for review and subsequent remediation, aiming to improve the overall stability, accuracy, and maintainability of the codebase.

Highlights

  • Robustness Issues Identified: Numerous instances of potential division by zero, NaN propagation, and other numerical instabilities were found across various functions, particularly in timestep calculations, signal speed computations, and density-dependent operations. Several checks for NaN values were also found to be ineffective due to IEEE arithmetic behavior.
  • Correctness and Logic Errors: Several logic flaws were identified, including incorrect checkpoint scheduling, improper boundary condition array construction, uninitialized state variables after level remaking, and inconsistencies in boundary condition application for face-centered variables. Specific issues were found in the calculation of absolute tolerances, particle splitting logic, and diagnostic output mechanisms.
  • Portability Concerns for Multi-Dimensional Builds: A significant number of functions were found to contain hard-coded 3D indexing or loops, making them unsafe and prone to out-of-bounds access when compiled for 1D or 2D simulations. This affects MHD calculations, signal speed computations, and various problem-specific initial condition and refinement routines.
  • Resource Leaks and Memory Safety: A few resource management issues were noted, including an unclosed HDF5 dataspace handle and Python reference leaks in the matplotlibcpp utility, which could lead to memory corruption or resource exhaustion over long runs.
  • Test Validity and Diagnostics Hygiene: Problems were found in test cases where error norms used one-sided differences, potentially masking underpredictions, or where diagnostic output was either incorrect, incomplete, or contained leftover debug code.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • audit/issues/core/001-amrsimulation-computetimestepatlevel-int-simulation-hpp.md
    • Added a new audit issue report.
  • audit/issues/core/002-amrsimulation-evolve-simulation-hpp.md
    • Added a new audit issue report.
  • audit/issues/core/003-amrsimulation-evolve-simulation-hpp.md
    • Added a new audit issue report.
  • audit/issues/core/004-amrsimulation-calculategpotalllevels-simulation-hpp.md
    • Added a new audit issue report.
  • audit/issues/core/005-amrsimulation-makenewlevelfromcoarse-simulation-hpp.md
    • Added a new audit issue report.
  • audit/issues/core/006-amrsimulation-remakelevel-simulation-hpp.md
    • Added a new audit issue report.
  • audit/issues/core/007-amrsimulation-remakelevel-simulation-hpp.md
    • Added a new audit issue report.
  • audit/issues/core/008-amrsimulation-setdiodebclo-simulation-hpp.md
    • Added a new audit issue report.
  • audit/issues/core/009-amrsimulation-setdiodebchi-simulation-hpp.md
    • Added a new audit issue report.
  • audit/issues/core/010-amrsimulation-fillcoarsepatch-simulation-hpp.md
    • Added a new audit issue report.
  • audit/issues/core/011-amrsimulation-readmetadatafile-simulation-hpp.md
    • Added a new audit issue report.
  • audit/issues/core/012-amrsimulation-readcheckpointheader-simulation-hpp.md
    • Added a new audit issue report.
  • audit/issues/core/013-quokkasimulation-computenumberofradiationsubsteps-int-real-quokkasim.md
    • Added a new audit issue report.
  • audit/issues/core/014-quokkasimulation-iscflviolated-quokkasimulation-hpp.md
    • Added a new audit issue report.
  • audit/issues/core/015-quokkasimulation-advancehydroatlevel-quokkasimulation-hpp.md
    • Added a new audit issue report.
  • audit/issues/core/016-quokkasimulation-computemaxsignallocal-int-quokkasimulation-hpp.md
    • Added a new audit issue report.
  • audit/issues/core/017-quokkasimulation-replaceemfs-quokkasimulation-hpp.md
    • Added a new audit issue report.
  • audit/issues/core/018-hydrosystem-computemaxsignalspeed-hydro-system-hpp.md
    • Added a new audit issue report.
  • audit/issues/core/019-hydrosystem-computemagneticenergy-hydro-system-hpp.md
    • Added a new audit issue report.
  • audit/issues/core/020-hydrosystem-computefluxes-hydro-system-hpp.md
    • Added a new audit issue report.
  • audit/issues/core/021-mhdsystem-computeemf-felkerstone2017-mhd-system-hpp.md
    • Added a new audit issue report.
  • audit/issues/core/022-mhdsystem-computeemf-quokka2026-mhd-system-hpp.md
    • Added a new audit issue report.
  • audit/issues/core/023-mhdsystem-computeemf-balsara2025-mhd-system-hpp.md
    • Added a new audit issue report.
  • audit/issues/core/024-mhdsystem-solveinductioneqn-mhd-system-hpp.md
    • Added a new audit issue report.
  • audit/issues/core/025-radsystem-amendradstate-radiation-system-hpp.md
    • Added a new audit issue report.
  • audit/issues/core/026-radsystem-computecellopticaldepth-dir-radiation-system-hpp.md
    • Added a new audit issue report.
  • audit/issues/core/027-radsystem-computeradpressure-dir-radiation-system-hpp.md
    • Added a new audit issue report.
  • audit/issues/core/028-radsystem-computedusttemperaturebateketo-radiation-system-hpp.md
    • Added a new audit issue report.
  • audit/issues/core/029-radsystem-addsourcetermssinglegroup-source-terms-single-group-hpp.md
    • Added a new audit issue report.
  • audit/issues/core/030-quokka-particleparmparse-particle-types-hpp.md
    • Added a new audit issue report.
  • audit/issues/core/031-snfeedbackutils-depositthermalkineticmomentumsnr-particle-deposition.md
    • Added a new audit issue report.
  • audit/issues/core/032-snfeedbackutils-addcompositebuffertostate-particle-deposition-hpp.md
    • Added a new audit issue report.
  • audit/issues/core/033-physicsparticledescriptor-splitparticles-physicsparticles-hpp.md
    • Added a new audit issue report.
  • audit/issues/core/034-physicsparticleregister-readsfh-physicsparticles-hpp.md
    • Added a new audit issue report.
  • audit/issues/core/035-read-dataset-turbdatareader-cpp.md
    • Added a new audit issue report.
  • audit/issues/core/036-read-dataset-turbdatareader-cpp.md
    • Added a new audit issue report.
  • audit/issues/core/037-computerms-turbdatareader-cpp.md
    • Added a new audit issue report.
  • audit/issues/core/038-quokka-turbulence-turbulentdriving-problem-t-applydriving-turbulentd.md
    • Added a new audit issue report.
  • audit/issues/core/039-quokka-turbulence-turbulentdriving-problem-t-applydriving-turbulentd.md
    • Added a new audit issue report.
  • audit/issues/core/040-quokka-turbulence-calculate-dispersion-problem-t-turbulentdriving-hp.md
    • Added a new audit issue report.
  • audit/issues/core/041-particle-io-saveparticledatatotxtfile-containertype-particle-io-hpp.md
    • Added a new audit issue report.
  • audit/issues/core/042-sinkaccretionutils-compute-mdot-and-r-k-problem-t-particle-accretion.md
    • Added a new audit issue report.
  • audit/issues/core/043-sinkaccretionutils-computeaccretionrateinbox-particle-accretion-hpp.md
    • Added a new audit issue report.
  • audit/issues/core/044-sinkaccretionutils-computescaledown-problem-t-particle-accretion-hpp.md
    • Added a new audit issue report.
  • audit/issues/core/045-sinkaccretionutils-updateparticlemassandmomentuminbox-particle-accre.md
    • Added a new audit issue report.
  • audit/issues/core/046-particlecreationtraits-particletype-stochasticstellarpop-particlecre.md
    • Added a new audit issue report.
  • audit/issues/core/047-advectionsimulation-computemaxsignallocal-int-advectionsimulation-hp.md
    • Added a new audit issue report.
  • audit/issues/core/048-advectionsimulation-computeafterevolve-advectionsimulation-hpp.md
    • Added a new audit issue report.
  • audit/issues/core/049-diagbase-prepare-diagbase-cpp.md
    • Added a new audit issue report.
  • audit/issues/core/050-diagparticletxt-processdiag-problem-t-diagparticletxt-h.md
    • Added a new audit issue report.
  • audit/issues/core/051-diagplotfile-processdiag-problem-t-diagplotfile-h.md
    • Added a new audit issue report.
  • audit/issues/core/052-diagframeplane-init-diagframeplane-cpp.md
    • Added a new audit issue report.
  • audit/issues/core/053-strided-vector-from-arrayutil-hpp.md
    • Added a new audit issue report.
  • audit/issues/core/054-quokka-datatablegpuconst-ndim-nout-oob-policy-find-interpolation-dat.md
    • Added a new audit issue report.
  • audit/issues/core/055-quokka-datatable-initialize-common-datatable-hpp.md
    • Added a new audit issue report.
  • audit/issues/core/056-matplotlibcpp-get-array-const-std-vector-numeric-matplotlibcpp-h.md
    • Added a new audit issue report.
  • audit/issues/core/057-matplotlibcpp-xlim-matplotlibcpp-h.md
    • Added a new audit issue report.
  • audit/issues/core/058-matplotlibcpp-ylim-matplotlibcpp-h.md
    • Added a new audit issue report.
  • audit/issues/core/059-matplotlibcpp-subplot2grid-matplotlibcpp-h.md
    • Added a new audit issue report.
  • audit/issues/core/060-matplotlibcpp-plot-matplotlibcpp-h.md
    • Added a new audit issue report.
  • audit/issues/core/061-matplotlibcpp-plot-update-matplotlibcpp-h.md
    • Added a new audit issue report.
  • audit/issues/core/062-matplotlibcpp-plot-remove-matplotlibcpp-h.md
    • Added a new audit issue report.
  • audit/issues/core/063-interpolate2d-interpolate2d-hpp.md
    • Added a new audit issue report.
  • audit/issues/core/064-error-norm-odeintegrate-hpp.md
    • Added a new audit issue report.
  • audit/issues/core/065-rk-adaptive-integrate-odeintegrate-hpp.md
    • Added a new audit issue report.
  • audit/issues/core/066-quokka-peheatingfromsfh-photoelectricheating-hpp.md
    • Added a new audit issue report.
  • audit/issues/core/067-quokka-resampledcooling-resampled-cooling-function-resampledcooling.md
    • Added a new audit issue report.
  • audit/issues/core/068-quokka-chemistry-computechemistry-problem-t-chemistry-hpp.md
    • Added a new audit issue report.
  • audit/issues/core/146-nscbc-detail-transverse-xdir-dq-data-nscbc-outflow-hpp.md
    • Added a new audit issue report.
  • audit/issues/core/147-nscbc-setoutflowboundaryloworder-nscbc-outflow-hpp.md
    • Added a new audit issue report.
  • audit/issues/problems/069-problem-main-testresampledcoolingtest-cpp.md
    • Added a new audit issue report.
  • audit/issues/problems/070-quokkasimulation-primordialchemtest-setinitialconditionsongrid-testp.md
    • Added a new audit issue report.
  • audit/issues/problems/071-amrsimulation-shocktubeproblem-setcustomboundaryconditions-testhydro.md
    • Added a new audit issue report.
  • audit/issues/problems/072-quokkasimulation-contactproblem-computereferencesolution-testhydroco.md
    • Added a new audit issue report.
  • audit/issues/problems/073-quokkasimulation-blastproblem-setinitialconditionsongrid-testhydrobl.md
    • Added a new audit issue report.
  • audit/issues/problems/074-quokkasimulation-sedovproblem-setinitialconditionsongrid-testhydrobl.md
    • Added a new audit issue report.
  • audit/issues/problems/075-problem-main-testhydroleblanc-cpp.md
    • Added a new audit issue report.
  • audit/issues/problems/076-problem-main-testhydroshuosher-cpp.md
    • Added a new audit issue report.
  • audit/issues/problems/077-quokkasimulation-quirkproblem-computeaftertimestep-testhydroquirk-cp.md
    • Added a new audit issue report.
  • audit/issues/problems/078-quokkasimulation-mhdshocktubeproblem-setinitialconditionsongridfacev.md
    • Added a new audit issue report.
  • audit/issues/problems/079-problem-main-testcurrentsheet-cpp.md
    • Added a new audit issue report.
  • audit/issues/problems/080-quokkasimulation-fieldloop-setinitialconditionsongrid-testfieldloop.md
    • Added a new audit issue report.
  • audit/issues/problems/081-quokkasimulation-fieldloop-refinegrid-testfieldloop-cpp.md
    • Added a new audit issue report.
  • audit/issues/problems/082-quokkasimulation-mhdquirk-computeaftertimestep-testmhdquirk-cpp.md
    • Added a new audit issue report.
  • audit/issues/problems/083-computewavesolution-testmhdbitwiseics-cpp.md
    • Added a new audit issue report.
  • audit/issues/problems/084-problem-main-testmhdbalsaravortex-cpp.md
    • Added a new audit issue report.
  • audit/issues/problems/085-problem-main-testrandomblast-cpp.md
    • Added a new audit issue report.
  • audit/issues/problems/086-quokkasimulation-shockcloud-computeaftertimestep-testshockcloud-cpp.md
    • Added a new audit issue report.
  • audit/issues/problems/087-quokkasimulation-shockcloud-computederivedvar-testshockcloud-cpp.md
    • Added a new audit issue report.
  • audit/issues/problems/088-quokkasimulation-shockcloud-computestatistics-testshockcloud-cpp.md
    • Added a new audit issue report.
  • audit/issues/problems/089-problem-main-testshockcloud-cpp.md
    • Added a new audit issue report.
  • audit/issues/problems/090-computewavesolution-testalfvenwavelinear-cpp.md
    • Added a new audit issue report.
  • audit/issues/problems/091-computewavesolution-testalfvenwavelinearconvergence-cpp.md
    • Added a new audit issue report.
  • audit/issues/problems/092-runwavetest-int-testalfvenwavelinearconvergence-cpp.md
    • Added a new audit issue report.
  • audit/issues/problems/093-computewavesolution-testentropywaveconvergence-cpp.md
    • Added a new audit issue report.
  • audit/issues/problems/094-computewavesolution-testfastwaveconvergence-cpp.md
    • Added a new audit issue report.
  • audit/issues/problems/095-computewavesolution-testslowwaveconvergence-cpp.md
    • Added a new audit issue report.
  • audit/issues/problems/096-runwavetest-int-testslowwaveconvergence-cpp.md
    • Added a new audit issue report.
  • audit/issues/problems/097-problem-main-testnscbcchannel-cpp.md
    • Added a new audit issue report.
  • audit/issues/problems/098-problem-main-testnscbcchannel-cpp.md
    • Added a new audit issue report.
  • audit/issues/problems/099-quokkasimulation-dustadvection-setinitialconditionsongrid-testdustad.md
    • Added a new audit issue report.
  • audit/issues/problems/100-quokkasimulation-dustadvection3d-setinitialconditionsongrid-testdust.md
    • Added a new audit issue report.
  • audit/issues/problems/101-quokkasimulation-dustsoundwave-setinitialconditionsongrid-testdustso.md
    • Added a new audit issue report.
  • audit/issues/problems/102-quokkasimulation-dustyshock-setinitialconditionsongrid-testdustyshoc.md
    • Added a new audit issue report.
  • audit/issues/problems/103-particlechecker-operator-testparticlecreation-cpp.md
    • Added a new audit issue report.
  • audit/issues/problems/104-particlecreator-operator-testparticlecreation-cpp.md
    • Added a new audit issue report.
  • audit/issues/problems/105-quokkasimulation-particlesfproblem-computeaftertimestep-testparticle.md
    • Added a new audit issue report.
  • audit/issues/problems/106-quokkasimulation-particlesfproblem-computeaftertimestep-testparticle.md
    • Added a new audit issue report.
  • audit/issues/problems/107-quokkasimulation-particlesfproblem-computeaftertimestep-testparticle.md
    • Added a new audit issue report.
  • audit/issues/problems/108-problem-main-testparticlesf-cpp.md
    • Added a new audit issue report.
  • audit/issues/problems/109-quokkasimulation-sinkproblem-refinegrid-testparticlesink-cpp.md
    • Added a new audit issue report.
  • audit/issues/problems/110-problem-main-testparticlesink-cpp.md
    • Added a new audit issue report.
  • audit/issues/problems/111-quokkasimulation-sinkproblem-setinitialconditionsongrid-testparticle.md
    • Added a new audit issue report.
  • audit/issues/problems/112-amrsimulation-beamproblem-setcustomboundaryconditions-testradbeam-cp.md
    • Added a new audit issue report.
  • audit/issues/problems/113-quokkasimulation-beamproblem-refinegrid-testradbeam-cpp.md
    • Added a new audit issue report.
  • audit/issues/problems/114-problem-main-testradforce-cpp.md
    • Added a new audit issue report.
  • audit/issues/problems/115-quokkasimulation-suolsonproblemcgs-setinitialconditionsongrid-testra.md
    • Added a new audit issue report.
  • audit/issues/problems/116-amrsimulation-streamingproblem-setcustomboundaryconditions-testradst.md
    • Added a new audit issue report.
  • audit/issues/problems/117-problem-main-testradstreamingy-cpp.md
    • Added a new audit issue report.
  • audit/issues/problems/118-quokkasimulation-shadowproblem-setinitialconditionsongrid-testradsha.md
    • Added a new audit issue report.
  • audit/issues/problems/119-quokkasimulation-shadowproblem-refinegrid-testradshadow-cpp.md
    • Added a new audit issue report.
  • audit/issues/problems/120-radsystem-tophatproblem-computeplanckopacity-testradtophat-cpp.md
    • Added a new audit issue report.
  • audit/issues/problems/121-amrsimulation-tophatproblem-setcustomboundaryconditions-testradtopha.md
    • Added a new audit issue report.
  • audit/issues/problems/122-quokkasimulation-tophatproblem-setinitialconditionsongrid-testradtop.md
    • Added a new audit issue report.
  • audit/issues/problems/123-radsystem-marshakproblem-setradenergysource-testradsuolson-cpp.md
    • Added a new audit issue report.
  • audit/issues/problems/124-radsystem-shellproblem-setradenergysource-testradhydroshell-cpp.md
    • Added a new audit issue report.
  • audit/issues/problems/125-quokkasimulation-shellproblem-setinitialconditionsongrid-testradhydr.md
    • Added a new audit issue report.
  • audit/issues/problems/126-quokkasimulation-shellproblem-refinegrid-testradhydroshell-cpp.md
    • Added a new audit issue report.
  • audit/issues/problems/127-problem-main-testradhydropulsegrey-cpp.md
    • Added a new audit issue report.
  • audit/issues/problems/128-quokkasimulation-exactproblem-setinitialconditionsongrid-testradhydr.md
    • Added a new audit issue report.
  • audit/issues/problems/129-problem-main-testradhydrobb-cpp.md
    • Added a new audit issue report.
  • audit/issues/problems/130-quokkasimulation-collapseproblem-setinitialconditionsongrid-testsphe.md
    • Added a new audit issue report.
  • audit/issues/problems/131-quokkasimulation-collapseproblem-createinitialcicparticles-testspher.md
    • Added a new audit issue report.
  • audit/issues/problems/132-quokkasimulation-snproblem-refinegrid-testsn-cpp.md
    • Added a new audit issue report.
  • audit/issues/problems/133-problem-main-testsn-cpp.md
    • Added a new audit issue report.
  • audit/issues/problems/134-quokkasimulation-turbulentbox-refinegrid-testturbulence-cpp.md
    • Added a new audit issue report.
  • audit/issues/problems/135-problem-main-testturbulence-cpp.md
    • Added a new audit issue report.
  • audit/issues/problems/136-quokkasimulation-starcluster-precalculateinitialconditions-teststarc.md
    • Added a new audit issue report.
  • audit/issues/problems/137-quokkasimulation-starcluster-setinitialconditionsongrid-teststarclus.md
    • Added a new audit issue report.
  • audit/issues/problems/138-quokkasimulation-popiii-precalculateinitialconditions-testpopiii-cpp.md
    • Added a new audit issue report.
  • audit/issues/problems/139-quokkasimulation-popiii-setinitialconditionsongrid-testpopiii-cpp.md
    • Added a new audit issue report.
  • audit/issues/problems/140-quokkasimulation-popiii-setinitialconditionsongrid-testpopiii-cpp.md
    • Added a new audit issue report.
  • audit/issues/problems/141-quokkasimulation-theproblem-refinegrid-testtallboxsf-cpp.md
    • Added a new audit issue report.
  • audit/issues/problems/142-quokkasimulation-theproblem-setinitialconditionsongrid-testtallboxsf.md
    • Added a new audit issue report.
  • audit/issues/problems/143-quokkasimulation-theproblem-addstrangsplitsources-testtallboxsf-cpp.md
    • Added a new audit issue report.
  • audit/issues/problems/144-amrsimulation-theproblem-setcustomboundaryconditions-testtallboxsf-c.md
    • Added a new audit issue report.
  • audit/issues/problems/145-quokkasimulation-diskgalaxy-setinitialconditionsongrid-testdiskgalax.md
    • Added a new audit issue report.
  • audit/src-files.txt
    • Added a list of source files.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a series of markdown files documenting the results of a semi-automated code audit. I have reviewed a significant sample of the reported issues across different categories, including potential bugs related to robustness, correctness, portability, and memory safety. The findings described in the markdown files appear to be valid and accurately identify issues in the codebase. The severity assessments are reasonable, and the proposed patches are appropriate solutions to the identified problems. This is a valuable set of findings that will improve the quality and reliability of the code.

@BenWibking
Copy link
Collaborator Author

Weiqun suggesting using a prompt like this:

I want you to check Source/ and if you find anything, give me a github issue style summary with suggested patches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant